Remove dependency on RemoteExecutor in tests

[RussKie]

Problem description:

RemoteExecutor has been used in a number of tests for the sole purpose of enabling visual styles. However RemoteExecutor has proven to be rather unstable (see: dotnet/arcade#5325).

The tests have been update to run with visual styles on by default in #4197, however RemoteExecutor hasn't been cleaned out.

We need to scan the codebase for RemoteExecutor (and "Skip = "Crash with AbandonedMutexException. See: dotnet/arcade#5325"") and update those tests, removing RemoteExecutor.

[ghost]

This issue is now marked as "up for grabs", and we’re looking for a community volunteer to work on this issue. If we receive no interest in 120 days, we will close the issue. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[willibrandon]

I can help with removing the RemoteExecutor dependency in tests.

What if anything should be done with tests that depend on RemoteExecutor but are not skipped?

[RussKie]

That'd be great!

We use/tried to use RemoteExecutor for situations where we need change the global state (e.g., disable visual styles, control the clipboard, the mouse or the keyboard, etc.). Because unit tests are run in parallel any changes to the global state destabilises the whole suite.
So one way of resolution is to migrate the RE-dependent tests to the UIIntegration test project that executes tests serially and can bootstrap each test as necessary without risks of affecting other tests.

[RussKie]

Here's some context #2192 (comment)

[willibrandon]

I have a stash with RemoteExecutor removed and if I recall correctly, there were at least 1 if not more problem tests that when un-skipped, caused other tests to fail. I'll bring myself back up to speed, migrate the RE-dependent tests to the UIIntegration test project, and check the results. Thank you for the context and resolution strategy.

That is good to know that the UIIntegration test project executes tests serially.

[RussKie]

We can do this in a staggered fashion - i.e., open a PR that fixes one or two tests, then fix another, etc., until all fixed.

[RussKie]

@willibrandon I'm assigning this to you. Please holler if you won't be able to work on it.

[ricardobossan]

@Tanya-Solyanik In #12379 I have re-enabled all tests that were previously skipped with the explanation:
Crash with AbandonedMutexException. See: https://github.com/dotnet/arcade/issues/5325.

Additionally, I restored the correct state of the Application.ParkingWindowTests.cs method by setting:
Control.CheckForIllegalCrossThreadCalls = true;.

Summary of Attempts:

• Approach 1:
  Removed RemoteExecutor only from Application.ParkingWindowTests.cs while simply re-enabling the other tests.

  • CI Checks Results

• Approach 2:
  Removed RemoteExecutor from all tests.

  • CI Checks Results

Both approaches passed local tests but failed automated CI checks.

For now, I’m pausing work on this issue to focus on higher-priority tasks. Let me know if you have any suggestions or would like me to revisit this sooner!