Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InvokeAsync does not finally check CancellationToken #12696

Open
HenKun opened this issue Dec 31, 2024 · 1 comment
Open

InvokeAsync does not finally check CancellationToken #12696

HenKun opened this issue Dec 31, 2024 · 1 comment
Assignees
Labels
🪲 bug Product bug (most likely)

Comments

@HenKun
Copy link

HenKun commented Dec 31, 2024

In contrast to the other overloads, InvokeAsync in

does not check the cancellationToken before finally invoking the delegate.

This should be done in order to

  • be consistent
  • avoid an unnecessary invocation
@elachlan elachlan added the 🪲 bug Product bug (most likely) label Jan 2, 2025
@kirsan31
Copy link
Contributor

kirsan31 commented Jan 2, 2025

Here was some comments about InvokeAsync implementation (including cancellationToken). Didn't checked it by myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Product bug (most likely)
Projects
None yet
Development

No branches or pull requests

4 participants