Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETE2ESDK] The parameter architecture and requesting should not be case sensitive in the Find Path feature. #1992

Open
NicoleWang001 opened this issue Oct 16, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed new-hire-issue P4

Comments

@NicoleWang001
Copy link
Member

Describe the bug.
If the value of parameter architecture and requesting contains uppercase letters, discovering .NET path is failed

Please attach log file(s) here if you have any.
The log file location should be copied to your clipboard if you came from VS Code.

Reproduction Steps
1.Download X64 SDK from https://dotnet.microsoft.com/en-us/download/dotnet and install.
2.Open VS Code and Run the 'Sample: Find the.NET on the PATH' command.
3. Enter the value of parameter architecture and requesting contains uppercase letters, eg. 'X64', or 'Greater_than_or_equal'
4.observe

Expected Behavior
.NET installation path should be found correctly

Exceptions & Errors (if any)
It returns non .NET installation path is found.
Image

.NET Install Tool Version
Preview 2.2.1

Your operating system? Please provide more detail, such as the version and or distro above.
N/A

VS Code Version
1.94.2

@nagilson
Copy link
Member

This is a good point, though this api will only be called by other code which will user lowercase version, so I would take this as a good first issue or open source thing to just lowercase the architecture string passed in here to the API.

@nagilson nagilson added help wanted Extra attention is needed good first issue Good for newcomers P4 new-hire-issue labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed new-hire-issue P4
Projects
None yet
Development

No branches or pull requests

2 participants