-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0.4xx] Multi-arch OCI images export as tarballs #46467
Open
surayya-MS
wants to merge
51
commits into
dotnet:release/8.0.4xx
Choose a base branch
from
surayya-MS:multi-arch-tarballs
base: release/8.0.4xx
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[release/8.0.4xx] Multi-arch OCI images export as tarballs #46467
surayya-MS
wants to merge
51
commits into
dotnet:release/8.0.4xx
from
surayya-MS:multi-arch-tarballs
+1,781
−824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… docker publishing
…s it is not supported
baronfel
reviewed
Feb 2, 2025
src/Containers/Microsoft.NET.Build.Containers/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
JanKrivanek
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
But you might want to get as well review from someone with closer domain knowledge
src/Containers/Microsoft.NET.Build.Containers/ImageIndexGenerator.cs
Outdated
Show resolved
Hide resolved
The changes made from the last review:
A test is failing on macos leg - which is unrelated to the changes in this PR. The PR is ready for review. |
MichalPavlik
reviewed
Feb 6, 2025
MichalPavlik
reviewed
Feb 6, 2025
MichalPavlik
reviewed
Feb 6, 2025
src/Containers/Microsoft.NET.Build.Containers/MultiArchImage.cs
Outdated
Show resolved
Hide resolved
MichalPavlik
reviewed
Feb 6, 2025
src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateImageIndex.cs
Outdated
Show resolved
Hide resolved
MichalPavlik
approved these changes
Feb 6, 2025
…ctory; add ArchiveFileRegistryTests
rainersigwald
approved these changes
Feb 7, 2025
src/Containers/Microsoft.NET.Build.Containers/ImageIndexGenerator.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/LocalDaemons/ArchiveFileRegistry.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImage.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes dotnet/sdk-container-builds#609
This is a feature request from partner team - support publishing multi-arch OCI image as one combined tarball. Currently we publish separate tarballs for each architecture.
Details
Current behavior for multi-arch image publishing
Behaviour after this PR
Note: in order to load a multi-arch oci image tarball, containerd image store should be enabled for Docker.
Changes made
DockerCli
.CreateNewImage
task into a separate class, to be able to reuse it inCreateImageIndex
task.SkipPublishing
parameter inCreateNewImage
task, in order to create an image but skip publish it (this is needed for multi-arch tarball publishing because we need to publish one combined tarball)Testing
Modified end to end multi-arch tests to reflect the new behavior. Tested manually as well.