-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch verb and noun for package/reference add/remove/list Fixes #9650 #45384
Conversation
…switch-verb-noun
@OliaG , would you please review the UX changes proposed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static readonly CliOption OutdatedOption = new ForwardedOption<bool>("--outdated") | ||
{ | ||
Description = LocalizableStrings.CmdOutdatedDescription | ||
}.ForwardAs("--outdated"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shows my unfamiliarity with this but why does both ForwardedOption
's constructor and ForwardAs
have the same string for bool
options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er...great question. I didn't even notice; as you pointed out, a lot of these changes were just moving things from one file to another, and this is an example. @baronfel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
baronfel told me that ForwardedOption is an option with a null forwarding function—that is, it doesn't actually specify how it should be forwarded, just makes that possible if you also specify ForwardAs and how to forward it.
We'll need to doc this in the 10.0 preview 2 release notes and in the 9.0.300 changelogs (for future-Chet's reference). |
Fixes #9650
Switches the ordering of commands from
dotnet verb noun
todotnet noun verb
, as it is sometimes unclear what 'add' adds, for instance, and this is how many users of other CLIs think.In this version,
dotnet verb noun
(DVN) is still supported in that it works when used, butdotnet noun verb
(DNV) is the priority. DVN is now hidden and doesn't appear in the help text, whereas DNV is visible and does appear in the help text.Incomplete:
We need to change how we accept arguments. This is still a point of discussion, so we need to build consensus on the right order before proceeding. (Possibilities include
dotnet package <package> add <project>
,dotnet package add <package> --project <project>
, etc.)We should consider adding a message when using DVN directing users to DNV