Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/windowsdesktop #42366

Merged
merged 7 commits into from
Jul 27, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 25, 2024

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Sdk.WindowsDesktop: from 9.0.0-rc.1.24373.9 to 9.0.0-rc.1.24376.2 (parent: Microsoft.WindowsDesktop.App.Ref)
    • Microsoft.Dotnet.WinForms.ProjectTemplates: from 9.0.0-preview.7.24373.1 to 9.0.0-rc.1.24375.5 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.DotNet.Wpf.ProjectTemplates: from 9.0.0-rc.1.24373.9 to 9.0.0-rc.1.24376.2 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)

From https://github.com/dotnet/windowsdesktop

  • Subscription: 43b77b68-0b3c-49dd-3915-08d8e9750bf8
  • Build: 20240727.1
  • Date Produced: July 27, 2024 8:41:10 AM UTC
  • Commit: abbfd5307785fcf7d991898be4118eb8f8280472
  • Branch: refs/heads/main

…ld 20240725.2

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-rc.1.24374.1 -> To Version 9.0.0-rc.1.24375.2

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates
 From Version 9.0.0-rc.1.24373.9 -> To Version 9.0.0-rc.1.24374.2 (parent: Microsoft.WindowsDesktop.App.Ref
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Jul 25, 2024
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

…ld 20240725.3

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-rc.1.24374.1 -> To Version 9.0.0-rc.1.24375.3

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates
 From Version 9.0.0-rc.1.24373.9 -> To Version 9.0.0-rc.1.24374.2 (parent: Microsoft.WindowsDesktop.App.Ref
…ld 20240725.5

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-rc.1.24374.1 -> To Version 9.0.0-rc.1.24375.5

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates
 From Version 9.0.0-rc.1.24373.9 -> To Version 9.0.0-rc.1.24375.4 (parent: Microsoft.WindowsDesktop.App.Ref
@nagilson nagilson enabled auto-merge July 25, 2024 22:35
…ld 20240726.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-rc.1.24374.1 -> To Version 9.0.0-rc.1.24376.1

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates
 From Version 9.0.0-rc.1.24373.9 -> To Version 9.0.0-rc.1.24375.5 (parent: Microsoft.WindowsDesktop.App.Ref
@nagilson
Copy link
Member

@dotnet/product-construction PTAL at this heat error.

src\windowsdesktop\artifacts\sb\package-cache\microsoft.dotnet.build.tasks.installers\9.0.0-beta.24368.9\build\wix\wix.targets(264,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command "heat.exe ^
          dir "D:\a\_work\1\vmr\src\windowsdesktop\artifacts\obj\Microsoft.WindowsDesktop.App.Ref\Release\net9.0\win-x64\output/" ^
          -nologo ^
          -template fragment ^
          -sreg ^
          -ag ^
          -var var.PackSrc ^
          -cg InstallFiles ^
          -srd ^
          -dr DOTNETHOME ^
          -out D:\a\_work\1\vmr\src\windowsdesktop\artifacts\obj\Microsoft.WindowsDesktop.App.Ref\Release\net9.0\win-x64\/wix/install-files.wxs
          " exited with code 5059.

@ViktorHofer
Copy link
Member

D:\a_work\1\vmr\src\windowsdesktop\artifacts\obj\Microsoft.WindowsDesktop.App.Ref\Release\net9.0\win-x64\output\packs\Microsoft.WindowsDesktop.App.Ref\9.0.0-rc.1.24376.1\analyzers\dotnet\cs\zh-Hans\System.Windows.Forms.Analyzers.CodeFixes.CSharp.resources.dll

This path is 260 characters and can't be read by heat.exe because it's too long. cc @KlausLoeffelmann @mmitche @jkoritzinsky

…ld 20240726.2

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-rc.1.24374.1 -> To Version 9.0.0-rc.1.24376.2

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates
 From Version 9.0.0-rc.1.24373.9 -> To Version 9.0.0-rc.1.24376.2 (parent: Microsoft.WindowsDesktop.App.Ref
@KlausLoeffelmann
Copy link
Member

@ViktorHofer: So, do you know how long can it be at most? 255?

@ViktorHofer
Copy link
Member

MAX_PATH is 256 characters, yes.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jul 27, 2024

The TFM shouldn't be necessary in the intermediate and final output paths as ref packs never multi-target.

You should be able to set this in the Windows windowsdesktop ref Pack project:

<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>

Note that I will be out soon for an extended period of time. Please work with the above tagged people if you have more questions.

@KlausLoeffelmann
Copy link
Member

This one?

…ld 20240727.1

Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.9.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.9.0
 From Version 9.0.0-rc.1.24374.1 -> To Version 9.0.0-rc.1.24377.1

Dependency coherency updates

Microsoft.NET.Sdk.WindowsDesktop,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.DotNet.Wpf.ProjectTemplates
 From Version 9.0.0-rc.1.24373.9 -> To Version 9.0.0-rc.1.24376.2 (parent: Microsoft.WindowsDesktop.App.Ref
@nagilson nagilson merged commit 74dafbf into main Jul 27, 2024
40 of 41 checks passed
@nagilson nagilson deleted the darc-main-e232f6a6-614a-4024-a369-5ad325f59971 branch July 27, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow Area-VMR untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants