Skip to content

Commit 992e3bb

Browse files
committed
Update aspnetcore patch
1 parent f8855f2 commit 992e3bb

File tree

1 file changed

+19
-44
lines changed

1 file changed

+19
-44
lines changed
Lines changed: 19 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,15 @@
1+
From d37bcaf1cc55f4dd34ddad48ad726fc413c1a25b Mon Sep 17 00:00:00 2001
2+
From: Jeremy Koritzinsky <[email protected]>
3+
Date: Fri, 13 Dec 2024 13:33:17 -0800
4+
Subject: [PATCH 1/5] In VMR builds, a host-SDK crossgen will always be
5+
available.
16

2-
From d37bcaf1cc55f4dd34ddad48ad726fc413c1a25b Fri Dec 13 13:33:17 2024
3-
Author: Jeremy Koritzinsky <[email protected]>
4-
Date: Fri Dec 13 13:33:17 2024 -0800
5-
Subject: [PATCH] In VMR builds, a host-SDK crossgen will always be available.
7+
Backport: https://github.com/dotnet/aspnetcore/pull/59551
68

7-
Backport: TBD
89
---
910

10-
diff --git a/eng/tools/GenerateFiles/Directory.Build.targets.in b/eng/tools/GenerateFiles/Directory.Build.targets.in
11-
index 88f09a8c89..66976bd6cd 100644
12-
--- a/eng/tools/GenerateFiles/Directory.Build.targets.in
13-
+++ b/eng/tools/GenerateFiles/Directory.Build.targets.in
14-
@@ -108,7 +108,7 @@
15-
<KnownCrossgen2Pack Update="Microsoft.NETCore.App.Crossgen2">
16-
<Crossgen2PackVersion
17-
Condition=" '%(TargetFramework)' == '${DefaultNetCoreTargetFramework}' ">${MicrosoftNETCoreAppRuntimeVersion}</Crossgen2PackVersion>
18-
- <Crossgen2RuntimeIdentifiers Condition=" '$(DotNetBuildSourceOnly)' == 'true' ">$(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
19-
+ <Crossgen2RuntimeIdentifiers Condition="'$(DotNetBuildOrchestrator)' == 'true'">$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
20-
</KnownCrossgen2Pack>
21-
22-
<KnownILLinkPack Update="Microsoft.NET.ILLink.Tasks" Condition=" '$(DotNetBuildSourceOnly)' == 'true' ">
2311
diff --git a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj
24-
index 68d2861437..7d75aa7f8c 100644
12+
index 68d28614376b..7d75aa7f8caf 100644
2513
--- a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj
2614
+++ b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj
2715
@@ -15,8 +15,6 @@
@@ -34,7 +22,7 @@ index 68d2861437..7d75aa7f8c 100644
3422
<!-- Don't use ReadyToRun when explicitly opted out -->
3523
<PublishReadyToRun Condition="'$(CrossgenOutput)' == 'false'">false</PublishReadyToRun>
3624
diff --git a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj
37-
index d3160de441..533c6840f9 100644
25+
index d3160de441ac..533c6840f9e0 100644
3826
--- a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj
3927
+++ b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj
4028
@@ -15,8 +15,6 @@
@@ -47,7 +35,7 @@ index d3160de441..533c6840f9 100644
4735
<!-- Don't use ReadyToRun when explicitly opted out -->
4836
<PublishReadyToRun Condition="'$(CrossgenOutput)' == 'false'">false</PublishReadyToRun>
4937
diff --git a/eng/tools/GenerateFiles/Directory.Build.targets.in b/eng/tools/GenerateFiles/Directory.Build.targets.in
50-
index 66976bd6cd..535ad48b08 100644
38+
index 66976bd6cd56..535ad48b08f3 100644
5139
--- a/eng/tools/GenerateFiles/Directory.Build.targets.in
5240
+++ b/eng/tools/GenerateFiles/Directory.Build.targets.in
5341
@@ -80,7 +80,8 @@
@@ -60,8 +48,9 @@ index 66976bd6cd..535ad48b08 100644
6048
</KnownFrameworkReference>
6149

6250
<KnownAppHostPack Update="Microsoft.NETCore.App">
51+
6352
diff --git a/eng/targets/Sfx.Common.targets b/eng/targets/Sfx.Common.targets
64-
index 5ff818b44f..c587e3760e 100644
53+
index 5ff818b44f2d..c587e3760e83 100644
6554
--- a/eng/targets/Sfx.Common.targets
6655
+++ b/eng/targets/Sfx.Common.targets
6756
@@ -36,4 +36,13 @@
@@ -74,43 +63,29 @@ index 5ff818b44f..c587e3760e 100644
7463
+ <PackageDownload Include="Microsoft.NETCore.Platforms" Version="[$(MicrosoftNETCorePlatformsVersion)]" />
7564
+ </ItemGroup>
7665
+
77-
+ <PropertyGroup Condition="Exists('$(NuGetPackageRoot)Microsoft.NETCore.Platforms/$(MicrosoftNETCorePlatformsVersion)')">
78-
+ <RuntimeIdentifierGraphPath>$(NuGetPackageRoot)Microsoft.NETCore.Platforms/$(MicrosoftNETCorePlatformsVersion)/PortableRuntimeIdentifierGraph.json</RuntimeIdentifierGraphPath>
79-
+ </PropertyGroup>
80-
</Project>
81-
diff --git a/eng/targets/Sfx.Common.targets b/eng/targets/Sfx.Common.targets
82-
index c587e3760e..f97b379391 100644
83-
--- a/eng/targets/Sfx.Common.targets
84-
+++ b/eng/targets/Sfx.Common.targets
85-
@@ -42,7 +42,7 @@
86-
<PackageDownload Include="Microsoft.NETCore.Platforms" Version="[$(MicrosoftNETCorePlatformsVersion)]" />
87-
</ItemGroup>
88-
89-
- <PropertyGroup Condition="Exists('$(NuGetPackageRoot)Microsoft.NETCore.Platforms/$(MicrosoftNETCorePlatformsVersion)')">
90-
- <RuntimeIdentifierGraphPath>$(NuGetPackageRoot)Microsoft.NETCore.Platforms/$(MicrosoftNETCorePlatformsVersion)/PortableRuntimeIdentifierGraph.json</RuntimeIdentifierGraphPath>
9166
+ <PropertyGroup Condition="Exists('$(NuGetPackageRoot)microsoft.netcore.platforms/$(MicrosoftNETCorePlatformsVersion)')">
9267
+ <RuntimeIdentifierGraphPath>$(NuGetPackageRoot)microsoft.netcore.platforms/$(MicrosoftNETCorePlatformsVersion)/PortableRuntimeIdentifierGraph.json</RuntimeIdentifierGraphPath>
93-
</PropertyGroup>
68+
+ </PropertyGroup>
9469
</Project>
70+
9571
diff --git a/eng/tools/GenerateFiles/Directory.Build.targets.in b/eng/tools/GenerateFiles/Directory.Build.targets.in
96-
index 4d56e7e3f1..535ad48b08 100644
72+
index 535ad48b08f3..4d56e7e3f139 100644
9773
--- a/eng/tools/GenerateFiles/Directory.Build.targets.in
9874
+++ b/eng/tools/GenerateFiles/Directory.Build.targets.in
9975
@@ -81,7 +81,7 @@
10076
'%(TargetFramework)' == '${DefaultNetCoreTargetFramework}' AND
10177
'$(TargetLatestDotNetRuntime)' != 'false' ">${MicrosoftNETCoreAppRuntimeVersion}</DefaultRuntimeFrameworkVersion>
10278
<!-- Workaround https://github.com/dotnet/sdk/pull/45487: The .NET SDK requires the crossgen2 host runtime identifier to be in the runtime pack runtime identifiers list. -->
103-
- <RuntimePackRuntimeIdentifiers Condition="'$(DotNetBuild)' == 'true'">%(RuntimePackRuntimeIdentifiers);$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</RuntimePackRuntimeIdentifiers>
104-
+ <RuntimePackRuntimeIdentifiers Condition="'$(DotNetBuildOrchestrator)' == 'true'">$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</RuntimePackRuntimeIdentifiers>
79+
- <RuntimePackRuntimeIdentifiers Condition="'$(DotNetBuildOrchestrator)' == 'true'">$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</RuntimePackRuntimeIdentifiers>
80+
+ <RuntimePackRuntimeIdentifiers Condition="'$(DotNetBuild)' == 'true'">%(RuntimePackRuntimeIdentifiers);$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</RuntimePackRuntimeIdentifiers>
10581
</KnownFrameworkReference>
10682

10783
<KnownAppHostPack Update="Microsoft.NETCore.App">
108-
@@ -109,7 +109,7 @@
109-
<KnownCrossgen2Pack Update="Microsoft.NETCore.App.Crossgen2">
84+
@@ -110,6 +110,6 @@
11085
<Crossgen2PackVersion
11186
Condition=" '%(TargetFramework)' == '${DefaultNetCoreTargetFramework}' ">${MicrosoftNETCoreAppRuntimeVersion}</Crossgen2PackVersion>
112-
- <Crossgen2RuntimeIdentifiers Condition="'$(DotNetBuild)' == 'true'">%(Crossgen2RuntimeIdentifiers);$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
113-
+ <Crossgen2RuntimeIdentifiers Condition="'$(DotNetBuildOrchestrator)' == 'true'">$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
87+
- <Crossgen2RuntimeIdentifiers Condition=" '$(DotNetBuildSourceOnly)' == 'true' ">$(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
88+
+ <Crossgen2RuntimeIdentifiers Condition="'$(DotNetBuild)' == 'true'">%(Crossgen2RuntimeIdentifiers);$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
11489
</KnownCrossgen2Pack>
11590

11691
<KnownILLinkPack Update="Microsoft.NET.ILLink.Tasks" Condition=" '$(DotNetBuildSourceOnly)' == 'true' ">

0 commit comments

Comments
 (0)