1
+ From d37bcaf1cc55f4dd34ddad48ad726fc413c1a25b Mon Sep 17 00:00:00 2001
2
+ From: Jeremy Koritzinsky <
[email protected] >
3
+ Date: Fri, 13 Dec 2024 13:33:17 -0800
4
+ Subject: [PATCH 1/5] In VMR builds, a host-SDK crossgen will always be
5
+ available.
1
6
2
- From d37bcaf1cc55f4dd34ddad48ad726fc413c1a25b Fri Dec 13 13:33:17 2024
3
- Author: Jeremy Koritzinsky <
[email protected] >
4
- Date: Fri Dec 13 13:33:17 2024 -0800
5
- Subject: [PATCH] In VMR builds, a host-SDK crossgen will always be available.
7
+ Backport: https://github.com/dotnet/aspnetcore/pull/59551
6
8
7
- Backport: TBD
8
9
---
9
10
10
- diff --git a/eng/tools/GenerateFiles/Directory.Build.targets.in b/eng/tools/GenerateFiles/Directory.Build.targets.in
11
- index 88f09a8c89..66976bd6cd 100644
12
- --- a/eng/tools/GenerateFiles/Directory.Build.targets.in
13
- +++ b/eng/tools/GenerateFiles/Directory.Build.targets.in
14
- @@ -108,7 +108,7 @@
15
- <KnownCrossgen2Pack Update="Microsoft.NETCore.App.Crossgen2">
16
- <Crossgen2PackVersion
17
- Condition=" '%(TargetFramework)' == '${DefaultNetCoreTargetFramework}' ">${MicrosoftNETCoreAppRuntimeVersion}</Crossgen2PackVersion>
18
- - <Crossgen2RuntimeIdentifiers Condition=" '$(DotNetBuildSourceOnly)' == 'true' ">$(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
19
- + <Crossgen2RuntimeIdentifiers Condition="'$(DotNetBuildOrchestrator)' == 'true'">$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
20
- </KnownCrossgen2Pack>
21
-
22
- <KnownILLinkPack Update="Microsoft.NET.ILLink.Tasks" Condition=" '$(DotNetBuildSourceOnly)' == 'true' ">
23
11
diff --git a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj
24
- index 68d2861437..7d75aa7f8c 100644
12
+ index 68d28614376b..7d75aa7f8caf 100644
25
13
--- a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj
26
14
+++ b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj
27
15
@@ -15,8 +15,6 @@
@@ -34,7 +22,7 @@ index 68d2861437..7d75aa7f8c 100644
34
22
<!-- Don't use ReadyToRun when explicitly opted out -->
35
23
<PublishReadyToRun Condition="'$(CrossgenOutput)' == 'false'">false</PublishReadyToRun>
36
24
diff --git a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj
37
- index d3160de441..533c6840f9 100644
25
+ index d3160de441ac..533c6840f9e0 100644
38
26
--- a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj
39
27
+++ b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj
40
28
@@ -15,8 +15,6 @@
@@ -47,7 +35,7 @@ index d3160de441..533c6840f9 100644
47
35
<!-- Don't use ReadyToRun when explicitly opted out -->
48
36
<PublishReadyToRun Condition="'$(CrossgenOutput)' == 'false'">false</PublishReadyToRun>
49
37
diff --git a/eng/tools/GenerateFiles/Directory.Build.targets.in b/eng/tools/GenerateFiles/Directory.Build.targets.in
50
- index 66976bd6cd..535ad48b08 100644
38
+ index 66976bd6cd56..535ad48b08f3 100644
51
39
--- a/eng/tools/GenerateFiles/Directory.Build.targets.in
52
40
+++ b/eng/tools/GenerateFiles/Directory.Build.targets.in
53
41
@@ -80,7 +80,8 @@
@@ -60,8 +48,9 @@ index 66976bd6cd..535ad48b08 100644
60
48
</KnownFrameworkReference>
61
49
62
50
<KnownAppHostPack Update="Microsoft.NETCore.App">
51
+
63
52
diff --git a/eng/targets/Sfx.Common.targets b/eng/targets/Sfx.Common.targets
64
- index 5ff818b44f..c587e3760e 100644
53
+ index 5ff818b44f2d..c587e3760e83 100644
65
54
--- a/eng/targets/Sfx.Common.targets
66
55
+++ b/eng/targets/Sfx.Common.targets
67
56
@@ -36,4 +36,13 @@
@@ -74,43 +63,29 @@ index 5ff818b44f..c587e3760e 100644
74
63
+ <PackageDownload Include="Microsoft.NETCore.Platforms" Version="[$(MicrosoftNETCorePlatformsVersion)]" />
75
64
+ </ItemGroup>
76
65
+
77
- + <PropertyGroup Condition="Exists('$(NuGetPackageRoot)Microsoft.NETCore.Platforms/$(MicrosoftNETCorePlatformsVersion)')">
78
- + <RuntimeIdentifierGraphPath>$(NuGetPackageRoot)Microsoft.NETCore.Platforms/$(MicrosoftNETCorePlatformsVersion)/PortableRuntimeIdentifierGraph.json</RuntimeIdentifierGraphPath>
79
- + </PropertyGroup>
80
- </Project>
81
- diff --git a/eng/targets/Sfx.Common.targets b/eng/targets/Sfx.Common.targets
82
- index c587e3760e..f97b379391 100644
83
- --- a/eng/targets/Sfx.Common.targets
84
- +++ b/eng/targets/Sfx.Common.targets
85
- @@ -42,7 +42,7 @@
86
- <PackageDownload Include="Microsoft.NETCore.Platforms" Version="[$(MicrosoftNETCorePlatformsVersion)]" />
87
- </ItemGroup>
88
-
89
- - <PropertyGroup Condition="Exists('$(NuGetPackageRoot)Microsoft.NETCore.Platforms/$(MicrosoftNETCorePlatformsVersion)')">
90
- - <RuntimeIdentifierGraphPath>$(NuGetPackageRoot)Microsoft.NETCore.Platforms/$(MicrosoftNETCorePlatformsVersion)/PortableRuntimeIdentifierGraph.json</RuntimeIdentifierGraphPath>
91
66
+ <PropertyGroup Condition="Exists('$(NuGetPackageRoot)microsoft.netcore.platforms/$(MicrosoftNETCorePlatformsVersion)')">
92
67
+ <RuntimeIdentifierGraphPath>$(NuGetPackageRoot)microsoft.netcore.platforms/$(MicrosoftNETCorePlatformsVersion)/PortableRuntimeIdentifierGraph.json</RuntimeIdentifierGraphPath>
93
- </PropertyGroup>
68
+ + </PropertyGroup>
94
69
</Project>
70
+
95
71
diff --git a/eng/tools/GenerateFiles/Directory.Build.targets.in b/eng/tools/GenerateFiles/Directory.Build.targets.in
96
- index 4d56e7e3f1..535ad48b08 100644
72
+ index 535ad48b08f3..4d56e7e3f139 100644
97
73
--- a/eng/tools/GenerateFiles/Directory.Build.targets.in
98
74
+++ b/eng/tools/GenerateFiles/Directory.Build.targets.in
99
75
@@ -81,7 +81,7 @@
100
76
'%(TargetFramework)' == '${DefaultNetCoreTargetFramework}' AND
101
77
'$(TargetLatestDotNetRuntime)' != 'false' ">${MicrosoftNETCoreAppRuntimeVersion}</DefaultRuntimeFrameworkVersion>
102
78
<!-- Workaround https://github.com/dotnet/sdk/pull/45487: The .NET SDK requires the crossgen2 host runtime identifier to be in the runtime pack runtime identifiers list. -->
103
- - <RuntimePackRuntimeIdentifiers Condition="'$(DotNetBuild )' == 'true'">%(RuntimePackRuntimeIdentifiers); $(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</RuntimePackRuntimeIdentifiers>
104
- + <RuntimePackRuntimeIdentifiers Condition="'$(DotNetBuildOrchestrator )' == 'true'">$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</RuntimePackRuntimeIdentifiers>
79
+ - <RuntimePackRuntimeIdentifiers Condition="'$(DotNetBuildOrchestrator )' == 'true'">$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</RuntimePackRuntimeIdentifiers>
80
+ + <RuntimePackRuntimeIdentifiers Condition="'$(DotNetBuild )' == 'true'">%(RuntimePackRuntimeIdentifiers); $(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</RuntimePackRuntimeIdentifiers>
105
81
</KnownFrameworkReference>
106
82
107
83
<KnownAppHostPack Update="Microsoft.NETCore.App">
108
- @@ -109,7 +109,7 @@
109
- <KnownCrossgen2Pack Update="Microsoft.NETCore.App.Crossgen2">
84
+ @@ -110,6 +110,6 @@
110
85
<Crossgen2PackVersion
111
86
Condition=" '%(TargetFramework)' == '${DefaultNetCoreTargetFramework}' ">${MicrosoftNETCoreAppRuntimeVersion}</Crossgen2PackVersion>
112
- - <Crossgen2RuntimeIdentifiers Condition="'$(DotNetBuild )' == 'true'">%(Crossgen2RuntimeIdentifiers);$(NETCoreSdkRuntimeIdentifier); $(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
113
- + <Crossgen2RuntimeIdentifiers Condition="'$(DotNetBuildOrchestrator )' == 'true'">$(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
87
+ - <Crossgen2RuntimeIdentifiers Condition=" '$(DotNetBuildSourceOnly )' == 'true' "> $(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
88
+ + <Crossgen2RuntimeIdentifiers Condition="'$(DotNetBuild )' == 'true'">%(Crossgen2RuntimeIdentifiers); $(NETCoreSdkRuntimeIdentifier);$(TargetRuntimeIdentifier)</Crossgen2RuntimeIdentifiers>
114
89
</KnownCrossgen2Pack>
115
90
116
91
<KnownILLinkPack Update="Microsoft.NET.ILLink.Tasks" Condition=" '$(DotNetBuildSourceOnly)' == 'true' ">
0 commit comments