Skip to content

Commit 8621a6a

Browse files
authored
[release/9.0.3xx] Update dependencies from dotnet/msbuild (#46358)
2 parents e6366a5 + 6290bf2 commit 8621a6a

File tree

3 files changed

+16
-13
lines changed

3 files changed

+16
-13
lines changed

eng/Version.Details.xml

+6-6
Original file line numberDiff line numberDiff line change
@@ -69,18 +69,18 @@
6969
<Sha>763d10a1a251be35337ee736832bfde3f9200672</Sha>
7070
<SourceBuild RepoName="emsdk" ManagedOnly="true" />
7171
</Dependency>
72-
<Dependency Name="Microsoft.Build" Version="17.14.0-preview-25073-02">
72+
<Dependency Name="Microsoft.Build" Version="17.14.0-preview-25081-02">
7373
<Uri>https://github.com/dotnet/msbuild</Uri>
74-
<Sha>291a8108761ed347562228f2f8f25477996a5a93</Sha>
74+
<Sha>7e539c169a657040eeb768e8115c44f1780e59df</Sha>
7575
</Dependency>
76-
<Dependency Name="Microsoft.Build.Localization" Version="17.14.0-preview-25073-02">
76+
<Dependency Name="Microsoft.Build.Localization" Version="17.14.0-preview-25081-02">
7777
<Uri>https://github.com/dotnet/msbuild</Uri>
78-
<Sha>291a8108761ed347562228f2f8f25477996a5a93</Sha>
78+
<Sha>7e539c169a657040eeb768e8115c44f1780e59df</Sha>
7979
</Dependency>
8080
<!-- Intermediate is necessary for source build. -->
81-
<Dependency Name="Microsoft.SourceBuild.Intermediate.msbuild" Version="17.14.0-preview-25073-02">
81+
<Dependency Name="Microsoft.SourceBuild.Intermediate.msbuild" Version="17.14.0-preview-25081-02">
8282
<Uri>https://github.com/dotnet/msbuild</Uri>
83-
<Sha>291a8108761ed347562228f2f8f25477996a5a93</Sha>
83+
<Sha>7e539c169a657040eeb768e8115c44f1780e59df</Sha>
8484
<SourceBuild RepoName="msbuild" ManagedOnly="true" />
8585
</Dependency>
8686
<Dependency Name="Microsoft.FSharp.Compiler" Version="13.9.300-beta.25079.4">

eng/Versions.props

+2-2
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,8 @@
178178
At usage sites, either we use MicrosoftBuildMinimumVersion, or MicrosoftBuildVersion in source-only modes.
179179
180180
Additionally, set the MinimumVSVersion for the installer UI that's required for targeting NetCurrent -->
181-
<MicrosoftBuildVersion>17.14.0-preview-25073-02</MicrosoftBuildVersion>
182-
<MicrosoftBuildLocalizationVersion>17.14.0-preview-25073-02</MicrosoftBuildLocalizationVersion>
181+
<MicrosoftBuildVersion>17.14.0-preview-25081-02</MicrosoftBuildVersion>
182+
<MicrosoftBuildLocalizationVersion>17.14.0-preview-25081-02</MicrosoftBuildLocalizationVersion>
183183
<MicrosoftBuildMinimumVersion Condition="'$(DotNetBuildSourceOnly)' != 'true'">17.11.4</MicrosoftBuildMinimumVersion>
184184
<MinimumVSVersion>17.12</MinimumVSVersion>
185185
</PropertyGroup>

test/Microsoft.NET.Build.Tests/GivenThatWeWantMSBuildToRespectCustomCulture.cs

+8-5
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,11 @@ public void SupportRespectAlreadyAssignedItemCulture_ByDefault_ForDotnet9(string
2727
new FileInfo(Path.Combine(outputDirectory, "test-2", "MSBuildCultureResourceGeneration.resources.dll")).Should().Exist();
2828
}
2929

30-
[CoreMSBuildOnlyTheory]
3130
[InlineData("net7.0")]
3231
[InlineData("net6.0")]
32+
// Until MSBuild 17.13 is merged into FullFW MSBuild in sdk tests - the WarnOnCultureOverwritten
33+
// is not supported - and the build will fail copy (more details in the last test).
34+
[CoreMSBuildOnlyTheory]
3335
public void SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldWarn(string targetFramework)
3436
{
3537
var testAsset = _testAssetsManager
@@ -39,17 +41,18 @@ public void SupportRespectAlreadyAssignedItemCulture_IsNotSupported_BuildShouldW
3941

4042
var buildCommand = new BuildCommand(testAsset);
4143
// Custom culture is allowed, but if set explicitly and overwritten - a warning is issued.
42-
buildCommand.Execute().Should().Pass().And
44+
// However the warning is explicit opt-in.
45+
buildCommand.Execute("/p:WarnOnCultureOverwritten=true").Should().Pass().And
4346
// warning MSB3002: Explicitly set culture "test-1" for item "Resources.test-1.resx" was overwritten with inferred culture "", because 'RespectAlreadyAssignedItemCulture' property was not set.
4447
.HaveStdOutContaining("warning MSB3002:");
4548
}
4649

47-
[FullMSBuildOnlyTheory]
50+
[Theory]
4851
[InlineData("net7.0")]
4952
[InlineData("net6.0")]
50-
// Is this Failing? Is full FW MSBuild already on 17.13? Then remove this test and remove `[CoreMSBuildOnlyTheory]` attribute on the test above
53+
// Is this Failing? Check if WarnOnCultureOverwritten hasn't been made a default opt-in in sdk or MSBuild.
5154
//
52-
// Until MSBuild 17.13 is merged into FullFW MSBuild in sdk tests - the test will fail, as
55+
// Without explicit opt-in via WarnOnCultureOverwritten - the test will fail, as
5356
// proper recognition of custom cultures in RAR is not supported and hence the build will fail during copy:
5457
//
5558
// Microsoft.Common.CurrentVersion.targets(4959,5): error MSB3030: Could not copy the file "obj\Debug\net7.0\test-1\MSBuildCultureResourceGeneration.resources.dll" because it was not found.

0 commit comments

Comments
 (0)