Consider using IUtf8SpanParseable/IUtf8SpanFormattable in STJ's built-in converters.

[EgorBo]

MinimalAPI benchmark has a DateOnly field in an object it then serializes to utf8 json.

It seems that STJ doesn't have a fast-path DateOnly -> UTF8 like it has for e.g. DateTime and DateTimeOffset. Instead, it does DateOnly -> UTF16 string and then converts it to Utf8.

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/DateOnlyConverter.cs

Lines 60 to 63 in 50c9dca

	Span<char> buffer = stackalloc char[FormatLength];
	bool formattedSuccessfully = value.TryFormat(buffer, out int charsWritten, "O", CultureInfo.InvariantCulture);
	Debug.Assert(formattedSuccessfully && charsWritten == FormatLength);
	writer.WriteStringValue(buffer);

[ghost]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

---

MinimalAPI benchmark has a DateOnly field in an object it then serializes to utf8 json.

It seems that STJ doesn't have a fast-path DateOnly -> UTF8 like it has for e.g. DateTime and DateTimeOffset. Instead, it does DateOnly -> UTF16 string and then converts it to Utf8.

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/DateOnlyConverter.cs

Lines 60 to 63 in 50c9dca

	Span<char> buffer = stackalloc char[FormatLength];
	bool formattedSuccessfully = value.TryFormat(buffer, out int charsWritten, "O", CultureInfo.InvariantCulture);
	Debug.Assert(formattedSuccessfully && charsWritten == FormatLength);
	writer.WriteStringValue(buffer);

Author:	EgorBo
Assignees:	-
Labels:	area-System.Text.Json, untriaged
Milestone:	-

[eiriktsarpalis]

STJ uses bespoke formatting logic in order to support formatting dates directly to UTF-8. I wouldn't be too keen to repeat this for DateOnly, or whatever other type we want to support out of the box. Instead, we should consider adding DateOnly and TimeOnly overloads to the Utf8Formatter class so the converter can use that in newer TFMs.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-buffers
See info in area-owners.md if you want to be subscribed.

Issue Details

---

MinimalAPI benchmark has a DateOnly field in an object it then serializes to utf8 json.

It seems that STJ doesn't have a fast-path DateOnly -> UTF8 like it has for e.g. DateTime and DateTimeOffset. Instead, it does DateOnly -> UTF16 string and then converts it to Utf8.

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/DateOnlyConverter.cs

Lines 60 to 63 in 50c9dca

	Span<char> buffer = stackalloc char[FormatLength];
	bool formattedSuccessfully = value.TryFormat(buffer, out int charsWritten, "O", CultureInfo.InvariantCulture);
	Debug.Assert(formattedSuccessfully && charsWritten == FormatLength);
	writer.WriteStringValue(buffer);

Author:	EgorBo
Assignees:	-
Labels:	area-System.Buffers, untriaged
Milestone:	-

[tannergooding]

Worth noting we approved IUtf8SpanFormattable and IUtf8SpanParsable. The plan is to implement those on all the primitive/built-in types for .NET 8, including DateOnly and TimeOnly: #81500

Utf8Formatter/Parser support may still be beneficial since it has slightly different semantics (stops at the first invalid character, rather than fails at the first invalid character). However, that sounds like it may not be an overly important distinction for this scenario.

[stephentoub]

#84469 adds IUtf8SpanFormattable to DateOnly.

But the time we're done with implementing IUtf8SpanFormattable everywhere that currently implements ISpanFormattable, I expect Utf8Formatter will effectively be obsolete.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

---

MinimalAPI benchmark has a DateOnly field in an object it then serializes to utf8 json.

It seems that STJ doesn't have a fast-path DateOnly -> UTF8 like it has for e.g. DateTime and DateTimeOffset. Instead, it does DateOnly -> UTF16 string and then converts it to Utf8.

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/DateOnlyConverter.cs

Lines 60 to 63 in 50c9dca

	Span<char> buffer = stackalloc char[FormatLength];
	bool formattedSuccessfully = value.TryFormat(buffer, out int charsWritten, "O", CultureInfo.InvariantCulture);
	Debug.Assert(formattedSuccessfully && charsWritten == FormatLength);
	writer.WriteStringValue(buffer);

Author:	EgorBo
Assignees:	-
Labels:	area-System.Text.Json, untriaged
Milestone:	-

[eiriktsarpalis]

In that case, I'm reassigning this back to STJ and scoping this to adding IUtf8SpanFormattable /IUtf8SpanParseable support in STJ's converters.

[eiriktsarpalis]

Addressed in part by #86931.

[eiriktsarpalis]

Moving to 9.0, since at this point we'll have less time to react to potential regressions.

[rynowak]

This is definitely something we'd get a lot of use out of. For context we create a lot of custom domain types that convertable to/from strings. We end up using these with JSON a lot, and so it's added friction to need to create JSON converters