Skip to content

Regressions in System.Perf_Convert and System.Net.NetworkInformation.Tests.PhysicalAddressTests #79615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
performanceautofiler bot opened this issue Dec 13, 2022 · 4 comments
Closed

Regressions in System.Perf_Convert and System.Net.NetworkInformation.Tests.PhysicalAddressTests #79615

performanceautofiler bot opened this issue Dec 13, 2022 · 4 comments
Assignees
@dakersnar
Labels
area-System.Runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 8c795cbde56c3047e8a7f73f4963ec513607f44d
Compare a30de6d40f69ef612b514344a5ec83fffd10b957
Diff Diff

Regressions in System.Perf_Convert

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ToHexString - Duration of single invocation 37.11 ns 44.17 ns 1.19 0.04 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Perf_Convert*'

Payloads

Baseline
Compare

Histogram

System.Perf_Convert.ToHexString

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 44.166831670948405 > 38.897011366171455.
IsChangePoint: Marked as a change because one of 11/20/2022 2:44:51 AM, 12/8/2022 9:11:55 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -35.1438045456186 (T) = (0 -43.44002319262316) / Math.Sqrt((0.5923721246368957 / (37)) + (0.45664082482020113 / (22))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (22) - 2, .025) and -0.18360845941418524 = (36.7013456579411 - 43.44002319262316) / 36.7013456579411 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS Windows 10.0.19042
Baseline 8c795cbde56c3047e8a7f73f4963ec513607f44d
Compare a30de6d40f69ef612b514344a5ec83fffd10b957
Diff Diff

Regressions in System.Net.NetworkInformation.Tests.PhysicalAddressTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
PALong - Duration of single invocation 98.21 ns 104.72 ns 1.07 0.04 False
PAMedium - Duration of single invocation 21.15 ns 27.27 ns 1.29 0.13 False

graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Net.NetworkInformation.Tests.PhysicalAddressTests*'

Payloads

Baseline
Compare

Histogram

System.Net.NetworkInformation.Tests.PhysicalAddressTests.PALong

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 104.71521324474814 > 103.29291836998061.
IsChangePoint: Marked as a change because one of 12/8/2022 9:11:55 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -14.779722177774573 (T) = (0 -105.35746045046994) / Math.Sqrt((5.262217608501766 / (37)) + (0.6298708340204264 / (22))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (22) - 2, .025) and -0.061553634533376415 = (99.2483629871246 - 105.35746045046994) / 99.2483629871246 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Net.NetworkInformation.Tests.PhysicalAddressTests.PAMedium

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 27.271044348323816 > 22.220144173638328.
IsChangePoint: Marked as a change because one of 12/8/2022 9:11:55 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -39.78935265987898 (T) = (0 -28.430154498229943) / Math.Sqrt((0.2036697617013127 / (37)) + (0.7009819568157848 / (22))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (22) - 2, .025) and -0.3708801707984769 = (20.73861385103458 - 28.430154498229943) / 20.73861385103458 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 8c795cbde56c3047e8a7f73f4963ec513607f44d
Compare a30de6d40f69ef612b514344a5ec83fffd10b957
Diff Diff

Regressions in System.Security.Cryptography.X509Certificates.Tests.X509Certificate2Tests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CertProp - Duration of single invocation 26.59 ns 31.90 ns 1.20 0.20 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Security.Cryptography.X509Certificates.Tests.X509Certificate2Tests*'

Payloads

Baseline
Compare

Histogram

System.Security.Cryptography.X509Certificates.Tests.X509Certificate2Tests.CertProp

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 31.896684224339406 > 25.87505966400727.
IsChangePoint: Marked as a change because one of 12/6/2022 2:12:43 AM, 12/6/2022 6:34:01 PM, 12/8/2022 9:11:55 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -9.886677800424305 (T) = (0 -31.373159500999677) / Math.Sqrt((9.088324644827408 / (37)) + (0.1803540657885104 / (22))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (22) - 2, .025) and -0.18873229061566255 = (26.392115153825795 - 31.373159500999677) / 26.392115153825795 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added CoreClr untriaged New issue has not been triaged by the area owner labels Dec 13, 2022
@cincuranet cincuranet removed the untriaged New issue has not been triaged by the area owner label Dec 13, 2022
@cincuranet cincuranet changed the title [Perf] Windows/x64: 4 Regressions on 12/8/2022 5:23:10 PM Regressions in System.Perf_Convert Dec 13, 2022
@cincuranet cincuranet transferred this issue from dotnet/perf-autofiling-issues Dec 13, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 13, 2022
@cincuranet
Copy link
Contributor

Probably caused by #78914.

cc @stephentoub

@cincuranet cincuranet added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Dec 13, 2022
@ghost
Copy link

ghost commented Dec 15, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 8c795cbde56c3047e8a7f73f4963ec513607f44d
Compare a30de6d40f69ef612b514344a5ec83fffd10b957
Diff Diff

Regressions in System.Perf_Convert

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ToHexString - Duration of single invocation 37.11 ns 44.17 ns 1.19 0.04 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Perf_Convert*'

Payloads

Baseline
Compare

Histogram

System.Perf_Convert.ToHexString

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 44.166831670948405 > 38.897011366171455.
IsChangePoint: Marked as a change because one of 11/20/2022 2:44:51 AM, 12/8/2022 9:11:55 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -35.1438045456186 (T) = (0 -43.44002319262316) / Math.Sqrt((0.5923721246368957 / (37)) + (0.45664082482020113 / (22))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (22) - 2, .025) and -0.18360845941418524 = (36.7013456579411 - 43.44002319262316) / 36.7013456579411 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS Windows 10.0.19042
Baseline 8c795cbde56c3047e8a7f73f4963ec513607f44d
Compare a30de6d40f69ef612b514344a5ec83fffd10b957
Diff Diff

Regressions in System.Net.NetworkInformation.Tests.PhysicalAddressTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
PALong - Duration of single invocation 98.21 ns 104.72 ns 1.07 0.04 False
PAMedium - Duration of single invocation 21.15 ns 27.27 ns 1.29 0.13 False

graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Net.NetworkInformation.Tests.PhysicalAddressTests*'

Payloads

Baseline
Compare

Histogram

System.Net.NetworkInformation.Tests.PhysicalAddressTests.PALong

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 104.71521324474814 > 103.29291836998061.
IsChangePoint: Marked as a change because one of 12/8/2022 9:11:55 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -14.779722177774573 (T) = (0 -105.35746045046994) / Math.Sqrt((5.262217608501766 / (37)) + (0.6298708340204264 / (22))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (22) - 2, .025) and -0.061553634533376415 = (99.2483629871246 - 105.35746045046994) / 99.2483629871246 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Net.NetworkInformation.Tests.PhysicalAddressTests.PAMedium

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 27.271044348323816 > 22.220144173638328.
IsChangePoint: Marked as a change because one of 12/8/2022 9:11:55 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -39.78935265987898 (T) = (0 -28.430154498229943) / Math.Sqrt((0.2036697617013127 / (37)) + (0.7009819568157848 / (22))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (22) - 2, .025) and -0.3708801707984769 = (20.73861385103458 - 28.430154498229943) / 20.73861385103458 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline 8c795cbde56c3047e8a7f73f4963ec513607f44d
Compare a30de6d40f69ef612b514344a5ec83fffd10b957
Diff Diff

Regressions in System.Security.Cryptography.X509Certificates.Tests.X509Certificate2Tests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CertProp - Duration of single invocation 26.59 ns 31.90 ns 1.20 0.20 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Security.Cryptography.X509Certificates.Tests.X509Certificate2Tests*'

Payloads

Baseline
Compare

Histogram

System.Security.Cryptography.X509Certificates.Tests.X509Certificate2Tests.CertProp

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 31.896684224339406 > 25.87505966400727.
IsChangePoint: Marked as a change because one of 12/6/2022 2:12:43 AM, 12/6/2022 6:34:01 PM, 12/8/2022 9:11:55 AM, 12/13/2022 2:17:54 AM falls between 12/4/2022 6:53:17 AM and 12/13/2022 2:17:54 AM.
IsRegressionStdDev: Marked as regression because -9.886677800424305 (T) = (0 -31.373159500999677) / Math.Sqrt((9.088324644827408 / (37)) + (0.1803540657885104 / (22))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (37) + (22) - 2, .025) and -0.18873229061566255 = (26.392115153825795 - 31.373159500999677) / 26.392115153825795 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: dakersnar
Labels:

area-System.Runtime, tenet-performance, tenet-performance-benchmarks, untriaged
Milestone: -

@dakersnar
Copy link
Contributor

Commit range is: 8c795cb...be0eccd

FYI our above guess of #78914 is not confident, but we saw it changed HexConverter.cs, so it seems probable.

@dakersnar dakersnar mentioned this issue Dec 15, 2022
Closed
@dakersnar dakersnar changed the title Regressions in System.Perf_Convert Regressions in System.Perf_Convert and System.Net.NetworkInformation.Tests.PhysicalAddressTests Dec 15, 2022
@dakersnar dakersnar mentioned this issue Dec 15, 2022
Closed
@tannergooding tannergooding removed the untriaged New issue has not been triaged by the area owner label Feb 24, 2023
@tannergooding
Copy link
Member

There have been several other changes to this area and the relevant test is back down to 37ns in the latest runs.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dakersnar dakersnar

Labels
area-System.Runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cincuranet @jeffschwMSFT @tannergooding @dakersnar