AddRemoveFromDifferentThreads.ConcurrentStack hangs with NativeAOT

[adamsitnik]

I am currently working on getting all dotnet/performance microbenchmarks work with NativeAOT. This particular benchmark just hangs. It's not the first time it has caused trouble for our runtime (#64980).

Environment: Windows 11 x64, AMD hardware. I have not tested it with other configs.

cc @jkotas @MichalStrehovsky

Repro:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net6.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.DotNet.ILCompiler" Version="7.0.0-*" />
  </ItemGroup>
</Project>

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="nativeAOTfeed" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json" />
  </packageSources>
</configuration>

using System;
using System.Collections.Concurrent;
using System.Threading;
using System.Threading.Tasks;

namespace aotHang
{
    class Program
    {
        static void Main(string[] args)
        {
            AddRemoveFromDifferentThreads<int> sut = new ();
            Console.WriteLine(nameof(sut.SetupConcurrentStackIteration));
            sut.SetupConcurrentStackIteration();
            Console.WriteLine(nameof(sut.ConcurrentStack));
            sut.ConcurrentStack();
            Console.WriteLine(nameof(sut.IterationCleanup));
            sut.IterationCleanup();
        }
    }

    public class AddRemoveFromDifferentThreads<T>
    {
        const int NumThreads = 2;

        public int Size = 2_000_000;

        private Barrier _barrier;
        private Task _producer, _consumer;

        public void IterationCleanup() => _barrier.Dispose();

        public void SetupConcurrentStackIteration()
        {
            var stack = new ConcurrentStack<T>();

            _barrier = new Barrier(NumThreads + 1);

            _producer = Task.Factory.StartNew(() =>
            {
                _barrier.SignalAndWait();
                _barrier.SignalAndWait();

                for (int i = 0; i < Size; i++)
                {
                    stack.Push(default);
                }
            }, CancellationToken.None, TaskCreationOptions.LongRunning, TaskScheduler.Default);

            _consumer = Task.Factory.StartNew(() =>
            {
                _barrier.SignalAndWait();
                _barrier.SignalAndWait();

                int count = 0;
                while (count < Size)
                {
                    if (stack.TryPop(out T _))
                    {
                        count++;
                    }
                }
            }, CancellationToken.None, TaskCreationOptions.LongRunning, TaskScheduler.Default);

            _barrier.SignalAndWait();
        }

        public void ConcurrentStack() => SignalAndWaitForAllTasks();

        private void SignalAndWaitForAllTasks()
        {
            _barrier.SignalAndWait();

            Task.WaitAll(_producer, _consumer);
        }
    }
}

dotnet  publish -c Release -r win-x64
.\bin\Release\net6.0\win-x64\native\aotHang.exe

[hez2010]

May be related: #67805

[danmoseley]

Note I got a hang without Native AOT. #67559

[jkotas]

I have transferred #67805 to dotnet/runtime and resolving this as duplicate.