Skip to content

[mono] Add debugger-agent command to apply hot reload update #48458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lambdageek opened this issue Feb 18, 2021 · 3 comments
Closed

[mono] Add debugger-agent command to apply hot reload update #48458

lambdageek opened this issue Feb 18, 2021 · 3 comments
Assignees
@lambdageek
Labels
area-Debugger-mono untriaged New issue has not been triaged by the area owner
Milestone
6.0.0

Comments

@lambdageek
Copy link
Member

Currently we have an ApplyUpdateSdb private method on System.Reflection.Metadata.AssemblyExtensions that can be invoked with byte[] blobs, but it has to be kept alive by the IL linker descriptor which means it won't get trimmed even if hot reload isn't used.

Instead we should just extend the soft debugger protocol to include an apply update command.

Part of #44806
@lambdageek lambdageek added this to the 6.0.0 milestone Feb 18, 2021
@lambdageek lambdageek self-assigned this Feb 18, 2021
@ghost
Copy link

ghost commented Feb 18, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently we have an ApplyUpdateSdb private method on System.Reflection.Metadata.AssemblyExtensions that can be invoked with byte[] blobs, but it has to be kept alive by the IL linker descriptor which means it won't get trimmed even if hot reload isn't used.

Instead we should just extend the soft debugger protocol to include an apply update command.

Part of #44806

Author: lambdageek
Assignees: lambdageek
Labels:

area-Debugger-mono
Milestone: 6.0.0

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 18, 2021
@lambdageek
Copy link
Member Author

Related to #48380 (comment)

@lambdageek lambdageek mentioned this issue Apr 23, 2021
Closed
51 tasks
@lambdageek
Copy link
Member Author

This was done in #49043, together with mono/mono#20889 and mono/debugger-libs#342.

@ghost ghost locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lambdageek lambdageek

Labels
area-Debugger-mono untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@lambdageek