Skip to content

Create cDAC entrypoint same as DAC CLRDataCreateInstance #112583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #110758
max-charlamb opened this issue Feb 14, 2025 · 1 comment · Fixed by #113899
Closed
Tracked by #110758

Create cDAC entrypoint same as DAC CLRDataCreateInstance #112583

max-charlamb opened this issue Feb 14, 2025 · 1 comment · Fixed by #113899
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions in-pr There is an active PR which will close this issue when it is merged
Milestone
10.0.0

Comments

@max-charlamb
Copy link
Contributor

max-charlamb commented Feb 14, 2025 •
edited
Loading

Relevant Issue: #108720

Implement CLRDataCreateInstance on cDAC as drop-in replacement for DAC.

The difficult portion of this work is looking up the contract by symbol name. This is currently done in the DAC through TryGetSymbol.
The ICLRDataTarget that is passed in does not have the ability to determine the target OS. This will be required to pick the correct implementation of TryGetSymbol to use.

  • Package the TryGetSymbol native PE reader into the cDAC.
@max-charlamb max-charlamb mentioned this issue Feb 14, 2025
Open
29 tasks
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Feb 14, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@max-charlamb max-charlamb added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Feb 14, 2025
@tommcdon tommcdon added this to the 10.0.0 milestone Feb 14, 2025
@max-charlamb max-charlamb mentioned this issue Mar 28, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Mar 28, 2025
@max-charlamb max-charlamb mentioned this issue Apr 7, 2025
Open
7 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

[cDAC] Adds DAC like entrypoint with new COM interface max-charlamb/runtime
2 participants
@tommcdon @max-charlamb