Skip to content

[Perf] Windows/x64 Regressions in System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double> #102514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
performanceautofiler bot opened this issue May 21, 2024 · 4 comments
Assignees
Labels
arch-x64 area-System.Numerics needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented May 21, 2024

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue TigerWindows
Baseline 1d622621b6bc254fbd777921c70a3f5d57fbd6b8
Compare a71a85a65f6527ca2754ccf336f1fc77f02c409b
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
1.49 μs 4.46 μs 2.99 0.70 False
5.38 μs 6.11 μs 1.13 0.32 False
76.12 ns 240.82 ns 3.16 0.54 False

graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives&lt;Double&gt;*'

System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double>.Round(BufferLength: 3079)

ETL Files

Histogram

JIT Disasms

System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double>.Sin(BufferLength: 3079)

ETL Files

Histogram

JIT Disasms

System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double>.Round(BufferLength: 128)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels May 21, 2024
@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues May 21, 2024
@ghost ghost added the area-System.Numerics label May 21, 2024
@LoopedBard3
Copy link
Member

Seems to likely be caused by: #102098 with clear regression across multiple platforms in ADX. @tannergooding
Commit range: 1d62262...29cb8a6

@LoopedBard3 LoopedBard3 changed the title [Perf] Windows/x64: 3 Regressions on 5/14/2024 3:49:12 AM [Perf] Windows/x64 Regressions in System.Numerics.Tensors.Tests.Perf_FloatingPointTensorPrimitives<Double> May 21, 2024
@LoopedBard3 LoopedBard3 added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels May 21, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

@DrewScoggins
Copy link
Member

Related: dotnet/perf-autofiling-issues#34775

@jeffhandley jeffhandley added this to the 9.0.0 milestone Jul 20, 2024
@jeffhandley jeffhandley added needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration and removed untriaged New issue has not been triaged by the area owner labels Jul 20, 2024
@tannergooding
Copy link
Member

This was fixing a determinism bug. In all cases we went back to the numbers that were present before the bug was introduced.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-System.Numerics needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

4 participants