Skip to content

Commit faf91e0

Browse files
authored
Address outstanding issues with System.Net MatchingRefApiCompatBaselines (#43230)
1 parent fd84485 commit faf91e0

File tree

6 files changed

+11
-16
lines changed

6 files changed

+11
-16
lines changed

src/libraries/Common/src/System/Net/Sockets/ProtocolFamily.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33

44
#if SYSTEM_NET_SOCKETS_DLL
55
namespace System.Net.Sockets
6+
{
7+
public
68
#else
79
using System.Net.Sockets;
810
namespace System.Net.Internals
9-
#endif
1011
{
11-
public enum ProtocolFamily
12+
internal
13+
#endif
14+
enum ProtocolFamily
1215
{
1316
Unknown = AddressFamily.Unknown,
1417
Unspecified = AddressFamily.Unspecified,

src/libraries/Common/src/System/Net/Sockets/ProtocolType.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33

44
#if SYSTEM_NET_SOCKETS_DLL
55
namespace System.Net.Sockets
6+
{
7+
public
68
#else
79
namespace System.Net.Internals
8-
#endif
910
{
11+
internal
12+
#endif
1013
// Specifies the protocols that the Socket class supports.
11-
public enum ProtocolType
14+
enum ProtocolType
1215
{
1316
IP = 0, // dummy for IP
1417

src/libraries/System.Net.NameResolution/src/MatchingRefApiCompatBaseline.txt

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/libraries/System.Net.Primitives/src/MatchingRefApiCompatBaseline.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# Public in the implementation to maintain binary serialization compatibility as the System shim needs to have access to type-forward to these
12
Compat issues with assembly System.Net.Primitives:
23
TypesMustExist : Type 'System.Net.CookieVariant' does not exist in the reference but it does exist in the implementation.
34
TypesMustExist : Type 'System.Net.PathList' does not exist in the reference but it does exist in the implementation.

src/libraries/System.Net.Requests/src/MatchingRefApiCompatBaseline.txt

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -160,11 +160,6 @@ public bool AreParametersAcceptableForCaching()
160160
private const string ContinueHeader = "100-continue";
161161
private const string ChunkedHeader = "chunked";
162162

163-
[Obsolete(Obsoletions.WebRequestMessage, DiagnosticId = Obsoletions.WebRequestDiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
164-
public HttpWebRequest()
165-
{
166-
}
167-
168163
[Obsolete(Obsoletions.WebRequestMessage, DiagnosticId = Obsoletions.WebRequestDiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
169164
protected HttpWebRequest(SerializationInfo serializationInfo, StreamingContext streamingContext) : base(serializationInfo, streamingContext)
170165
{

0 commit comments

Comments
 (0)