Skip to content

Commit d7c96e8

Browse files
authored
[mono][workload] Work around a msbuild bug in MatchOnMetadata (#60989)
* Work around a msbuild bug in MatchOnMetadata * Reenable workload build tests and bump to a 7.0.100 sdk version
1 parent f06399b commit d7c96e8

File tree

4 files changed

+42
-41
lines changed

4 files changed

+42
-41
lines changed

eng/Versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@
164164
<SQLitePCLRawbundle_greenVersion>2.0.4</SQLitePCLRawbundle_greenVersion>
165165
<MoqVersion>4.12.0</MoqVersion>
166166
<FsCheckVersion>2.14.3</FsCheckVersion>
167-
<SdkVersionForWorkloadTesting>6.0.100-rc.2.21474.31</SdkVersionForWorkloadTesting>
167+
<SdkVersionForWorkloadTesting>7.0.100-alpha.1.21528.1</SdkVersionForWorkloadTesting>
168168
<CompilerPlatformTestingVersion>1.1.1-beta1.21467.5</CompilerPlatformTestingVersion>
169169
<!-- Docs -->
170170
<MicrosoftPrivateIntellisenseVersion>6.0.0-preview-20211019.1</MicrosoftPrivateIntellisenseVersion>

eng/pipelines/runtime.yml

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -317,42 +317,42 @@ jobs:
317317
#
318318
# Build the whole product using Mono and run libraries tests, for Wasm.Build.Tests
319319
#
320-
# - template: /eng/pipelines/common/platform-matrix.yml
321-
# parameters:
322-
# jobTemplate: /eng/pipelines/common/global-build-job.yml
323-
# helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml
324-
# buildConfig: Release
325-
# runtimeFlavor: mono
326-
# platforms:
327-
# - Browser_wasm
328-
# variables:
329-
# # map dependencies variables to local variables
330-
# - name: monoContainsChange
331-
# value: $[ dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'] ]
332-
# - name: installerContainsChange
333-
# value: $[ dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'] ]
334-
# jobParameters:
335-
# testGroup: innerloop
336-
# nameSuffix: AllSubsets_Mono_WasmBuildTests
337-
# buildArgs: -s mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:TestWasmBuildTests=true /p:TestAssemblies=false
338-
# timeoutInMinutes: 180
339-
# condition: >-
340-
# or(
341-
# eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true),
342-
# eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
343-
# eq(variables['isFullMatrix'], true))
344-
# # extra steps, run tests
345-
# extraStepsTemplate: /eng/pipelines/libraries/helix.yml
346-
# extraStepsParameters:
347-
# creator: dotnet-bot
348-
# testRunNamePrefixSuffix: Mono_$(_BuildConfig)
349-
# scenarios:
350-
# - buildwasmapps
351-
# condition: >-
352-
# or(
353-
# eq(variables['monoContainsChange'], true),
354-
# eq(variables['installerContainsChange'], true),
355-
# eq(variables['isFullMatrix'], true))
320+
- template: /eng/pipelines/common/platform-matrix.yml
321+
parameters:
322+
jobTemplate: /eng/pipelines/common/global-build-job.yml
323+
helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml
324+
buildConfig: Release
325+
runtimeFlavor: mono
326+
platforms:
327+
- Browser_wasm
328+
variables:
329+
# map dependencies variables to local variables
330+
- name: monoContainsChange
331+
value: $[ dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'] ]
332+
- name: installerContainsChange
333+
value: $[ dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'] ]
334+
jobParameters:
335+
testGroup: innerloop
336+
nameSuffix: AllSubsets_Mono_WasmBuildTests
337+
buildArgs: -s mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:TestWasmBuildTests=true /p:TestAssemblies=false
338+
timeoutInMinutes: 180
339+
condition: >-
340+
or(
341+
eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true),
342+
eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
343+
eq(variables['isFullMatrix'], true))
344+
# extra steps, run tests
345+
extraStepsTemplate: /eng/pipelines/libraries/helix.yml
346+
extraStepsParameters:
347+
creator: dotnet-bot
348+
testRunNamePrefixSuffix: Mono_$(_BuildConfig)
349+
scenarios:
350+
- buildwasmapps
351+
condition: >-
352+
or(
353+
eq(variables['monoContainsChange'], true),
354+
eq(variables['installerContainsChange'], true),
355+
eq(variables['isFullMatrix'], true))
356356
357357
#
358358
# Build for Browser/wasm, with EnableAggressiveTrimming=true

eng/testing/workloads-testing.targets

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@
9090

9191
<ItemGroup>
9292
<_NuGetSourceForWorkloads Include="dotnet6" Value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json" />
93+
<_NuGetSourceForWorkloads Include="dotnet7" Value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json" />
94+
9395
<_BuiltNuGets Include="$(LibrariesShippingPackagesDir)\*.nupkg" />
9496
</ItemGroup>
9597

src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/WorkloadManifest.targets.in

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@
9090
<_MonoWorkloadRuntimePackPackageVersion>$(RuntimePackInWorkloadVersion)</_MonoWorkloadRuntimePackPackageVersion>
9191
</PropertyGroup>
9292

93-
<ItemGroup Condition="'$(_MonoWorkloadTargetsMobile)' == 'true'">
93+
<ItemGroup Condition="'$(_MonoWorkloadTargetsMobile)' == 'true' and '$(TargetFramework)' == '${NetCoreAppCurrent}'">
9494
<MonoRuntimePackRids Include="
9595
linux-x64;
9696
win-x64;
@@ -113,12 +113,11 @@
113113
android-x86;
114114
" />
115115

116-
<_PackUpdates Include="Microsoft.NETCore.App" TargetFramework="${NetCoreAppCurrent}" RuntimeFrameworkName="Microsoft.NETCore.App" />
117-
<KnownRuntimePack Remove="@(_PackUpdates)" MatchOnMetadata="TargetFramework;RuntimeFrameworkName"/>
116+
<KnownRuntimePack Remove="Microsoft.NETCore.App" />
118117
<KnownRuntimePack Include="Microsoft.NETCore.App"
119118
TargetFramework="${NetCoreAppCurrent}"
120119
RuntimeFrameworkName="Microsoft.NETCore.App"
121-
LatestRuntimeFrameworkVersion="$(_MonoWorkloadRuntimePackPackageVersion)"
120+
LatestRuntimeFrameworkVersion="**FromWorkload**"
122121
RuntimePackNamePatterns="Microsoft.NETCore.App.Runtime.Mono.**RID**"
123122
RuntimePackRuntimeIdentifiers="@(MonoRuntimePackRids, '%3B')"
124123
RuntimePackLabels="Mono"

0 commit comments

Comments
 (0)