src: Fix bugs found with the tests that check if async APIs are not calling sync APIs and viceversa.

Author: carlossanlop

src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchive.Async.cs

@@ -103,15 +103,18 @@ public static async Task<ZipArchive> CreateAsync(Stream stream, ZipArchiveMode m
                     {
                         await zipArchive.ReadEndOfCentralDirectoryAsync(cancellationToken).ConfigureAwait(false);
                         await zipArchive.EnsureCentralDirectoryReadAsync(cancellationToken).ConfigureAwait(false);
-                        zipArchive.CheckIfEntriesAreOpenable();
+
+                        foreach (ZipArchiveEntry entry in zipArchive._entries)
+                        {
+                            await entry.ThrowIfNotOpenableAsync(needToUncompress: false, needToLoadIntoMemory: true, cancellationToken).ConfigureAwait(false);
+                        }
                     }
                     break;
             }
 
             return zipArchive;
-
         }
-        catch
+        catch (Exception)
         {
             if (extraTempStream != null)
             {

src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchive.cs

@@ -158,12 +158,16 @@ public ZipArchive(Stream stream, ZipArchiveMode mode, bool leaveOpen, Encoding?
                         {
                             ReadEndOfCentralDirectory();
                             EnsureCentralDirectoryRead();
-                            CheckIfEntriesAreOpenable();
+
+                            foreach (ZipArchiveEntry entry in _entries)
+                            {
+                                entry.ThrowIfNotOpenable(needToUncompress: false, needToLoadIntoMemory: true);
+                            }
                         }
                         break;
                 }
             }
-            catch
+            catch (Exception)
             {
                 extraTempStream?.Dispose();
 
@@ -920,14 +924,6 @@ private static Stream DecideArchiveStream(ZipArchiveMode mode, Stream stream)
                 stream;
         }
 
-        private void CheckIfEntriesAreOpenable()
-        {
-            foreach (ZipArchiveEntry entry in _entries)
-            {
-                entry.ThrowIfNotOpenable(needToUncompress: false, needToLoadIntoMemory: true);
-            }
-        }
-
 
         [Flags]
         internal enum ChangeState

src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchiveEntry.Async.cs

@@ -148,7 +148,7 @@ internal async Task LoadLocalHeaderExtraFieldIfNeededAsync(CancellationToken can
     {
         cancellationToken.ThrowIfCancellationRequested();
         // we should have made this exact call in _archive.Init through ThrowIfOpenable
-        Debug.Assert(IsOpenable(false, true, out _));
+        Debug.Assert(await GetIsOpenableAsync(false, true, cancellationToken).ConfigureAwait(false));
 
         // load local header's extra fields. it will be null if we couldn't read for some reason
         if (_originallyInArchive)
@@ -162,7 +162,7 @@ internal async Task LoadCompressedBytesIfNeededAsync(CancellationToken cancellat
     {
         cancellationToken.ThrowIfCancellationRequested();
         // we should have made this exact call in _archive.Init through ThrowIfOpenable
-        Debug.Assert(IsOpenable(false, true, out _));
+        Debug.Assert(await GetIsOpenableAsync(false, true, cancellationToken).ConfigureAwait(false));
 
         if (!_everOpenedForWrite && _originallyInArchive)
         {
@@ -178,6 +178,13 @@ internal async Task LoadCompressedBytesIfNeededAsync(CancellationToken cancellat
         }
     }
 
+    private async Task<bool> GetIsOpenableAsync(bool needToUncompress, bool needToLoadIntoMemory, CancellationToken cancellationToken)
+    {
+        cancellationToken.ThrowIfCancellationRequested();
+        (bool result, _) = await IsOpenableAsync(needToUncompress, needToLoadIntoMemory, cancellationToken).ConfigureAwait(false);
+        return result;
+    }
+
     internal async Task ThrowIfNotOpenableAsync(bool needToUncompress, bool needToLoadIntoMemory, CancellationToken cancellationToken)
     {
         cancellationToken.ThrowIfCancellationRequested();
@@ -288,9 +295,8 @@ private async Task WriteLocalFileHeaderAndDataIfNeededAsync(bool forceWrite, Can
 
                 //The compressor fills in CRC and sizes
                 //The DirectToArchiveWriterStream writes headers and such
-                using (Stream entryWriter = new DirectToArchiveWriterStream(
-                                                GetDataCompressor(_archive.ArchiveStream, true, null),
-                                                this))
+                DirectToArchiveWriterStream entryWriter = new(GetDataCompressor(_archive.ArchiveStream, true, null), this);
+                await using (entryWriter)
                 {
                     _storedUncompressedData.Seek(0, SeekOrigin.Begin);
                     await _storedUncompressedData.CopyToAsync(entryWriter, cancellationToken).ConfigureAwait(false);

src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchiveEntry.cs

@@ -1104,7 +1104,7 @@ private void WriteLocalFileHeaderAndDataIfNeeded(bool forceWrite)
 
                     //The compressor fills in CRC and sizes
                     //The DirectToArchiveWriterStream writes headers and such
-                    using (Stream entryWriter = new DirectToArchiveWriterStream(
+                    using (DirectToArchiveWriterStream entryWriter = new(
                                                     GetDataCompressor(_archive.ArchiveStream, true, null),
                                                     this))
                     {