[cdac] Remove GetMethodDescData fallback to legacy DAC (#110702)

- Make cDAC `GetMethodDescData` implementation stop delegating to the legacy DAC as a fallback.
- Debug.Assert cDAC/DAC hresults on failure

Author: elinor-fung

src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs

@@ -267,7 +267,7 @@ public TypeHandle GetTypeHandle(TargetPointer typeHandlePointer)
 
         if ((addressLowBits != TypeHandleBits.MethodTable) && (addressLowBits != TypeHandleBits.TypeDesc))
         {
-            throw new InvalidOperationException("Invalid type handle pointer");
+            throw new ArgumentException("Invalid type handle pointer", nameof(typeHandlePointer));
         }
 
         // if we already validated this address, return a handle
@@ -306,7 +306,7 @@ public TypeHandle GetTypeHandle(TargetPointer typeHandlePointer)
         // Otherwse, get ready to validate
         if (!_typeValidation.TryValidateMethodTablePointer(methodTablePointer))
         {
-            throw new InvalidOperationException("Invalid method table pointer");
+            throw new ArgumentException("Invalid method table pointer", nameof(typeHandlePointer));
         }
         // ok, we validated it, cache the data and add the MethodTable_1 struct to the dictionary
         Data.MethodTable trustedMethodTableData = _target.ProcessedData.GetOrAdd<Data.MethodTable>(methodTablePointer);
@@ -636,7 +636,7 @@ public MethodDescHandle GetMethodDescHandle(TargetPointer methodDescPointer)
 
         if (!_methodValidation.ValidateMethodDescPointer(methodDescPointer, out TargetPointer methodDescChunkPointer))
         {
-            throw new InvalidOperationException("Invalid method desc pointer");
+            throw new ArgumentException("Invalid method desc pointer", nameof(methodDescPointer));
         }
 
         // ok, we validated it, cache the data and add the MethodDesc struct to the dictionary