Skip to content

Commit c59fc16

Browse files
committed
Add link to CoreLib bin-placing issue and update RuntimeConfiguration in comment
1 parent 0d7d354 commit c59fc16

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/libraries/illink-sharedframework.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@
3030
<ILLinkArgs>$(ILLinkArgs) --nowarn $(LinkerNoWarn)</ILLinkArgs>
3131
</PropertyGroup>
3232

33-
<!-- Retrieve CoreLib's path as it isn't binplaced alongside the libraries. -->
33+
<!-- Retrieve CoreLib's path as it isn't binplaced alongside the libraries - https://github.com/dotnet/runtime/issues/43095. -->
3434
<ItemGroup>
3535
<CoreLibProjectWithRuntimeConfig Include="$(CoreLibProject)">
3636
<!-- Don't flow TargetFramework and Platform to use same inputs and outputs as the CoreLib's build as part of the runtime. -->
3737
<UndefineProperties>$(UndefineProperties);TargetFramework;Platform</UndefineProperties>
38-
<!-- If conflicting, manually set the Configuration property of the CoreLib project so that it aligns with the specified RuntimeConfiguration in the libraries' build. -->
38+
<!-- If conflicting, manually set the Configuration property of the CoreLib project so that it aligns with the specified runtime configuration in the libraries' build. -->
3939
<Properties Condition="'$(RuntimeFlavor)' == 'CoreCLR' and
4040
'$(Configuration)' != '$(CoreCLRConfiguration)'">Configuration=$(CoreCLRConfiguration)</Properties>
4141
<Properties Condition="'$(RuntimeFlavor)' == 'Mono' and

0 commit comments

Comments
 (0)