Move macro definition to give better out-of-the-box VSCode experience on Windows (#113557)

Author: jkoritzinsky

src/coreclr/inc/debugmacros.h

@@ -13,6 +13,7 @@
 #include "stacktrace.h"
 #include "debugmacrosext.h"
 #include "palclr.h"
+#include <minipal/utils.h>
 
 #undef _ASSERTE
 #undef VERIFY

src/coreclr/inc/palclr.h

@@ -48,8 +48,6 @@
 #endif // !_MSC_VER
 #endif // !NOINLINE
 
-#define ANALYZER_NORETURN
-
 #ifdef _MSC_VER
 #define EMPTY_BASES_DECL __declspec(empty_bases)
 #else

src/coreclr/pal/inc/pal.h

@@ -132,12 +132,6 @@ extern bool g_arm64_atomics_present;
 
 #define DECLSPEC_NORETURN   PAL_NORETURN
 
-#ifdef __clang_analyzer__
-#define ANALYZER_NORETURN __attribute((analyzer_noreturn))
-#else
-#define ANALYZER_NORETURN
-#endif
-
 #define EMPTY_BASES_DECL
 
 #if !defined(_MSC_VER) || defined(SOURCE_FORMATTING)
@@ -1552,7 +1546,7 @@ typedef struct DECLSPEC_ALIGN(16) _CONTEXT {
         M512 Zmm30;
         M512 Zmm31;
     };
-    
+
     struct
     {
         DWORD64 Egpr16;
@@ -1572,7 +1566,7 @@ typedef struct DECLSPEC_ALIGN(16) _CONTEXT {
         DWORD64 Egpr30;
         DWORD64 Egpr31;
     };
-    
+
 } CONTEXT, *PCONTEXT, *LPCONTEXT;
 
 //

src/native/minipal/utils.h

@@ -9,6 +9,12 @@
 // Number of characters in a string literal. Excludes terminating NULL.
 #define STRING_LENGTH(str) (ARRAY_SIZE(str) - 1)
 
+#ifdef __clang_analyzer__
+#define ANALYZER_NORETURN __attribute((analyzer_noreturn))
+#else
+#define ANALYZER_NORETURN
+#endif
+
 #ifndef __has_builtin
 #define __has_builtin(x) 0
 #endif