Skip to content

Commit a4337b7

Browse files
Remove IlcKeepManagedDebuggerSupport (#101369)
This was introduced in #82696, but on a second thought, we should be able to use the documented `DebuggerSupport` for this. We still don't want to full on default this to `false` for reasons described in the PR, but the explicit value of `true` can be the escape hatch.
1 parent 6578e69 commit a4337b7

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ The .NET Foundation licenses this file to you under the MIT license.
289289
<IlcArg Condition="$(IlcDisableReflection) == 'true'" Include="--feature:System.Reflection.IsReflectionExecutionAvailable=false" />
290290

291291
<!-- The managed debugging support in libraries is unused - trim it -->
292-
<IlcArg Condition="'$(IlcKeepManagedDebuggerSupport)' != 'true'" Include="--feature:System.Diagnostics.Debugger.IsSupported=false" />
292+
<IlcArg Condition="'$(DebuggerSupport)' != 'true'" Include="--feature:System.Diagnostics.Debugger.IsSupported=false" />
293293
<IlcArg Condition="'$(UseWindowsThreadPool)' != '' and '$(_targetOS)' == 'win'" Include="--feature:System.Threading.ThreadPool.UseWindowsThreadPool=$(UseWindowsThreadPool)" />
294294
</ItemGroup>
295295

src/libraries/System.Runtime/tests/System.Runtime.Tests/System.Runtime.Tests.csproj

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@
1212
<!-- some tests require full ICU data, force it -->
1313
<WasmIncludeFullIcuData>true</WasmIncludeFullIcuData>
1414

15-
<!-- The test is looking for debugger attributes we would have stripped with NativeAOT -->
16-
<IlcKeepManagedDebuggerSupport>true</IlcKeepManagedDebuggerSupport>
17-
<!-- Same for ILLink -->
15+
<!-- The test is looking for debugger attributes we would have stripped -->
1816
<DebuggerSupport>true</DebuggerSupport>
1917
<!-- Active issue: https://github.com/dotnet/runtime/issues/97809 -->
2018
<ShouldILStrip>false</ShouldILStrip>

0 commit comments

Comments
 (0)