Unsigned check of index inside ElementAt (#91522)

YohDeadfall · web-flow · commit 9eb026696ab3 · 2023-09-04T10:28:57.000+01:00
diff --git a/src/libraries/System.Linq/src/System/Linq/ElementAt.cs b/src/libraries/System.Linq/src/System/Linq/ElementAt.cs
@@ -87,12 +87,11 @@ public static TSource ElementAt<TSource>(this IEnumerable<TSource> source, Index
 
             if (source is IList<TSource> list)
             {
-                return index >= 0 && index < list.Count ? list[index] : default;
+                return (uint)index < (uint)list.Count ? list[index] : default;
             }
 
             TryGetElement(source, index, out TSource? element);
             return element;
-
         }
 
         /// <summary>Returns the element at a specified index in a sequence or a default value if the index is out of range.</summary>

Original file line number	Diff line number	Diff line change
`@@ -87,12 +87,11 @@ public static TSource ElementAt<TSource>(this IEnumerable<TSource> source, Index`
`87`	`87`
`88`	`88`	`if (source is IList<TSource> list)`
`89`	`89`	`{`
`90`		`- return index >= 0 && index < list.Count ? list[index] : default;`
	`90`	`+ return (uint)index < (uint)list.Count ? list[index] : default;`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`TryGetElement(source, index, out TSource? element);`
`94`	`94`	`return element;`
`95`		`-`
`96`	`95`	`}`
`97`	`96`
`98`	`97`	`/// <summary>Returns the element at a specified index in a sequence or a default value if the index is out of range.</summary>`