disable test parallelization for http3 (#56413)

wfurt · web-flow · commit 9a657ceff445 · 2021-07-30T10:12:33.000-04:00
diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
@@ -3143,20 +3143,23 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2(ITestOutputH
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandlerTest_Http3_MsQuic : HttpClientHandlerTest_Http3
     {
         public SocketsHttpHandlerTest_Http3_MsQuic(ITestOutputHelper output) : base(output) { }
         protected override QuicImplementationProvider UseQuicImplementationProvider => QuicImplementationProviders.MsQuic;
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandlerTest_Http3_Mock : HttpClientHandlerTest_Http3
     {
         public SocketsHttpHandlerTest_Http3_Mock(ITestOutputHelper output) : base(output) { }
         protected override QuicImplementationProvider UseQuicImplementationProvider => QuicImplementationProviders.Mock;
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_MsQuic : HttpClientHandlerTest
     {
         public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_MsQuic(ITestOutputHelper output) : base(output) { }
@@ -3165,6 +3168,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_MsQuic(ITestOutputHelp
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_Mock : HttpClientHandlerTest
     {
         public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_Mock(ITestOutputHelper output) : base(output) { }
@@ -3174,6 +3178,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_Mock(ITestOutputHelper
 
     [ActiveIssue("https://github.com/dotnet/runtime/issues/53093")]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandlerTest_Cookies_Http3_MsQuic : HttpClientHandlerTest_Cookies
     {
         public SocketsHttpHandlerTest_Cookies_Http3_MsQuic(ITestOutputHelper output) : base(output) { }
@@ -3183,6 +3188,7 @@ public SocketsHttpHandlerTest_Cookies_Http3_MsQuic(ITestOutputHelper output) : b
 
     [ActiveIssue("https://github.com/dotnet/runtime/issues/53093")]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandlerTest_Cookies_Http3_Mock : HttpClientHandlerTest_Cookies
     {
         public SocketsHttpHandlerTest_Cookies_Http3_Mock(ITestOutputHelper output) : base(output) { }
@@ -3191,6 +3197,7 @@ public SocketsHttpHandlerTest_Cookies_Http3_Mock(ITestOutputHelper output) : bas
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_MsQuic : HttpClientHandlerTest_Headers
     {
         public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_MsQuic(ITestOutputHelper output) : base(output) { }
@@ -3199,6 +3206,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_MsQuic(ITestOu
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_Mock : HttpClientHandlerTest_Headers
     {
         public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_Mock(ITestOutputHelper output) : base(output) { }
@@ -3207,6 +3215,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_Mock(ITestOutp
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_MsQuic : SocketsHttpHandler_Cancellation_Test
     {
         public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_MsQuic(ITestOutputHelper output) : base(output) { }
@@ -3215,6 +3224,7 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_MsQuic(ITest
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_Mock : SocketsHttpHandler_Cancellation_Test
     {
         public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_Mock(ITestOutputHelper output) : base(output) { }
@@ -3223,6 +3233,7 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_Mock(ITestOu
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_MsQuic : HttpClientHandler_AltSvc_Test
     {
         public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_MsQuic(ITestOutputHelper output) : base(output) { }
@@ -3231,6 +3242,7 @@ public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_MsQuic(ITestOutput
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_Mock : HttpClientHandler_AltSvc_Test
     {
         public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_Mock(ITestOutputHelper output) : base(output) { }
@@ -3239,6 +3251,7 @@ public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_Mock(ITestOutputHe
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic : HttpClientHandler_Finalization_Test
     {
         public SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic(ITestOutputHelper output) : base(output) { }
@@ -3247,13 +3260,18 @@ public SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic(ITestOutpu
     }
 
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]
+    [Collection("NoParallelTests")]
     public sealed class SocketsHttpHandler_HttpClientHandler_Finalization_Http3_Mock : HttpClientHandler_Finalization_Test
     {
         public SocketsHttpHandler_HttpClientHandler_Finalization_Http3_Mock(ITestOutputHelper output) : base(output) { }
         protected override Version UseVersion => HttpVersion.Version30;
         protected override QuicImplementationProvider UseQuicImplementationProvider => QuicImplementationProviders.Mock;
     }
 
+    // Define test collection for tests to avoid all other tests.
+    [CollectionDefinition("NoParallelTests", DisableParallelization = true)]
+    public partial class NoParallelTests { }
+
     [ConditionalClass(typeof(PlatformDetection), nameof(PlatformDetection.IsNotBrowser))]
     public abstract class SocketsHttpHandler_RequestValidationTest
     {

Original file line number	Diff line number	Diff line change
`@@ -3143,20 +3143,23 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2(ITestOutputH`
`3143`	`3143`	`}`
`3144`	`3144`
`3145`	`3145`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]`
	`3146`	`+ [Collection("NoParallelTests")]`
`3146`	`3147`	`public sealed class SocketsHttpHandlerTest_Http3_MsQuic : HttpClientHandlerTest_Http3`
`3147`	`3148`	`{`
`3148`	`3149`	`public SocketsHttpHandlerTest_Http3_MsQuic(ITestOutputHelper output) : base(output) { }`
`3149`	`3150`	`protected override QuicImplementationProvider UseQuicImplementationProvider => QuicImplementationProviders.MsQuic;`
`3150`	`3151`	`}`
`3151`	`3152`
`3152`	`3153`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]`
	`3154`	`+ [Collection("NoParallelTests")]`
`3153`	`3155`	`public sealed class SocketsHttpHandlerTest_Http3_Mock : HttpClientHandlerTest_Http3`
`3154`	`3156`	`{`
`3155`	`3157`	`public SocketsHttpHandlerTest_Http3_Mock(ITestOutputHelper output) : base(output) { }`
`3156`	`3158`	`protected override QuicImplementationProvider UseQuicImplementationProvider => QuicImplementationProviders.Mock;`
`3157`	`3159`	`}`
`3158`	`3160`
`3159`	`3161`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]`
	`3162`	`+ [Collection("NoParallelTests")]`
`3160`	`3163`	`public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_MsQuic : HttpClientHandlerTest`
`3161`	`3164`	`{`
`3162`	`3165`	`public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_MsQuic(ITestOutputHelper output) : base(output) { }`
`@@ -3165,6 +3168,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_MsQuic(ITestOutputHelp`
`3165`	`3168`	`}`
`3166`	`3169`
`3167`	`3170`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]`
	`3171`	`+ [Collection("NoParallelTests")]`
`3168`	`3172`	`public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_Mock : HttpClientHandlerTest`
`3169`	`3173`	`{`
`3170`	`3174`	`public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_Mock(ITestOutputHelper output) : base(output) { }`
`@@ -3174,6 +3178,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_Mock(ITestOutputHelper`
`3174`	`3178`
`3175`	`3179`	`[ActiveIssue("https://github.com/dotnet/runtime/issues/53093")]`
`3176`	`3180`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]`
	`3181`	`+ [Collection("NoParallelTests")]`
`3177`	`3182`	`public sealed class SocketsHttpHandlerTest_Cookies_Http3_MsQuic : HttpClientHandlerTest_Cookies`
`3178`	`3183`	`{`
`3179`	`3184`	`public SocketsHttpHandlerTest_Cookies_Http3_MsQuic(ITestOutputHelper output) : base(output) { }`
`@@ -3183,6 +3188,7 @@ public SocketsHttpHandlerTest_Cookies_Http3_MsQuic(ITestOutputHelper output) : b`
`3183`	`3188`
`3184`	`3189`	`[ActiveIssue("https://github.com/dotnet/runtime/issues/53093")]`
`3185`	`3190`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]`
	`3191`	`+ [Collection("NoParallelTests")]`
`3186`	`3192`	`public sealed class SocketsHttpHandlerTest_Cookies_Http3_Mock : HttpClientHandlerTest_Cookies`
`3187`	`3193`	`{`
`3188`	`3194`	`public SocketsHttpHandlerTest_Cookies_Http3_Mock(ITestOutputHelper output) : base(output) { }`
`@@ -3191,6 +3197,7 @@ public SocketsHttpHandlerTest_Cookies_Http3_Mock(ITestOutputHelper output) : bas`
`3191`	`3197`	`}`
`3192`	`3198`
`3193`	`3199`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]`
	`3200`	`+ [Collection("NoParallelTests")]`
`3194`	`3201`	`public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_MsQuic : HttpClientHandlerTest_Headers`
`3195`	`3202`	`{`
`3196`	`3203`	`public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_MsQuic(ITestOutputHelper output) : base(output) { }`
`@@ -3199,6 +3206,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_MsQuic(ITestOu`
`3199`	`3206`	`}`
`3200`	`3207`
`3201`	`3208`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]`
	`3209`	`+ [Collection("NoParallelTests")]`
`3202`	`3210`	`public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_Mock : HttpClientHandlerTest_Headers`
`3203`	`3211`	`{`
`3204`	`3212`	`public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_Mock(ITestOutputHelper output) : base(output) { }`
`@@ -3207,6 +3215,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_Mock(ITestOutp`
`3207`	`3215`	`}`
`3208`	`3216`
`3209`	`3217`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]`
	`3218`	`+ [Collection("NoParallelTests")]`
`3210`	`3219`	`public sealed class SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_MsQuic : SocketsHttpHandler_Cancellation_Test`
`3211`	`3220`	`{`
`3212`	`3221`	`public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_MsQuic(ITestOutputHelper output) : base(output) { }`
`@@ -3215,6 +3224,7 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_MsQuic(ITest`
`3215`	`3224`	`}`
`3216`	`3225`
`3217`	`3226`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]`
	`3227`	`+ [Collection("NoParallelTests")]`
`3218`	`3228`	`public sealed class SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_Mock : SocketsHttpHandler_Cancellation_Test`
`3219`	`3229`	`{`
`3220`	`3230`	`public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_Mock(ITestOutputHelper output) : base(output) { }`
`@@ -3223,6 +3233,7 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_Mock(ITestOu`
`3223`	`3233`	`}`
`3224`	`3234`
`3225`	`3235`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]`
	`3236`	`+ [Collection("NoParallelTests")]`
`3226`	`3237`	`public sealed class SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_MsQuic : HttpClientHandler_AltSvc_Test`
`3227`	`3238`	`{`
`3228`	`3239`	`public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_MsQuic(ITestOutputHelper output) : base(output) { }`
`@@ -3231,6 +3242,7 @@ public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_MsQuic(ITestOutput`
`3231`	`3242`	`}`
`3232`	`3243`
`3233`	`3244`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]`
	`3245`	`+ [Collection("NoParallelTests")]`
`3234`	`3246`	`public sealed class SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_Mock : HttpClientHandler_AltSvc_Test`
`3235`	`3247`	`{`
`3236`	`3248`	`public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_Mock(ITestOutputHelper output) : base(output) { }`
`@@ -3239,6 +3251,7 @@ public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_Mock(ITestOutputHe`
`3239`	`3251`	`}`
`3240`	`3252`
`3241`	`3253`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))]`
	`3254`	`+ [Collection("NoParallelTests")]`
`3242`	`3255`	`public sealed class SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic : HttpClientHandler_Finalization_Test`
`3243`	`3256`	`{`
`3244`	`3257`	`public SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic(ITestOutputHelper output) : base(output) { }`
`@@ -3247,13 +3260,18 @@ public SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic(ITestOutpu`
`3247`	`3260`	`}`
`3248`	`3261`
`3249`	`3262`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))]`
	`3263`	`+ [Collection("NoParallelTests")]`
`3250`	`3264`	`public sealed class SocketsHttpHandler_HttpClientHandler_Finalization_Http3_Mock : HttpClientHandler_Finalization_Test`
`3251`	`3265`	`{`
`3252`	`3266`	`public SocketsHttpHandler_HttpClientHandler_Finalization_Http3_Mock(ITestOutputHelper output) : base(output) { }`
`3253`	`3267`	`protected override Version UseVersion => HttpVersion.Version30;`
`3254`	`3268`	`protected override QuicImplementationProvider UseQuicImplementationProvider => QuicImplementationProviders.Mock;`
`3255`	`3269`	`}`
`3256`	`3270`
	`3271`	`+ // Define test collection for tests to avoid all other tests.`
	`3272`	`+ [CollectionDefinition("NoParallelTests", DisableParallelization = true)]`
	`3273`	`+ public partial class NoParallelTests { }`
	`3274`	`+`
`3257`	`3275`	`[ConditionalClass(typeof(PlatformDetection), nameof(PlatformDetection.IsNotBrowser))]`
`3258`	`3276`	`public abstract class SocketsHttpHandler_RequestValidationTest`
`3259`	`3277`	`{`