Skip to content

Commit 954ca9c

Browse files
safernakoeplinger
andauthored
Fix signing in official build with 3rd party libraries (#41346)
* Fix signing in official build with 3rd party libraries * Update eng/Signing.props Co-authored-by: Alexander Köplinger <[email protected]>
1 parent bad8645 commit 954ca9c

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

eng/Signing.props

+7-8
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,13 @@
2828

2929
<!-- apphost and comhost template files are not signed, by design. -->
3030
<FileSignInfo Include="apphost.exe;singlefilehost.exe;comhost.dll" CertificateName="None" />
31+
32+
<!-- Third-party components which should be signed. -->
33+
<FileSignInfo Include="Newtonsoft.Json.dll" CertificateName="3PartySHA2" />
34+
<FileSignInfo Include="Mono.Cecil.dll" CertificateName="3PartySHA2" />
35+
<FileSignInfo Include="Mono.Cecil.Mdb.dll" CertificateName="3PartySHA2" />
36+
<FileSignInfo Include="Mono.Cecil.Pdb.dll" CertificateName="3PartySHA2" />
37+
<FileSignInfo Include="Mono.Cecil.Rocks.dll" CertificateName="3PartySHA2" />
3138
</ItemGroup>
3239

3340
<ItemGroup Condition="'$(CrossTargetComponentFolder)' != ''">
@@ -108,14 +115,6 @@
108115
<ItemsToSign Include="$(DownloadDirectory)**\*.rpm" />
109116
</ItemGroup>
110117

111-
<ItemGroup>
112-
<!-- External files -->
113-
<ItemsToSign Remove="@(ItemsToSign->WithMetadataValue('Filename', 'Newtonsoft.Json'))" />
114-
<ItemsToSign Remove="@(ItemsToSign->WithMetadataValue('Filename', 'Mono.Cecil'))" />
115-
<ItemsToSign Remove="@(ItemsToSign->WithMetadataValue('Filename', 'Mono.Cecil.Pdb'))" />
116-
<ItemsToSign Remove="@(ItemsToSign->WithMetadataValue('Filename', 'Mono.Cecil.Rocks'))" />
117-
</ItemGroup>
118-
119118
<ItemGroup>
120119
<ItemsToSign Update="@(ItemsToSign)" Authenticode="$(CertificateId)" />
121120
</ItemGroup>

0 commit comments

Comments
 (0)