Skip to content

Commit 89447d5

Browse files
[release/6.0-staging] Fix #103485 (#103935)
1 parent 40f8a8d commit 89447d5

12 files changed

+573
-511
lines changed

eng/pipelines/common/global-build-job.yml

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ parameters:
2828
enableRichCodeNavigation: false
2929
richCodeNavigationLanguage: 'csharp'
3030
richCodeNavigationEnvironment: 'production'
31+
preBuildSteps: []
3132

3233
jobs:
3334
- template: /eng/common/templates/job/job.yml
@@ -63,6 +64,8 @@ jobs:
6364

6465
- name: _osParameter
6566
value: -os ${{ parameters.osGroup }}
67+
- name: _archParameter
68+
value: -arch ${{ parameters.archType }}
6669

6770
- ${{ if and(eq(parameters.osGroup, 'Linux'), eq(parameters.osSubGroup, '_musl')) }}:
6871
- name: _osParameter
@@ -169,13 +172,36 @@ jobs:
169172
- script: $(Build.SourcesDirectory)\eng\common\init-tools-native.cmd -InstallDirectory $(Build.SourcesDirectory)\native-tools -Force
170173
displayName: Install native dependencies
171174

175+
- ${{ if ne(parameters.preBuildSteps,'') }}:
176+
- ${{ each preBuildStep in parameters.preBuildSteps }}:
177+
- ${{ if ne(preBuildStep.template, '') }}:
178+
- template: ${{ preBuildStep.template }}
179+
parameters:
180+
osGroup: ${{ parameters.osGroup }}
181+
osSubgroup: ${{ parameters.osSubgroup }}
182+
archType: ${{ parameters.archType }}
183+
buildConfig: ${{ parameters.buildConfig }}
184+
runtimeFlavor: ${{ parameters.runtimeFlavor }}
185+
runtimeVariant: ${{ parameters.runtimeVariant }}
186+
helixQueues: ${{ parameters.helixQueues }}
187+
targetRid: ${{ parameters.targetRid }}
188+
nameSuffix: ${{ parameters.nameSuffix }}
189+
platform: ${{ parameters.platform }}
190+
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
191+
${{ if ne(preBuildStep.forwardedParameters, '') }}:
192+
${{ each parameter in preBuildStep.forwardedParameters }}:
193+
${{ parameter }}: ${{ parameters[parameter] }}
194+
${{ if ne(preBuildStep.parameters, '') }}:
195+
${{ insert }}: ${{ preBuildStep.parameters }}
196+
- ${{ else }}:
197+
- ${{ preBuildStep }}
198+
172199
# Build
173200
- template: /eng/pipelines/common/templates/global-build-step.yml
174201
parameters:
175202
buildArgs: ${{ parameters.buildArgs }}
176203
useContinueOnErrorDuringBuild: ${{ parameters.useContinueOnErrorDuringBuild }}
177204
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
178-
archType: ${{ parameters.archType }}
179205

180206
- ${{ if in(parameters.osGroup, 'OSX', 'iOS', 'tvOS', 'Android') }}:
181207
- script: |

eng/pipelines/common/templates/global-build-step.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ parameters:
22
buildArgs: ''
33
useContinueOnErrorDuringBuild: false
44
shouldContinueOnError: false
5-
archType: ''
5+
archParameter: $(_archParameter)
66
displayName: Build product
77

88
steps:
9-
- script: $(_sclEnableCommand) $(Build.SourcesDirectory)$(dir)build$(scriptExt) -ci -arch ${{ parameters.archType }} $(_osParameter) ${{ parameters.buildArgs }} $(_officialBuildParameter) $(_crossBuildPropertyArg) $(_cxx11Parameter) $(_richCodeNavigationParam) $(_buildDarwinFrameworksParameter)
9+
- script: $(_sclEnableCommand) $(Build.SourcesDirectory)$(dir)build$(scriptExt) -ci ${{ parameters.archParameter }} $(_osParameter) ${{ parameters.buildArgs }} $(_officialBuildParameter) $(_crossBuildPropertyArg) $(_cxx11Parameter) $(_richCodeNavigationParam) $(_buildDarwinFrameworksParameter)
1010
displayName: ${{ parameters.displayName }}
1111
${{ if eq(parameters.useContinueOnErrorDuringBuild, true) }}:
1212
continueOnError: ${{ parameters.shouldContinueOnError }}

eng/pipelines/common/xplat-setup.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ jobs:
127127

128128
# OSX Build Pool (we don't have on-prem OSX BuildPool
129129
${{ if in(parameters.osGroup, 'OSX', 'MacCatalyst', 'iOS', 'iOSSimulator', 'tvOS', 'tvOSSimulator') }}:
130-
vmImage: 'macOS-11'
130+
vmImage: 'macOS-12'
131131

132132
# Official Build Windows Pool
133133
${{ if and(eq(parameters.osGroup, 'windows'), ne(variables['System.TeamProject'], 'public')) }}:

eng/pipelines/coreclr/templates/crossdac-hostarch.yml

Lines changed: 0 additions & 9 deletions
This file was deleted.

eng/pipelines/coreclr/templates/xplat-pipeline-job.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,6 @@ jobs:
8181
- name: buildLinuxDacStagingPath
8282
value: '$(crossDacArtifactPath)/Linux.$(archType).$(buildConfigUpper)'
8383

84-
- name: crossDacHostArch
85-
value: x64
86-
87-
- ${{ if eq(parameters.archType, 'arm') }}:
88-
- name: crossDacHostArch
89-
value: x86
90-
9184
# We need this because both mono and coreclr build currently depends on CoreClr
9285
- name: coreClrProductArtifactName
9386
value: 'CoreCLRProduct_${{ parameters.runtimeVariant }}_$(osGroup)$(osSubgroup)_$(archType)_$(buildConfig)'

0 commit comments

Comments
 (0)