Skip to content

Commit 7fdd4ee

Browse files
authored
Enable config binding gen tests that pass (#86406)
1 parent 345b0a5 commit 7fdd4ee

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/libraries/Microsoft.Extensions.Configuration.Binder/tests/Common/ConfigurationBinderTests.Collections.cs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -944,7 +944,7 @@ public void BindAlreadyInitializedArray()
944944
Assert.Equal("valx", array[6]);
945945
}
946946

947-
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))]
947+
[Fact]
948948
public void ArrayInNestedOptionBinding()
949949
{
950950
var input = new Dictionary<string, string>
@@ -973,7 +973,7 @@ public void ArrayInNestedOptionBinding()
973973
Assert.Equal(12, options.ObjectArray[1].ArrayInNestedOption[2]);
974974
}
975975

976-
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))]
976+
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))] // Ensure exception messages are in sync
977977
public void UnsupportedMultidimensionalArrays()
978978
{
979979
var input = new Dictionary<string, string>
@@ -1209,7 +1209,7 @@ public void CanBindInitializedIReadOnlyDictionaryAndDoesNotModifyTheOriginal()
12091209
Assert.Equal("val_2", InitializedCollectionsOptions.ExistingDictionary["existing_key_2"]);
12101210
}
12111211

1212-
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))]
1212+
[Fact]
12131213
public void CanBindUninitializedICollection()
12141214
{
12151215
var input = new Dictionary<string, string>
@@ -1275,7 +1275,7 @@ public void CanBindUninitializedIList()
12751275
Assert.Equal("ExtraItem", options.IList[4]);
12761276
}
12771277

1278-
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))]
1278+
[Fact]
12791279
public void CanBindUninitializedIReadOnlyCollection()
12801280
{
12811281
var input = new Dictionary<string, string>
@@ -1303,7 +1303,7 @@ public void CanBindUninitializedIReadOnlyCollection()
13031303
Assert.Equal("valx", array[3]);
13041304
}
13051305

1306-
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))]
1306+
[Fact]
13071307
public void CanBindUninitializedIReadOnlyList()
13081308
{
13091309
var input = new Dictionary<string, string>
@@ -1331,7 +1331,7 @@ public void CanBindUninitializedIReadOnlyList()
13311331
Assert.Equal("valx", array[3]);
13321332
}
13331333

1334-
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))]
1334+
[Fact]
13351335
public void CanBindUninitializedIDictionary()
13361336
{
13371337
var input = new Dictionary<string, string>
@@ -1382,7 +1382,7 @@ public void CanBindUninitializedIReadOnlyDictionary()
13821382
/// <summary>
13831383
/// Replicates scenario from https://github.com/dotnet/runtime/issues/65710
13841384
/// </summary>
1385-
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))]
1385+
[Fact]
13861386
public void CanBindWithInterdependentProperties()
13871387
{
13881388
var input = new Dictionary<string, string>
@@ -1444,7 +1444,7 @@ public void CanBindNonInstantiatedIEnumerableWithItems()
14441444
Assert.Equal("Yo2", options.NonInstantiatedIEnumerable.ElementAt(1));
14451445
}
14461446

1447-
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))]
1447+
[Fact]
14481448
public void CanBindNonInstantiatedISet()
14491449
{
14501450
var dic = new Dictionary<string, string>
@@ -1465,7 +1465,7 @@ public void CanBindNonInstantiatedISet()
14651465
Assert.Equal("Yo2", options.NonInstantiatedISet.ElementAt(1));
14661466
}
14671467

1468-
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))]
1468+
[Fact]
14691469
public void CanBindISetNoSetter()
14701470
{
14711471
var dic = new Dictionary<string, string>
@@ -1507,7 +1507,7 @@ public void CanBindInstantiatedIReadOnlySet()
15071507
Assert.Equal("Yo2", options.InstantiatedIReadOnlySet.ElementAt(1));
15081508
}
15091509

1510-
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))]
1510+
[Fact]
15111511
public void CanBindInstantiatedIReadOnlyWithSomeValues()
15121512
{
15131513
var dic = new Dictionary<string, string>
@@ -1714,7 +1714,7 @@ public void CanBindNonInstantiatedReadOnlyDictionary()
17141714
Assert.Equal(4, options.NonInstantiatedReadOnlyDictionary["item4"]);
17151715
}
17161716

1717-
[ConditionalFact(typeof(TestHelpers), nameof(TestHelpers.NotSourceGenMode))]
1717+
[Fact]
17181718
public void CanBindNonInstantiatedDictionaryOfISet()
17191719
{
17201720
var dic = new Dictionary<string, string>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace Microsoft.Extensions.Configuration.Binder.SourceGeneration.Tests
2121
{
2222
#if NETCOREAPP
2323
[ActiveIssue("https://github.com/dotnet/runtime/issues/52062", TestPlatforms.Browser)]
24-
public class ConfingurationBindingSourceGeneratorTests
24+
public class ConfigurationBindingSourceGeneratorTests
2525
{
2626
private const string BindCallSampleCode = @"
2727
using System.Collections.Generic;

0 commit comments

Comments
 (0)