Skip to content

Commit 79e3cd0

Browse files
authored
Working with StressLogAnalyzer I found yet another issue where we are missing an initialization when re-running the analysis - when you add a format string to look for via the -f option, and then later remove it, it's not actually removed, but is still found. (#74491)
missing an initialization when re-running the analysis - when you add a format string to look for via the -f option, and then later remove it, it's not actually removed, but is still found. The fix is simply to clear the s_interestingStringTable above the fixed entries.
1 parent 3eccadf commit 79e3cd0

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/coreclr/tools/StressLogAnalyzer/StressLogPlugin.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1227,6 +1227,10 @@ int ProcessStressLog(void* baseAddress, int argc, char* argv[])
12271227
s_fPrintFormatStrings = false;
12281228
s_showAllMessages = false;
12291229
s_maxHeapNumberSeen = -1;
1230+
for (int i = IS_INTERESTING; i < s_interestingStringCount; i++)
1231+
{
1232+
s_interestingStringTable[i] = nullptr;
1233+
}
12301234
s_interestingStringCount = IS_INTERESTING;
12311235
s_levelFilterCount = 0;
12321236
s_gcFilterStart = 0;

0 commit comments

Comments
 (0)