Address feedback

Author: layomia

src/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs

@@ -659,14 +659,14 @@ private string GenerateFastPathFuncForObject(TypeGenerationSpec typeGenSpec, str
                     sb.Append($@"{Environment.NewLine}    ");
                 }
 
-                sb.Append($@"{WriterVarName}.WriteStartObject();"); //  writer.WriteNumber(""yo"", 45);
+                sb.Append($@"{WriterVarName}.WriteStartObject();");
 
                 // Provide generation logic for each prop.
                 Debug.Assert(serializableProperties != null);
 
                 foreach (PropertyGenerationSpec propertyGenSpec in serializableProperties.Values)
                 {
-                    if (!ShouldIncludeForFastPath(propertyGenSpec, options))
+                    if (!ShouldIncludePropertyForFastPath(propertyGenSpec, options))
                     {
                         continue;
                     }
@@ -739,7 +739,7 @@ private string GenerateFastPathFuncForObject(TypeGenerationSpec typeGenSpec, str
                 return GenerateFastPathFuncForType(serializeMethodName, typeRef, sb.ToString(), typeGenSpec.CanBeNull);
             }
 
-            private static bool ShouldIncludeForFastPath(PropertyGenerationSpec propertyGenSpec, JsonSourceGenerationOptionsAttribute options)
+            private static bool ShouldIncludePropertyForFastPath(PropertyGenerationSpec propertyGenSpec, JsonSourceGenerationOptionsAttribute options)
             {
                 TypeGenerationSpec propertyTypeSpec = propertyGenSpec.TypeGenerationSpec;
 

src/libraries/System.Text.Json/gen/Reflection/TypeWrapper.cs

@@ -314,7 +314,6 @@ public override Type[] GetNestedTypes(BindingFlags bindingAttr)
             return nestedTypes.ToArray();
         }
 
-        // TODO: make sure to use bindingAttr for correctness. Current implementation assumes public and non-static.
         public override PropertyInfo[] GetProperties(BindingFlags bindingAttr)
         {
             List<PropertyInfo> properties = new();
@@ -338,11 +337,6 @@ public override PropertyInfo[] GetProperties(BindingFlags bindingAttr)
                     {
                         properties.Add(new PropertyInfoWrapper(propertySymbol, _metadataLoadContext));
                     }
-
-                    //if ((item.DeclaredAccessibility & Accessibility.Public) == Accessibility.Public)
-                    //{
-                    //    properties.Add(new PropertyInfoWrapper(property, _metadataLoadContext));
-                    //}
                 }
             }