Skip to content

Commit 6f9792f

Browse files
pavelsavarapavelsavara
authored
[nodejs][http] remove active issue 86326 (#89588)
1 parent 4ed3550 commit 6f9792f

File tree

5 files changed

+0
-30
lines changed

5 files changed

+0
-30
lines changed

‎src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,6 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
185185

186186
[ConditionalTheory]
187187
[MemberData(nameof(GetAsync_IPBasedUri_Success_MemberData))]
188-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
189188
public async Task GetAsync_IPBasedUri_Success(IPAddress address)
190189
{
191190
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
@@ -1229,7 +1228,6 @@ await server.AcceptConnectionAsync(async connection =>
12291228
}
12301229

12311230
[Fact]
1232-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
12331231
public async Task ReadAsStreamAsync_EmptyResponseBody_HandlerProducesWellBehavedResponseStream()
12341232
{
12351233
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
@@ -1399,7 +1397,6 @@ await server.AcceptConnectionAsync(async connection =>
13991397
}
14001398

14011399
[Fact]
1402-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
14031400
public async Task Dispose_DisposingHandlerCancelsActiveOperationsWithoutResponses()
14041401
{
14051402
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
@@ -1647,7 +1644,6 @@ await server.AcceptConnectionAsync(async connection =>
16471644

16481645
[Theory]
16491646
[MemberData(nameof(Interim1xxStatusCode))]
1650-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
16511647
public async Task SendAsync_Unexpected1xxResponses_DropAllInterimResponses(HttpStatusCode responseStatusCode)
16521648
{
16531649
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
@@ -2029,7 +2025,6 @@ await LoopbackServer.CreateServerAsync(async (server, url) =>
20292025
}
20302026

20312027
[Fact]
2032-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
20332028
public async Task SendAsync_RequestVersion20_HttpNotHttps_NoUpgradeRequest()
20342029
{
20352030
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
@@ -2065,7 +2060,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
20652060

20662061
#region Uri wire transmission encoding tests
20672062
[Fact]
2068-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
20692063
public async Task SendRequest_UriPathHasReservedChars_ServerReceivedExpectedPath()
20702064
{
20712065
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)

‎src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Headers.cs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ public HttpClientHandlerTest_Headers(ITestOutputHelper output) : base(output) {
2424
private sealed class DerivedHttpHeaders : HttpHeaders { }
2525

2626
[Fact]
27-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
2827
public async Task SendAsync_RequestWithSimpleHeader_ResponseReferencesUnmodifiedRequestHeaders()
2928
{
3029
const string HeaderKey = "some-header-123", HeaderValue = "this is the expected header value";
@@ -72,7 +71,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
7271
}
7372

7473
[Fact]
75-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
7674
public async Task SendAsync_LargeHeaders_CorrectlyWritten()
7775
{
7876
if (UseVersion == HttpVersion.Version30)
@@ -108,7 +106,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
108106
}
109107

110108
[Fact]
111-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
112109
public async Task SendAsync_DefaultHeaders_CorrectlyWritten()
113110
{
114111
const string Version = "2017-04-17";
@@ -170,7 +167,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
170167
[InlineData("Accept-CharSet", "text/plain, text/json", false)] // invalid format for header but added with TryAddWithoutValidation
171168
[InlineData("Content-Location", "", false)] // invalid format for header but added with TryAddWithoutValidation
172169
[InlineData("Max-Forwards", "NotAnInteger", false)] // invalid format for header but added with TryAddWithoutValidation
173-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
174170
public async Task SendAsync_SpecialHeaderKeyOrValue_Success(string key, string value, bool parsable)
175171
{
176172
if (PlatformDetection.IsBrowser && (key == "Content-Location" || key == "Date" || key == "Accept-CharSet"))
@@ -216,7 +212,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
216212
[Theory]
217213
[InlineData("Content-Security-Policy", 4618)]
218214
[InlineData("RandomCustomHeader", 12345)]
219-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
220215
public async Task GetAsync_LargeHeader_Success(string headerName, int headerValueLength)
221216
{
222217
var rand = new Random(42);
@@ -241,7 +236,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
241236
}
242237

243238
[Fact]
244-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
245239
public async Task GetAsync_EmptyResponseHeader_Success()
246240
{
247241
IList<HttpHeaderData> headers = new HttpHeaderData[] {
@@ -273,7 +267,6 @@ await server.AcceptConnectionAsync(async connection =>
273267
}
274268

275269
[Fact]
276-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
277270
public async Task GetAsync_MissingExpires_ReturnNull()
278271
{
279272
await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
@@ -294,7 +287,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
294287
[InlineData("Thu, 01 Dec 1994 16:00:00 GMT", true)]
295288
[InlineData("-1", false)]
296289
[InlineData("0", false)]
297-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
298290
public async Task SendAsync_Expires_Success(string value, bool isValid)
299291
{
300292
await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
@@ -333,7 +325,6 @@ public void HeadersAdd_CustomExpires_Success(string value, bool isValid)
333325

334326
[Theory]
335327
[InlineData("Accept-Encoding", "identity,gzip")]
336-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
337328
public async Task SendAsync_RequestHeaderInResponse_Success(string name, string value)
338329
{
339330
await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
@@ -358,7 +349,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(async uri =>
358349
[Theory]
359350
[InlineData(false)]
360351
[InlineData(true)]
361-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
362352
public async Task SendAsync_GetWithValidHostHeader_Success(bool withPort)
363353
{
364354
if (UseVersion == HttpVersion.Version30)

‎src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientTest.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,6 @@ public async Task GetAsync_CustomException_Asynchronous_ThrowsException()
370370
}
371371

372372
[Fact]
373-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
374373
public async Task GetStringAsync_Success()
375374
{
376375
string content = Guid.NewGuid().ToString();
@@ -390,7 +389,6 @@ await LoopbackServer.CreateClientAndServerAsync(
390389
}
391390

392391
[Fact]
393-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
394392
public async Task GetStringAsync_CanBeCanceled_AlreadyCanceledCts()
395393
{
396394
var onClientFinished = new SemaphoreSlim(0, 1);
@@ -415,7 +413,6 @@ await LoopbackServer.CreateClientAndServerAsync(
415413
}
416414

417415
[Fact]
418-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
419416
public async Task GetStringAsync_CanBeCanceled()
420417
{
421418
var cts = new CancellationTokenSource();
@@ -542,7 +539,6 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
542539
}
543540

544541
[Fact]
545-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
546542
public async Task GetByteArrayAsync_Success()
547543
{
548544
string content = Guid.NewGuid().ToString();
@@ -587,7 +583,6 @@ await LoopbackServer.CreateClientAndServerAsync(
587583
}
588584

589585
[Fact]
590-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
591586
public async Task GetByteArrayAsync_CanBeCanceled()
592587
{
593588
var cts = new CancellationTokenSource();
@@ -618,7 +613,6 @@ await server.AcceptConnectionAsync(async connection =>
618613
}
619614

620615
[Fact]
621-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
622616
public async Task GetStreamAsync_Success()
623617
{
624618
string content = Guid.NewGuid().ToString();
@@ -666,7 +660,6 @@ await LoopbackServer.CreateClientAndServerAsync(
666660
}
667661

668662
[Fact]
669-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
670663
public async Task GetStreamAsync_CanBeCanceled()
671664
{
672665
var cts = new CancellationTokenSource();

‎src/libraries/System.Net.Http/tests/FunctionalTests/HttpContentTest.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -613,7 +613,6 @@ public void Dispose_DisposedObjectThenAccessMembers_ThrowsObjectDisposedExceptio
613613

614614

615615
[Fact]
616-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
617616
public async Task ReadAsStringAsync_Buffered_IgnoresCancellationToken()
618617
{
619618
string content = Guid.NewGuid().ToString();
@@ -671,7 +670,6 @@ await LoopbackServer.CreateClientAndServerAsync(
671670
}
672671

673672
[Fact]
674-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
675673
public async Task ReadAsStringAsync_Unbuffered_CanBeCanceled()
676674
{
677675
var cts = new CancellationTokenSource();
@@ -709,7 +707,6 @@ await server.AcceptConnectionAsync(async connection =>
709707
}
710708

711709
[Fact]
712-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
713710
public async Task ReadAsByteArrayAsync_Buffered_IgnoresCancellationToken()
714711
{
715712
string content = Guid.NewGuid().ToString();
@@ -768,7 +765,6 @@ await LoopbackServer.CreateClientAndServerAsync(
768765
}
769766

770767
[Fact]
771-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
772768
public async Task ReadAsByteArrayAsync_Unbuffered_CanBeCanceled()
773769
{
774770
var cts = new CancellationTokenSource();
@@ -808,7 +804,6 @@ await server.AcceptConnectionAsync(async connection =>
808804
[Theory]
809805
[InlineData(true)]
810806
[InlineData(false)]
811-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
812807
public async Task ReadAsStreamAsync_Buffered_IgnoresCancellationToken(bool readStreamAsync)
813808
{
814809
string content = Guid.NewGuid().ToString();
@@ -840,7 +835,6 @@ await LoopbackServer.CreateClientAndServerAsync(
840835
[Theory]
841836
[InlineData(true)]
842837
[InlineData(false)]
843-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
844838
public async Task ReadAsStreamAsync_Unbuffered_IgnoresCancellationToken(bool readStreamAsync)
845839
{
846840
if(PlatformDetection.IsBrowser && !readStreamAsync)

‎src/libraries/System.Net.Http/tests/FunctionalTests/HttpRequestMessageTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,6 @@ await server.AcceptConnectionAsync(async connection =>
267267
}
268268

269269
[Fact]
270-
[ActiveIssue("https://github.com/dotnet/runtime/issues/86326", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
271270
public async Task HttpRequest_BodylessMethod_LargeContentLength()
272271
{
273272
using (HttpClient client = CreateHttpClient())

0 commit comments

Comments
 (0)