Skip to content

Commit 6c7da6f

Browse files
authored
Fix duplicate --runtime-path in generated helix command (#40975)
While looking at some helix debug logs I noticed we pass the `--runtime-path` option twice: ``` Executed on dci-mac-build-083.local + ./RunTests.sh --runtime-path /tmp/helix/working/A68F0925/p --runtime-path /tmp/helix/working/A68F0925/p ``` Looks like this was an oversight from #35606, it's harmless but I thought I'd clean it up :)
1 parent e8c0a4c commit 6c7da6f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/libraries/sendtohelixhelp.proj

+2-2
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,9 @@
135135
We "exit /b" at the end of RunTests.cmd. Helix runs some other commands after ours within the batch script,
136136
so if we don't use "call", then we cause the parent script to exit, and anything after will not be executed.
137137
-->
138-
<HelixCommand Condition="'$(TargetsWindows)' == 'true'">call RunTests.cmd --runtime-path %HELIX_CORRELATION_PAYLOAD%</HelixCommand>
138+
<HelixCommand Condition="'$(TargetsWindows)' == 'true'">call RunTests.cmd</HelixCommand>
139139
<HelixCommand Condition="'$(TargetsWindows)' == 'true' and '$(HelixCorrelationPayload)' != ''">$(HelixCommand) --runtime-path %HELIX_CORRELATION_PAYLOAD%</HelixCommand>
140-
<HelixCommand Condition="'$(TargetsWindows)' != 'true'">./RunTests.sh --runtime-path "$HELIX_CORRELATION_PAYLOAD"</HelixCommand>
140+
<HelixCommand Condition="'$(TargetsWindows)' != 'true'">./RunTests.sh</HelixCommand>
141141
<HelixCommand Condition="'$(TargetsWindows)' != 'true' and '$(HelixCorrelationPayload)' != ''">$(HelixCommand) --runtime-path "$HELIX_CORRELATION_PAYLOAD"</HelixCommand>
142142
</PropertyGroup>
143143

0 commit comments

Comments
 (0)