Investigate helix error return (#70238)

Author: LakshanF

eng/testing/xunit/xunit.console.targets

@@ -36,6 +36,11 @@
     <XunitExcludesTxtFileContent>$(_withoutCategories.Replace(';', '%0dcategory='))</XunitExcludesTxtFileContent>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(TestSingleFile)' == 'true'">
+    <!-- Pass the results file -->
+    <RunScriptCommand>$(RunScriptCommand) -xml $(TestResultsName)</RunScriptCommand>
+  </PropertyGroup>
+
   <ItemGroup Condition="'$(TestSingleFile)' != 'true'">
     <PackageReference Include="Microsoft.DotNet.XUnitConsoleRunner"
                       Version="$(MicrosoftDotNetXUnitConsoleRunnerVersion)"

src/libraries/Common/tests/SingleFileTestRunner/SingleFileTestRunner.cs

@@ -15,6 +15,8 @@
 using Xunit.Abstractions;
 using Xunit.Sdk;
 
+// @TODO medium-to-longer term, we should try to get rid of the special-unicorn-single-file runner in favor of making the real runner work for single file.
+// https://github.com/dotnet/runtime/issues/70432
 public class SingleFileTestRunner : XunitTestFramework
 {
     private SingleFileTestRunner(IMessageSink messageSink)
@@ -58,8 +60,9 @@ public static int Main(string[] args)
         discoverer.Find(false, discoverySink, TestFrameworkOptions.ForDiscovery(assemblyConfig));
         discoverySink.Finished.WaitOne();
 
+        string xmlResultFileName = null;
         XunitFilters filters = new XunitFilters();
-        // Quick hack wo much validation to get no traits passed
+        // Quick hack wo much validation to get args that are passed (notrait, xml)
         Dictionary<string, List<string>> noTraits = new Dictionary<string, List<string>>();
         for (int i = 0; i < args.Length; i++)
         {
@@ -72,6 +75,10 @@ public static int Main(string[] args)
                 }
                 values.Add(traitKeyValue[1]);
             }
+            if (args[i].Equals("-xml", StringComparison.OrdinalIgnoreCase))
+            {
+                xmlResultFileName=args[i + 1].Trim();
+            }
         }
 
         foreach (KeyValuePair<string, List<string>> kvp in noTraits)
@@ -85,6 +92,12 @@ public static int Main(string[] args)
 
         resultsSink.Finished.WaitOne();
 
+        // Helix need to see results file in the drive to detect if the test has failed or not
+        if(xmlResultFileName != null)
+        {
+            resultsXmlAssembly.Save(xmlResultFileName);
+        }
+
         var failed = resultsSink.ExecutionSummary.Failed > 0 || resultsSink.ExecutionSummary.Errors > 0;
         return failed ? 1 : 0;
     }