[main] Update dependencies from dotnet/roslyn-analyzers (#87768)

dotnet-maestro[bot] · buyaa-n · web-flow · commit 54cb57399dab · 2023-07-10T13:38:41.000-07:00
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230618.1 * Suppress RS1038 analyzer * Fix new failures found with CA1859 analyzer updates * Disable CA2261 on test projects, fix more CA1859 findings --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
diff --git a/eng/CodeAnalysis.src.globalconfig b/eng/CodeAnalysis.src.globalconfig
@@ -658,6 +658,9 @@ dotnet_diagnostic.CA2259.severity = warning
 # CA2260: Use correct type parameter
 dotnet_diagnostic.CA2260.severity = warning
 
+# CA2261: Do not use ConfigureAwaitOptions.SuppressThrowing with Task<TResult>
+dotnet_diagnostic.CA2261.severity = warning
+
 # CA2300: Do not use insecure deserializer BinaryFormatter
 dotnet_diagnostic.CA2300.severity = none
 
diff --git a/eng/CodeAnalysis.test.globalconfig b/eng/CodeAnalysis.test.globalconfig
@@ -654,6 +654,9 @@ dotnet_diagnostic.CA2259.severity = none
 # CA2260: Use correct type parameter
 dotnet_diagnostic.CA2260.severity = none
 
+# CA2261: Do not use ConfigureAwaitOptions.SuppressThrowing with Task<TResult>
+dotnet_diagnostic.CA2261.severity = none
+
 # CA2300: Do not use insecure deserializer BinaryFormatter
 dotnet_diagnostic.CA2300.severity = none
 
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
@@ -372,13 +372,13 @@
       <Uri>https://github.com/dotnet/roslyn</Uri>
       <Sha>7787409c6b529c021d4f8b5fbe3d620094953be9</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.CodeAnalysis.Analyzers" Version="3.3.5-beta1.23308.2">
+    <Dependency Name="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0-beta1.23357.1">
       <Uri>https://github.com/dotnet/roslyn-analyzers</Uri>
-      <Sha>2f0301ef59624a72fb00f7fd92caa50be03f277d</Sha>
+      <Sha>82603c16509d7383cd1922680773a79b839b1705</Sha>
     </Dependency>
-    <Dependency Name="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0-preview.23308.2">
+    <Dependency Name="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0-preview.23357.1">
       <Uri>https://github.com/dotnet/roslyn-analyzers</Uri>
-      <Sha>2f0301ef59624a72fb00f7fd92caa50be03f277d</Sha>
+      <Sha>82603c16509d7383cd1922680773a79b839b1705</Sha>
     </Dependency>
     <Dependency Name="Microsoft.DotNet.ApiCompat.Task" Version="8.0.100-preview.7.23329.3">
       <Uri>https://github.com/dotnet/sdk</Uri>
diff --git a/eng/Versions.props b/eng/Versions.props
@@ -32,8 +32,8 @@
   </ItemGroup>
   <PropertyGroup>
     <!-- dotnet/roslyn-analyzers dependencies -->
-    <MicrosoftCodeAnalysisAnalyzersVersion>3.3.5-beta1.23308.2</MicrosoftCodeAnalysisAnalyzersVersion>
-    <MicrosoftCodeAnalysisNetAnalyzersVersion>8.0.0-preview.23308.2</MicrosoftCodeAnalysisNetAnalyzersVersion>
+    <MicrosoftCodeAnalysisAnalyzersVersion>3.11.0-beta1.23357.1</MicrosoftCodeAnalysisAnalyzersVersion>
+    <MicrosoftCodeAnalysisNetAnalyzersVersion>8.0.0-preview.23357.1</MicrosoftCodeAnalysisNetAnalyzersVersion>
     <!-- dotnet/roslyn dependencies -->
     <!--
       These versions should not be used by any project that contributes to the design-time experience in VS, such as an analyzer, code-fix, or generator assembly.
diff --git a/src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/Runtime/MethodInfos/RuntimeMethodInfo.cs b/src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/Runtime/MethodInfos/RuntimeMethodInfo.cs
@@ -325,8 +325,10 @@ internal Delegate CreateDelegateNoThrowOnBindFailure(RuntimeTypeInfo runtimeDele
                 return null;
             }
 
+#pragma warning disable CA1859 // Use concrete types when possible for improved performance https://github.com/dotnet/roslyn-analyzers/issues/6751
             IList<ParameterInfo> delegateParameters = invokeMethod.GetParametersNoCopy();
             IList<ParameterInfo> targetParameters = this.GetParametersNoCopy();
+#pragma warning restore CA1859
             IEnumerator<ParameterInfo> delegateParameterEnumerator = delegateParameters.GetEnumerator();
             IEnumerator<ParameterInfo> targetParameterEnumerator = targetParameters.GetEnumerator();
 
diff --git a/src/coreclr/tools/Common/Compiler/GenericCycleDetection/Graph.Cycles.cs b/src/coreclr/tools/Common/Compiler/GenericCycleDetection/Graph.Cycles.cs
@@ -311,7 +311,7 @@ public IEnumerable<P> ComputeVerticesInvolvedInAFlaggedCycle()
                 }
 #endif
 
-                return verticesInAFlaggedCycleTarjanStyle.Select(v => v.Payload).ToArray();
+                return verticesInAFlaggedCycleTarjanStyle.Select(v => v.Payload);
             }
 
             /// <summary>
diff --git a/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/VTableSliceNode.cs b/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/VTableSliceNode.cs
@@ -102,7 +102,7 @@ public EagerlyBuiltVTableSliceNode(TypeDesc type)
         {
         }
 
-        private static IReadOnlyList<MethodDesc> ComputeSlots(TypeDesc type)
+        private static MethodDesc[] ComputeSlots(TypeDesc type)
         {
             var slots = default(ArrayBuilder<MethodDesc>);
 
diff --git a/src/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs b/src/libraries/Microsoft.Extensions.Logging.EventSource/src/EventSourceLogger.cs
@@ -194,7 +194,7 @@ private static ExceptionInfo GetExceptionInfo(Exception? exception)
         /// <summary>
         /// Converts an ILogger state object into a set of key-value pairs (That can be send to a EventSource)
         /// </summary>
-        private static IReadOnlyList<KeyValuePair<string, string?>> GetProperties(object? state)
+        private static KeyValuePair<string, string?>[] GetProperties(object? state)
         {
             if (state is IReadOnlyList<KeyValuePair<string, object?>> keyValuePairs)
             {
diff --git a/src/libraries/System.Linq/src/System/Linq/Enumerable.SizeOpt.cs b/src/libraries/System.Linq/src/System/Linq/Enumerable.SizeOpt.cs
@@ -9,7 +9,7 @@ public static partial class Enumerable
     {
         public static IEnumerable<TResult> Empty<TResult>() => Array.Empty<TResult>();
 
-        private static IEnumerable<TResult>? GetEmptyIfEmpty<TSource, TResult>(IEnumerable<TSource> source) =>
+        private static TResult[]? GetEmptyIfEmpty<TSource, TResult>(IEnumerable<TSource> source) =>
             source is TSource[] { Length: 0 } ?
                 Array.Empty<TResult>() :
                 null;
diff --git a/src/libraries/System.Private.Xml/src/System/Xml/Serialization/ReflectionXmlSerializationReader.cs b/src/libraries/System.Private.Xml/src/System/Xml/Serialization/ReflectionXmlSerializationReader.cs
@@ -89,7 +89,7 @@ protected override void InitIDs()
         }
 
         [RequiresUnreferencedCode(XmlSerializer.TrimSerializationWarning)]
-        private object GenerateMembersElement(XmlMembersMapping xmlMembersMapping)
+        private object?[] GenerateMembersElement(XmlMembersMapping xmlMembersMapping)
         {
             if (xmlMembersMapping.Accessor.IsSoap)
             {
@@ -102,7 +102,7 @@ private object GenerateMembersElement(XmlMembersMapping xmlMembersMapping)
         }
 
         [RequiresUnreferencedCode(XmlSerializer.TrimSerializationWarning)]
-        private object GenerateLiteralMembersElement(XmlMembersMapping xmlMembersMapping)
+        private object[] GenerateLiteralMembersElement(XmlMembersMapping xmlMembersMapping)
         {
             ElementAccessor element = xmlMembersMapping.Accessor;
             MemberMapping[] mappings = ((MembersMapping)element.Mapping!).Members!;
@@ -322,7 +322,7 @@ private static void InitializeValueTypes(object?[] p, MemberMapping[] mappings)
         }
 
         [RequiresUnreferencedCode(XmlSerializer.TrimSerializationWarning)]
-        private object GenerateEncodedMembersElement(XmlMembersMapping xmlMembersMapping)
+        private object?[] GenerateEncodedMembersElement(XmlMembersMapping xmlMembersMapping)
         {
             ElementAccessor element = xmlMembersMapping.Accessor;
             var membersMapping = (MembersMapping)element.Mapping!;
diff --git a/src/libraries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportGenerator.csproj b/src/libraries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportGenerator.csproj
@@ -8,7 +8,7 @@
     <IsRoslynComponent>true</IsRoslynComponent>
     <!-- Disable RS2008: Enable analyzer release tracking
          Diagnostics in runtime use a different mechanism (docs/project/list-of-diagnostics.md) -->
-    <NoWarn>RS2008;$(NoWarn)</NoWarn>
+    <NoWarn>RS2008;RS1038;$(NoWarn)</NoWarn>
     <DefineConstants>$(DefineConstants);JSIMPORTGENERATOR</DefineConstants>
     <AnalyzerLanguage>cs</AnalyzerLanguage>
   </PropertyGroup>
diff --git a/src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComInterfaceGenerator.csproj b/src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComInterfaceGenerator.csproj
@@ -8,7 +8,7 @@
     <IsRoslynComponent>true</IsRoslynComponent>
     <!-- Disable RS2008: Enable analyzer release tracking
          Diagnostics in runtime use a different mechanism (docs/project/list-of-diagnostics.md) -->
-    <NoWarn>RS2008;$(NoWarn)</NoWarn>
+    <NoWarn>RS2008;RS1038;$(NoWarn)</NoWarn>
     <AnalyzerLanguage>cs</AnalyzerLanguage>
     <DefineConstants>$(DefineConstants);MICROSOFT_INTEROP_COMINTERFACEGENERATOR</DefineConstants>
   </PropertyGroup>
diff --git a/src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/LibraryImportGenerator.csproj b/src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/LibraryImportGenerator.csproj
@@ -8,7 +8,7 @@
     <IsRoslynComponent>true</IsRoslynComponent>
     <!-- Disable RS2008: Enable analyzer release tracking
          Diagnostics in runtime use a different mechanism (docs/project/list-of-diagnostics.md) -->
-    <NoWarn>RS2008;$(NoWarn)</NoWarn>
+    <NoWarn>RS2008;RS1038;$(NoWarn)</NoWarn>
     <AnalyzerLanguage>cs</AnalyzerLanguage>
   </PropertyGroup>
 
diff --git a/src/libraries/System.Security.Cryptography.Pkcs/src/Internal/Cryptography/Pal/Windows/DecryptorPalWindows.DecodeRecipients.cs b/src/libraries/System.Security.Cryptography.Pkcs/src/Internal/Cryptography/Pal/Windows/DecryptorPalWindows.DecodeRecipients.cs
@@ -33,7 +33,9 @@ private static RecipientInfoCollection CreateRecipientInfos(SafeCryptMsgHandle h
             return new RecipientInfoCollection(recipientInfos);
         }
 
+#pragma warning disable CA1859 // Use concrete types when possible for improved performance https://github.com/dotnet/roslyn-analyzers/issues/6751
         private static IEnumerable<RecipientInfo> ToRecipientInfosForThisIndex(SafeHandle pCmsgCmsRecipientInfoMemory, int index)
+#pragma warning restore CA1859
         {
             bool mustRelease = false;
             pCmsgCmsRecipientInfoMemory.DangerousAddRef(ref mustRelease);

Original file line number	Diff line number	Diff line change
`@@ -325,8 +325,10 @@ internal Delegate CreateDelegateNoThrowOnBindFailure(RuntimeTypeInfo runtimeDele`
`325`	`325`	`return null;`
`326`	`326`	`}`
`327`	`327`
	`328`	`+#pragma warning disable CA1859 // Use concrete types when possible for improved performance https://github.com/dotnet/roslyn-analyzers/issues/6751`
`328`	`329`	`IList<ParameterInfo> delegateParameters = invokeMethod.GetParametersNoCopy();`
`329`	`330`	`IList<ParameterInfo> targetParameters = this.GetParametersNoCopy();`
	`331`	`+#pragma warning restore CA1859`
`330`	`332`	`IEnumerator<ParameterInfo> delegateParameterEnumerator = delegateParameters.GetEnumerator();`
`331`	`333`	`IEnumerator<ParameterInfo> targetParameterEnumerator = targetParameters.GetEnumerator();`
`332`	`334`
Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,7 @@ public IEnumerable<P> ComputeVerticesInvolvedInAFlaggedCycle()`
`311`	`311`	`}`
`312`	`312`	`#endif`
`313`	`313`
`314`		`- return verticesInAFlaggedCycleTarjanStyle.Select(v => v.Payload).ToArray();`
	`314`	`+ return verticesInAFlaggedCycleTarjanStyle.Select(v => v.Payload);`
`315`	`315`	`}`
`316`	`316`
`317`	`317`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ public EagerlyBuiltVTableSliceNode(TypeDesc type)`
`102`	`102`	`{`
`103`	`103`	`}`
`104`	`104`
`105`		`- private static IReadOnlyList<MethodDesc> ComputeSlots(TypeDesc type)`
	`105`	`+ private static MethodDesc[] ComputeSlots(TypeDesc type)`
`106`	`106`	`{`
`107`	`107`	`var slots = default(ArrayBuilder<MethodDesc>);`
`108`	`108`
Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ private static ExceptionInfo GetExceptionInfo(Exception? exception)`
`194`	`194`	`/// <summary>`
`195`	`195`	`/// Converts an ILogger state object into a set of key-value pairs (That can be send to a EventSource)`
`196`	`196`	`/// </summary>`
`197`		`- private static IReadOnlyList<KeyValuePair<string, string?>> GetProperties(object? state)`
	`197`	`+ private static KeyValuePair<string, string?>[] GetProperties(object? state)`
`198`	`198`	`{`
`199`	`199`	`if (state is IReadOnlyList<KeyValuePair<string, object?>> keyValuePairs)`
`200`	`200`	`{`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ public static partial class Enumerable`
`9`	`9`	`{`
`10`	`10`	`public static IEnumerable<TResult> Empty<TResult>() => Array.Empty<TResult>();`
`11`	`11`
`12`		`- private static IEnumerable<TResult>? GetEmptyIfEmpty<TSource, TResult>(IEnumerable<TSource> source) =>`
	`12`	`+ private static TResult[]? GetEmptyIfEmpty<TSource, TResult>(IEnumerable<TSource> source) =>`
`13`	`13`	`source is TSource[] { Length: 0 } ?`
`14`	`14`	`Array.Empty<TResult>() :`
`15`	`15`	`null;`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ protected override void InitIDs()`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`[RequiresUnreferencedCode(XmlSerializer.TrimSerializationWarning)]`
`92`		`- private object GenerateMembersElement(XmlMembersMapping xmlMembersMapping)`
	`92`	`+ private object?[] GenerateMembersElement(XmlMembersMapping xmlMembersMapping)`
`93`	`93`	`{`
`94`	`94`	`if (xmlMembersMapping.Accessor.IsSoap)`
`95`	`95`	`{`
`@@ -102,7 +102,7 @@ private object GenerateMembersElement(XmlMembersMapping xmlMembersMapping)`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`[RequiresUnreferencedCode(XmlSerializer.TrimSerializationWarning)]`
`105`		`- private object GenerateLiteralMembersElement(XmlMembersMapping xmlMembersMapping)`
	`105`	`+ private object[] GenerateLiteralMembersElement(XmlMembersMapping xmlMembersMapping)`
`106`	`106`	`{`
`107`	`107`	`ElementAccessor element = xmlMembersMapping.Accessor;`
`108`	`108`	`MemberMapping[] mappings = ((MembersMapping)element.Mapping!).Members!;`
`@@ -322,7 +322,7 @@ private static void InitializeValueTypes(object?[] p, MemberMapping[] mappings)`
`322`	`322`	`}`
`323`	`323`
`324`	`324`	`[RequiresUnreferencedCode(XmlSerializer.TrimSerializationWarning)]`
`325`		`- private object GenerateEncodedMembersElement(XmlMembersMapping xmlMembersMapping)`
	`325`	`+ private object?[] GenerateEncodedMembersElement(XmlMembersMapping xmlMembersMapping)`
`326`	`326`	`{`
`327`	`327`	`ElementAccessor element = xmlMembersMapping.Accessor;`
`328`	`328`	`var membersMapping = (MembersMapping)element.Mapping!;`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,9 @@ private static RecipientInfoCollection CreateRecipientInfos(SafeCryptMsgHandle h`
`33`	`33`	`return new RecipientInfoCollection(recipientInfos);`
`34`	`34`	`}`
`35`	`35`
	`36`	`+#pragma warning disable CA1859 // Use concrete types when possible for improved performance https://github.com/dotnet/roslyn-analyzers/issues/6751`
`36`	`37`	`private static IEnumerable<RecipientInfo> ToRecipientInfosForThisIndex(SafeHandle pCmsgCmsRecipientInfoMemory, int index)`
	`38`	`+#pragma warning restore CA1859`
`37`	`39`	`{`
`38`	`40`	`bool mustRelease = false;`
`39`	`41`	`pCmsgCmsRecipientInfoMemory.DangerousAddRef(ref mustRelease);`