Remove extraneous diagnostic (#69830)

jkoritzinsky · web-flow · commit 472050d35cbb · 2022-05-26T10:29:00.000-07:00
diff --git a/src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/LibraryImportGenerator.cs b/src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/LibraryImportGenerator.cs
@@ -274,7 +274,6 @@ private static IncrementalStubGenerationContext CalculateStubInformation(
 
             if (libraryImportData is null)
             {
-                generatorDiagnostics.ReportConfigurationNotSupported(generatedDllImportAttr!, "Invalid syntax");
                 libraryImportData = new LibraryImportData("INVALID_CSHARP_SYNTAX");
             }
 
diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CompileFails.cs b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CompileFails.cs
@@ -149,9 +149,9 @@ public static IEnumerable<object[]> CodeSnippetsToCompile_InvalidCode()
         {
             yield return new object[] { CodeSnippets.RecursiveImplicitlyBlittableStruct, 0, 1 };
             yield return new object[] { CodeSnippets.MutuallyRecursiveImplicitlyBlittableStruct, 0, 2 };
-            yield return new object[] { CodeSnippets.PartialPropertyName, 1, 2 };
-            yield return new object[] { CodeSnippets.InvalidConstantForModuleName, 1, 1 };
-            yield return new object[] { CodeSnippets.IncorrectAttributeFieldType, 1, 1 };
+            yield return new object[] { CodeSnippets.PartialPropertyName, 0, 2 };
+            yield return new object[] { CodeSnippets.InvalidConstantForModuleName, 0, 1 };
+            yield return new object[] { CodeSnippets.IncorrectAttributeFieldType, 0, 1 };
         }
 
         [Theory]

Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,6 @@ private static IncrementalStubGenerationContext CalculateStubInformation(`
`274`	`274`
`275`	`275`	`if (libraryImportData is null)`
`276`	`276`	`{`
`277`		`- generatorDiagnostics.ReportConfigurationNotSupported(generatedDllImportAttr!, "Invalid syntax");`
`278`	`277`	`libraryImportData = new LibraryImportData("INVALID_CSHARP_SYNTAX");`
`279`	`278`	`}`
`280`	`279`
Original file line number	Diff line number	Diff line change
`@@ -149,9 +149,9 @@ public static IEnumerable<object[]> CodeSnippetsToCompile_InvalidCode()`
`149`	`149`	`{`
`150`	`150`	`yield return new object[] { CodeSnippets.RecursiveImplicitlyBlittableStruct, 0, 1 };`
`151`	`151`	`yield return new object[] { CodeSnippets.MutuallyRecursiveImplicitlyBlittableStruct, 0, 2 };`
`152`		`- yield return new object[] { CodeSnippets.PartialPropertyName, 1, 2 };`
`153`		`- yield return new object[] { CodeSnippets.InvalidConstantForModuleName, 1, 1 };`
`154`		`- yield return new object[] { CodeSnippets.IncorrectAttributeFieldType, 1, 1 };`
	`152`	`+ yield return new object[] { CodeSnippets.PartialPropertyName, 0, 2 };`
	`153`	`+ yield return new object[] { CodeSnippets.InvalidConstantForModuleName, 0, 1 };`
	`154`	`+ yield return new object[] { CodeSnippets.IncorrectAttributeFieldType, 0, 1 };`
`155`	`155`	`}`
`156`	`156`
`157`	`157`	`[Theory]`