Skip to content

Commit 349bbe9

Browse files
Remove some working tests from issues.targets (#86939)
Fixes #86561 Fixes dotnet/runtimelab#1136
1 parent 7a3a651 commit 349bbe9

File tree

2 files changed

+1
-28
lines changed

2 files changed

+1
-28
lines changed

src/tests/baseservices/threading/coverage/OSThreadId/OSThreadId.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public sealed class OSThreadId
1717
public static int TestEntryPoint()
1818
{
1919
// The property to be tested is internal.
20-
Type runtimeThreadType = typeof(object).Assembly.GetType("System.Threading.Thread");
20+
Type runtimeThreadType = Type.GetType("System.Threading.Thread");
2121
Assert(runtimeThreadType != null);
2222
PropertyInfo osThreadIdProperty = runtimeThreadType.GetProperty("CurrentOSThreadId", BindingFlags.NonPublic | BindingFlags.Static);
2323
Assert(osThreadIdProperty != null);

src/tests/issues.targets

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -706,24 +706,6 @@
706706
<ExcludeList Include="$(XunitTestBinBase)/JIT/Directed/debugging/debuginfo/tester/*">
707707
<Issue>Just-in-time compilation test</Issue>
708708
</ExcludeList>
709-
<ExcludeList Include="$(XunitTestBinBase)/JIT/HardwareIntrinsics/General/Vector128/Vector128_r/*">
710-
<Issue>Not compatible with multifile testing. Problem with detecting that a JIT intrinsic is reflection-used.</Issue>
711-
</ExcludeList>
712-
<ExcludeList Include="$(XunitTestBinBase)/JIT/HardwareIntrinsics/General/Vector128/Vector128_ro/*">
713-
<Issue>Not compatible with multifile testing. Problem with detecting that a JIT intrinsic is reflection-used.</Issue>
714-
</ExcludeList>
715-
<ExcludeList Include="$(XunitTestBinBase)/JIT/HardwareIntrinsics/General/Vector256/Vector256_r/*">
716-
<Issue>Not compatible with multifile testing. Problem with detecting that a JIT intrinsic is reflection-used.</Issue>
717-
</ExcludeList>
718-
<ExcludeList Include="$(XunitTestBinBase)/JIT/HardwareIntrinsics/General/Vector256/Vector256_ro/*">
719-
<Issue>Not compatible with multifile testing. Problem with detecting that a JIT intrinsic is reflection-used.</Issue>
720-
</ExcludeList>
721-
<ExcludeList Include="$(XunitTestBinBase)/JIT/HardwareIntrinsics/General/Vector512/Vector512_r/*">
722-
<Issue>Not compatible with multifile testing. Problem with detecting that a JIT intrinsic is reflection-used.</Issue>
723-
</ExcludeList>
724-
<ExcludeList Include="$(XunitTestBinBase)/JIT/HardwareIntrinsics/General/Vector512/Vector512_ro/*">
725-
<Issue>Not compatible with multifile testing. Problem with detecting that a JIT intrinsic is reflection-used.</Issue>
726-
</ExcludeList>
727709
<ExcludeList Include="$(XunitTestBinBase)/JIT/Intrinsics/TypeIntrinsics_r/*">
728710
<Issue>Not compatible with multifile testing.</Issue>
729711
</ExcludeList>
@@ -739,9 +721,6 @@
739721
<ExcludeList Include="$(XunitTestBinBase)/baseservices/exceptions/stackoverflow/stackoverflowtester/*">
740722
<Issue>Specific to CoreCLR</Issue>
741723
</ExcludeList>
742-
<ExcludeList Include="$(XunitTestBinBase)/baseservices/threading/coverage/OSThreadId/osthreadid/*">
743-
<Issue>Accessing a reflection blocked internal detail</Issue>
744-
</ExcludeList>
745724
<ExcludeList Include="$(XunitTestBinBase)/baseservices/TieredCompilation/**">
746725
<Issue>No crossgen folder under Core_Root</Issue>
747726
</ExcludeList>
@@ -943,9 +922,6 @@
943922
<ExcludeList Include="$(XunitTestBinBase)/JIT/opt/ObjectStackAllocation/ObjectStackAllocationTests/*">
944923
<Issue>Need to pass flag to enable object stack allocation in RyuJIT</Issue>
945924
</ExcludeList>
946-
<ExcludeList Include="$(XunitTestBinBase)/JIT/opt/Devirtualization/Comparer_get_Default/*">
947-
<Issue>https://github.com/dotnet/runtimelab/issues/1136</Issue>
948-
</ExcludeList>
949925
<ExcludeList Include="$(XunitTestBinBase)/JIT/Performance/CodeQuality/BenchmarksGame/fasta/fasta-1/*">
950926
<Issue>Multimodule incompatible (GVM)</Issue>
951927
</ExcludeList>
@@ -1233,13 +1209,10 @@
12331209
<ExcludeList Include="$(XunitTestBinBase)/Loader\classloader\MethodImpl\CovariantReturns\UnitTest\CompatibleWithTest\*" />
12341210
<ExcludeList Include="$(XunitTestBinBase)/Loader\classloader\MethodImpl\CovariantReturns\UnitTest\UnitTest\*" />
12351211
<ExcludeList Include="$(XunitTestBinBase)/Loader\classloader\MethodImpl\CovariantReturns\UnitTest\UnitTest_GVM\*" />
1236-
<ExcludeList Include="$(XunitTestBinBase)/Loader\classloader\MethodImpl\CovariantReturns\UnitTest\UnitTestDelegates\*" />
12371212
<ExcludeList Include="$(XunitTestBinBase)/Loader\classloader\MethodImpl\CovariantReturns\UnitTest\OverrideMoreDerivedReturn\*" />
12381213

12391214
<!-- Requires Debug build -->
12401215
<ExcludeList Include="$(XunitTestBinBase)/JIT\Directed\debugging\poisoning\poison\poison\*" />
1241-
<ExcludeList Include="$(XunitTestBinBase)/JIT\Methodical\eh\finallyexec\nestedfinallycall_d\*" /> <!-- probably RyuJIT bug: https://github.com/dotnet/runtime/issues/86561 -->
1242-
<ExcludeList Include="$(XunitTestBinBase)/JIT\Methodical\eh\finallyexec\nestedfinallycall_r\*" /> <!-- probably RyuJIT bug: https://github.com/dotnet/runtime/issues/86561 -->
12431216
</ItemGroup>
12441217

12451218
<!-- run.proj finds all the *.cmd/*.sh scripts in a test folder and creates corresponding test methods.

0 commit comments

Comments
 (0)