Skip to content

Commit 25a5085

Browse files
liveansliveans
authored
Disable QUIC&HTTP/3 parallelization on tests (#104948)
* Disable QUIC&HTTP/3 parallelization * Disable parallelization on more tests * Disable parallelization on HttpMetrics_Http30_MessageInvoker
1 parent 2b3088b commit 25a5085

File tree

7 files changed

+18
-1
lines changed

7 files changed

+18
-1
lines changed

‎src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
namespace System.Net.Http.Functional.Tests
2323
{
24+
[Collection(nameof(DisableParallelization))]
2425
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
2526
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
2627
public sealed class HttpClientHandlerTest_Http3 : HttpClientHandlerTestBase

‎src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientMiniStressTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ public void CreateAndDestroyManyClients(int numClients)
3131
}
3232
}
3333

34+
[Collection(nameof(DisableParallelization))]
3435
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
3536
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
3637
public sealed class SocketsHttpHandler_HttpClientMiniStress_Http3 : HttpClientMiniStress

‎src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1163,6 +1163,7 @@ public HttpMetricsTest_Http20_HttpMessageInvoker(ITestOutputHelper output) : bas
11631163
}
11641164
}
11651165

1166+
[Collection(nameof(DisableParallelization))]
11661167
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
11671168
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
11681169
public class HttpMetricsTest_Http30 : HttpMetricsTest
@@ -1173,6 +1174,7 @@ public HttpMetricsTest_Http30(ITestOutputHelper output) : base(output)
11731174
}
11741175
}
11751176

1177+
[Collection(nameof(DisableParallelization))]
11761178
public class HttpMetricsTest_Http30_HttpMessageInvoker : HttpMetricsTest_Http30
11771179
{
11781180
protected override bool TestHttpMessageInvoker => true;

‎src/libraries/System.Net.Http/tests/FunctionalTests/ResponseStreamZeroByteReadTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ public Http2ResponseStreamZeroByteReadTest(ITestOutputHelper output) : base(outp
181181
protected override Version UseVersion => HttpVersion.Version20;
182182
}
183183

184+
[Collection(nameof(DisableParallelization))]
184185
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
185186
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
186187
public sealed class Http3ResponseStreamZeroByteReadTest : ResponseStreamZeroByteReadTestBase

‎src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,7 @@ public SocketsHttpHandler_DiagnosticsTest_Http2(ITestOutputHelper output) : base
292292
protected override Version UseVersion => HttpVersion.Version20;
293293
}
294294

295+
[Collection(nameof(DisableParallelization))]
295296
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
296297
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
297298
public sealed class SocketsHttpHandler_DiagnosticsTest_Http3 : DiagnosticsTest
@@ -1710,6 +1711,7 @@ public SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http2(ITest
17101711
protected override Version UseVersion => HttpVersion.Version20;
17111712
}
17121713

1714+
[Collection(nameof(DisableParallelization))]
17131715
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
17141716
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
17151717
public sealed class SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http3 : SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength
@@ -4090,6 +4092,7 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2(ITestOutputH
40904092
protected override Version UseVersion => HttpVersion.Version20;
40914093
}
40924094

4095+
[Collection(nameof(DisableParallelization))]
40934096
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
40944097
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
40954098
public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Http3 : HttpClientHandlerTest
@@ -4098,6 +4101,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3(ITestOutputHelper outp
40984101
protected override Version UseVersion => HttpVersion.Version30;
40994102
}
41004103

4104+
[Collection(nameof(DisableParallelization))]
41014105
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
41024106
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
41034107
public sealed class SocketsHttpHandlerTest_Cookies_Http3 : HttpClientHandlerTest_Cookies
@@ -4106,6 +4110,7 @@ public SocketsHttpHandlerTest_Cookies_Http3(ITestOutputHelper output) : base(out
41064110
protected override Version UseVersion => HttpVersion.Version30;
41074111
}
41084112

4113+
[Collection(nameof(DisableParallelization))]
41094114
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
41104115
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
41114116
public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3 : HttpClientHandlerTest_Headers
@@ -4114,6 +4119,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3(ITestOutputHel
41144119
protected override Version UseVersion => HttpVersion.Version30;
41154120
}
41164121

4122+
[Collection(nameof(DisableParallelization))]
41174123
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
41184124
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
41194125
public sealed class SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3 : SocketsHttpHandler_Cancellation_Test
@@ -4122,6 +4128,7 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3(ITestOutputH
41224128
protected override Version UseVersion => HttpVersion.Version30;
41234129
}
41244130

4131+
[Collection(nameof(DisableParallelization))]
41254132
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
41264133
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
41274134
public sealed class SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3 : HttpClientHandler_AltSvc_Test
@@ -4130,6 +4137,7 @@ public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3(ITestOutputHelper
41304137
protected override Version UseVersion => HttpVersion.Version30;
41314138
}
41324139

4140+
[Collection(nameof(DisableParallelization))]
41334141
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
41344142
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
41354143
public sealed class SocketsHttpHandler_HttpClientHandler_Finalization_Http3 : HttpClientHandler_Finalization_Test
@@ -4288,6 +4296,7 @@ public SocketsHttpHandler_RequestContentLengthMismatchTest_Http2(ITestOutputHelp
42884296
protected override Version UseVersion => HttpVersion.Version20;
42894297
}
42904298

4299+
[Collection(nameof(DisableParallelization))]
42914300
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
42924301
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
42934302
public sealed class SocketsHttpHandler_RequestContentLengthMismatchTest_Http3 : SocketsHttpHandler_RequestContentLengthMismatchTest
@@ -4465,6 +4474,7 @@ public SocketsHttpHandler_SocketsHttpHandler_SecurityTest_Http2(ITestOutputHelpe
44654474
protected override Version UseVersion => HttpVersion.Version20;
44664475
}
44674476

4477+
[Collection(nameof(DisableParallelization))]
44684478
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
44694479
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
44704480
public sealed class SocketsHttpHandler_SocketsHttpHandler_SecurityTest_Http3 : SocketsHttpHandler_SecurityTest
@@ -4594,6 +4604,7 @@ await Http11LoopbackServerFactory.Singleton.CreateClientAndServerAsync(async uri
45944604
}
45954605
}
45964606

4607+
[Collection(nameof(DisableParallelization))]
45974608
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
45984609
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
45994610
public sealed class SocketsHttpHandler_HttpRequestErrorTest_Http30 : SocketsHttpHandler_HttpRequestErrorTest

‎src/libraries/System.Net.Http/tests/FunctionalTests/TelemetryTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -980,6 +980,7 @@ public sealed class TelemetryTest_Http20 : TelemetryTest
980980
public TelemetryTest_Http20(ITestOutputHelper output) : base(output) { }
981981
}
982982

983+
[Collection(nameof(DisableParallelization))]
983984
[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
984985
[ActiveIssue("https://github.com/dotnet/runtime/issues/103703", typeof(PlatformDetection), nameof(PlatformDetection.IsArmProcess))]
985986
public sealed class TelemetryTest_Http30 : TelemetryTest

‎src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestCollection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
namespace System.Net.Quic.Tests;
1616

17-
[CollectionDefinition(nameof(QuicTestCollection))]
17+
[CollectionDefinition(nameof(QuicTestCollection), DisableParallelization = true)]
1818
public unsafe class QuicTestCollection : ICollectionFixture<QuicTestCollection>, IDisposable
1919
{
2020
public static bool IsSupported => QuicListener.IsSupported && QuicConnection.IsSupported;

0 commit comments

Comments
 (0)