Skip to content

Commit 017e701

Browse files
authored
Rename interoplibinterface.cpp -> interoplibinterface_comwrappers.cpp (#56921)
1 parent 019d778 commit 017e701

6 files changed

+22
-30
lines changed

src/coreclr/interop/comwrappers.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include <new> // placement new
1010
#endif // _WIN32
1111

12-
1312
using OBJECTHANDLE = InteropLib::OBJECTHANDLE;
1413
using AllocScenario = InteropLibImports::AllocScenario;
1514
using TryInvokeICustomQueryInterfaceResult = InteropLibImports::TryInvokeICustomQueryInterfaceResult;

src/coreclr/interop/referencetrackertypes.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// Documentation found at https://docs.microsoft.com/windows/win32/api/windows.ui.xaml.hosting.referencetracker/
1010

11-
//64bd43f8-bfee-4ec4-b7eb-2935158dae21
11+
// 64bd43f8-bfee-4ec4-b7eb-2935158dae21
1212
const GUID IID_IReferenceTrackerTarget = { 0x64bd43f8, 0xbfee, 0x4ec4, { 0xb7, 0xeb, 0x29, 0x35, 0x15, 0x8d, 0xae, 0x21} };
1313

1414
class DECLSPEC_UUID("64bd43f8-bfee-4ec4-b7eb-2935158dae21") IReferenceTrackerTarget : public IUnknown
@@ -46,7 +46,7 @@ class DECLSPEC_UUID("04b3486c-4687-4229-8d14-505ab584dd88") IFindReferenceTarget
4646
STDMETHOD(FoundTrackerTarget)(_In_ IReferenceTrackerTarget* target) = 0;
4747
};
4848

49-
//11d3b13a-180e-4789-a8be-7712882893e6
49+
// 11d3b13a-180e-4789-a8be-7712882893e6
5050
const GUID IID_IReferenceTracker = { 0x11d3b13a, 0x180e, 0x4789, { 0xa8, 0xbe, 0x77, 0x12, 0x88, 0x28, 0x93, 0xe6} };
5151

5252
class DECLSPEC_UUID("11d3b13a-180e-4789-a8be-7712882893e6") IReferenceTracker : public IUnknown

src/coreclr/interop/trackerobjectmanager.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,13 @@ using RuntimeCallContext = InteropLibImports::RuntimeCallContext;
99

1010
namespace
1111
{
12-
13-
//29a71c6a-3c42-4416-a39d-e2825a07a773
12+
// 29a71c6a-3c42-4416-a39d-e2825a07a773
1413
const GUID IID_IReferenceTrackerHost = { 0x29a71c6a, 0x3c42, 0x4416, { 0xa3, 0x9d, 0xe2, 0x82, 0x5a, 0x7, 0xa7, 0x73} };
1514

16-
//3cf184b4-7ccb-4dda-8455-7e6ce99a3298
15+
// 3cf184b4-7ccb-4dda-8455-7e6ce99a3298
1716
const GUID IID_IReferenceTrackerManager = { 0x3cf184b4, 0x7ccb, 0x4dda, { 0x84, 0x55, 0x7e, 0x6c, 0xe9, 0x9a, 0x32, 0x98} };
1817

19-
//04b3486c-4687-4229-8d14-505ab584dd88
18+
// 04b3486c-4687-4229-8d14-505ab584dd88
2019
const GUID IID_IFindReferenceTargetsCallback = { 0x04b3486c, 0x4687, 0x4229, { 0x8d, 0x14, 0x50, 0x5a, 0xb5, 0x84, 0xdd, 0x88} };
2120

2221
// In order to minimize the impact of a constructor running on module load,

src/coreclr/vm/CMakeLists.txt

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -562,23 +562,22 @@ list(APPEND VM_SOURCES_WKS
562562
list(APPEND VM_HEADERS_WKS
563563
interoplibinterface.h
564564
)
565-
if(FEATURE_COMWRAPPERS OR FEATURE_OBJCMARSHAL)
566-
if (FEATURE_COMWRAPPERS)
567-
list(APPEND VM_SOURCES_WKS
568-
interoplibinterface.cpp
569-
rcwrefcache.cpp
570-
)
571-
list(APPEND VM_HEADERS_WKS
572-
rcwrefcache.h
573-
)
574-
endif (FEATURE_COMWRAPPERS)
575565

576-
if (FEATURE_OBJCMARSHAL)
577-
list(APPEND VM_SOURCES_WKS
578-
interoplibinterface_objc.cpp
579-
)
580-
endif (FEATURE_OBJCMARSHAL)
581-
endif(FEATURE_COMWRAPPERS OR FEATURE_OBJCMARSHAL)
566+
if(FEATURE_COMWRAPPERS)
567+
list(APPEND VM_SOURCES_WKS
568+
interoplibinterface_comwrappers.cpp
569+
rcwrefcache.cpp
570+
)
571+
list(APPEND VM_HEADERS_WKS
572+
rcwrefcache.h
573+
)
574+
endif(FEATURE_COMWRAPPERS)
575+
576+
if(FEATURE_OBJCMARSHAL)
577+
list(APPEND VM_SOURCES_WKS
578+
interoplibinterface_objc.cpp
579+
)
580+
endif(FEATURE_OBJCMARSHAL)
582581

583582
if(CLR_CMAKE_TARGET_WIN32)
584583

src/coreclr/vm/interoplibinterface.cpp renamed to src/coreclr/vm/interoplibinterface_comwrappers.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@
1919
using CreateObjectFlags = InteropLib::Com::CreateObjectFlags;
2020
using CreateComInterfaceFlags = InteropLib::Com::CreateComInterfaceFlags;
2121

22-
2322
namespace
2423
{
25-
2624
void* GetCurrentCtxCookieWrapper()
2725
{
2826
STATIC_CONTRACT_WRAPPER;
@@ -32,7 +30,6 @@ namespace
3230
#else
3331
return NULL;
3432
#endif // FEATURE_COMINTEROP_APARTMENT_SUPPORT
35-
3633
}
3734

3835
// This class is used to track the external object within the runtime.

src/coreclr/vm/weakreferencenative.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,12 +148,11 @@ NativeComWeakHandleInfo* GetComWeakReferenceInfo(OBJECTREF* pObject)
148148
else
149149
#endif
150150
{
151-
#ifdef FEATURE_COMWRAPPERS
151+
#ifdef FEATURE_COMWRAPPERS
152152
pWeakReferenceSource = reinterpret_cast<IWeakReferenceSource*>(ComWrappersNative::GetIdentityForObject(pObject, IID_IWeakReferenceSource, &wrapperId));
153-
#endif
153+
#endif
154154
}
155155

156-
157156
if (pWeakReferenceSource == nullptr)
158157
{
159158
return nullptr;
@@ -771,7 +770,6 @@ NOINLINE void SetWeakReferenceTarget(WEAKREFERENCEREF weakReference, OBJECTREF t
771770
NewHolder<NativeComWeakHandleInfo> comWeakHandleInfo(GetComWeakReferenceInfo(&target));
772771
#endif // FEATURE_COMINTEROP || FEATURE_COMWRAPPERS
773772

774-
775773
WeakHandleSpinLockHolder handle(AcquireWeakHandleSpinLock(weakReference), &weakReference);
776774
GCX_NOTRIGGER();
777775

0 commit comments

Comments
 (0)