From 9bfe116310a7568259fc32d14220546f94da7355 Mon Sep 17 00:00:00 2001 From: Adam Sitnik Date: Sat, 10 Aug 2019 11:31:56 +0200 Subject: [PATCH 1/2] check if new version of BDN supports .NET Core 5.0 --- azure-pipelines.yml | 4 +++- .../BenchmarkDotNet.Extensions.csproj | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index a1cc88938d6..47882c36895 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -50,6 +50,7 @@ jobs: csproj: src\benchmarks\micro\MicroBenchmarks.csproj runCategories: 'coreclr corefx' frameworks: # for public jobs we want to make sure that the PRs don't break any of the supported frameworks + - netcoreapp5.0 - netcoreapp3.0 - netcoreapp2.2 - netcoreapp2.1 @@ -82,7 +83,7 @@ jobs: csproj: src\benchmarks\micro\MicroBenchmarks.csproj runCategories: 'coreclr corefx' frameworks: # for public jobs we want to make sure that the PRs don't break x86 - - netcoreapp3.0 + - netcoreapp5.0 # Windows x64 micro benchmarks, private job - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}: @@ -130,6 +131,7 @@ jobs: csproj: src/benchmarks/micro/MicroBenchmarks.csproj runCategories: 'coreclr corefx' frameworks: # for public jobs we want to make sure that the PRs don't break any of the supported frameworks + - netcoreapp5.0 - netcoreapp3.0 - netcoreapp2.2 - netcoreapp2.1 diff --git a/src/harness/BenchmarkDotNet.Extensions/BenchmarkDotNet.Extensions.csproj b/src/harness/BenchmarkDotNet.Extensions/BenchmarkDotNet.Extensions.csproj index c30d6293eb9..6e63b6b0b46 100644 --- a/src/harness/BenchmarkDotNet.Extensions/BenchmarkDotNet.Extensions.csproj +++ b/src/harness/BenchmarkDotNet.Extensions/BenchmarkDotNet.Extensions.csproj @@ -6,8 +6,8 @@ - - + + From 74edc539671f2831456bfb9e3c7e5f3aeb1d4a60 Mon Sep 17 00:00:00 2001 From: Adam Sitnik Date: Sat, 10 Aug 2019 12:47:34 +0200 Subject: [PATCH 2/2] this method is now public --- src/harness/BenchmarkDotNet.Extensions/PerfLabExporter.cs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/harness/BenchmarkDotNet.Extensions/PerfLabExporter.cs b/src/harness/BenchmarkDotNet.Extensions/PerfLabExporter.cs index a36dc65dc4b..79d752ab10e 100644 --- a/src/harness/BenchmarkDotNet.Extensions/PerfLabExporter.cs +++ b/src/harness/BenchmarkDotNet.Extensions/PerfLabExporter.cs @@ -30,14 +30,10 @@ public override void ExportToLog(Summary summary, ILogger logger) if (reporter == null) // not running in the perf lab return; - var nameDelegate = typeof(BenchmarkCase).Assembly.GetType("BenchmarkDotNet.Exporters.FullNameProvider").GetMethod("GetBenchmarkName", BindingFlags.Static | BindingFlags.NonPublic); - - foreach (var report in summary.Reports) { var test = new Test(); - //test.Name = FullNameProvider.GetBenchmarkName(report.BenchmarkCase); - test.Name = (string)nameDelegate.Invoke(null, new[] { report.BenchmarkCase }); + test.Name = FullNameProvider.GetBenchmarkName(report.BenchmarkCase); test.Categories = report.BenchmarkCase.Descriptor.Categories; var results = from result in report.AllMeasurements where result.IterationMode == Engines.IterationMode.Workload && result.IterationStage == Engines.IterationStage.Result