Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Remove lttng-modules-dkms package at beginning of microbenchmark runs #101142

Merged

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Apr 16, 2024

Add removal of lttng-modules-dkms package as it is currently causing microbenchmarking runs to fail.
Should fix: dotnet/performance#4149

The removal of the lttng-modules-dkms package using the set command causes the python3-pip package install command to succeed instead of failing as it currently is. This will likely have an impact on our scenario testing that uses Lttng (non-microbenchmarks) as I was unable to get a clean install of the lttng-modules-dkms package on both the 6.5.0-27 and -26 kernels.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caaavik-msft caaavik-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to get pipelines working again, but we should create an issue to track fixing this properly.

@LoopedBard3 LoopedBard3 merged commit e6f1fd8 into dotnet:main Apr 16, 2024
12 of 14 checks passed
@LoopedBard3 LoopedBard3 deleted the PerfTempForceUninstallOfLttngDkms branch April 16, 2024 22:38
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
…rk runs (dotnet#101142)

Add removal of lttng-modules-dkms package as it is currently causing microbenchmarking runs to fail.
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update LTTNG installation to workaround bug
3 participants