Skip to content

Commit 6e941f7

Browse files
authored
Removed a clause that prevented reading GCPerHeapHistories from Workstation GCs traces. (#1693)
1 parent 1dcffab commit 6e941f7

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

src/benchmarks/gc/src/analysis/process_trace.py

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -236,18 +236,15 @@ def _get_processed_gc(
236236

237237

238238
def _get_per_heap_histories(gc: AbstractTraceGC) -> Sequence[Result[str, AbstractGCPerHeapHistory]]:
239-
if gc.HeapCount == 1:
240-
return [Err("Workstation GC has no AbstractGCPerHeapHistories")]
239+
n = len(gc.PerHeapHistories)
240+
if n != gc.HeapCount:
241+
print(
242+
f"WARN: GC {gc.Number} has {gc.HeapCount} heaps, but {n} PerHeapHistories. It's a "
243+
+ f" It's a {get_gc_kind_for_abstract_trace_gc(gc).name}."
244+
)
245+
return repeat(Err("GC has wrong number of PerHeapHistories"), gc.HeapCount)
241246
else:
242-
n = len(gc.PerHeapHistories)
243-
if n != gc.HeapCount:
244-
print(
245-
f"WARN: GC {gc.Number} has {gc.HeapCount} heaps, but {n} PerHeapHistories. It's a "
246-
+ f" It's a {get_gc_kind_for_abstract_trace_gc(gc).name}."
247-
)
248-
return repeat(Err("GC has wrong number of PerHeapHistories"), gc.HeapCount)
249-
else:
250-
return [Ok(h) for h in gc.PerHeapHistories]
247+
return [Ok(h) for h in gc.PerHeapHistories]
251248

252249

253250
def _get_server_gc_heap_histories(

0 commit comments

Comments
 (0)