Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logging best practices for core logging messages #9273

Open
1 task
Meir017 opened this issue Dec 19, 2024 · 2 comments
Open
1 task

Use logging best practices for core logging messages #9273

Meir017 opened this issue Dec 19, 2024 · 2 comments

Comments

@Meir017
Copy link

Meir017 commented Dec 19, 2024

In many of the log messages a logger.IsEnabled call is called to guard the actual logging invocation.

I think we should migrate and use https://learn.microsoft.com/en-us/dotnet/core/extensions/logger-message-generator for logging

https://github.com/search?q=repo%3Adotnet%2Forleans%20logger.isenabled&type=code for reference

@ReubenBond
Copy link
Member

This is a work in progress. PRs welcome

@Meir017
Copy link
Author

Meir017 commented Dec 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants