Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions due to unsolicited connections from monitoring apps remain unmarked and are raised via UnobservedTaskException #9245

Open
d-jagoda opened this issue Nov 22, 2024 · 1 comment

Comments

@d-jagoda
Copy link

Hi we continue to see the following exception despite this fix 9c70847

System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. (Remote connection sent preamble length of 1230262351, which is greater than maximum allowed size of 1024.) ---> System.InvalidOperationException: Remote connection sent preamble length of 1230262351, which is greater than maximum allowed size of 1024. at Orleans.Runtime.Messaging.ConnectionPreambleHelper.Read(ConnectionContext connection) in /_/src/Orleans.Core/Networking/ConnectionPreamble.cs:line 96 at Orleans.Runtime.Messaging.GatewayInboundConnection.RunInternal() in /_/src/Orleans.Runtime/Networking/GatewayInboundConnection.cs:line 110 at Orleans.Runtime.Messaging.Connection.Run() in /_/src/Orleans.Core/Networking/Connection.cs:line 87 --- End of inner exception stack trace ---ConnectionPreambleHelperConnectionPreambleGatewayInboundConnection

The reason for this is the Task managed by this TaskCompletionSource not being observed https://github.com/dotnet/orleans/blob/main/src/Orleans.Core/Networking/Connection.cs#L152

An easy fix would be to observe it as it was done by earlier fix.
_initializationTcs.Task.Ignore();

Happy to to raise a PR.

Thanks in advance

@RyanWood18
Copy link

We're also seeing a similar issue and couldn't work out where it was coming from after we found the earlier fix. Would be great to get this resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants