[Windows] FlyoutPage ShouldShowToolbarButton when overridden to return false, still shows button in title bar

[bmacombe]

Description

Using the Popover behavior

On Android it removes the hamburger icon and on iOS removes the menu text when you override ShouldShowToolbarButton on a FlyoutPage to return false.

But on Windows the hamburger icon is still present in the title bar.

My use case is implementing my own TitleView to make navigation UI consistent across all platforms. The extra hamburger icon on Windows causes no issues being there but is not needed or wanted.

Related Android issue on this topic
#15111

Steps to Reproduce

Set the MainPage as a FlyoutPage
Override ShouldShowToolbarButton to return false
Start app and observe the hamburger button is still present

Link to public reproduction project repository

https://github.com/bmacombe/MauiFlyoutTitleBar

Version with bug

8.0.80 SR8

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

• Shell.BackButtonBehavior interferes with Flyout icon (#23015), similarity score: 0.75

Closed similar issues:

• ShouldShowToolbarButton() override on FlyoutPage not working (#15111), similarity score: 0.81
• Can't see Flyout Hambuger or Back icon (#24358), similarity score: 0.78
• [Windows] App based on FlyoutPage uses incorrect title bar colours when system is set to Dark theme and app set to Light theme - illegible content (#23057), similarity score: 0.76
• [Regression] .NET 8 FlyoutPage Toolbar Missing (#20512), similarity score: 0.76

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

[Zhanglirong-Winnie]

This issue has been verified using Visual Studio 17.12.0 Preview 1.0(8.0.82 & 8.0.80 & 8.0.72). Can repro on Windows platform.

[bmacombe]

Until this is fixed in Maui this can be fixed with a Handler Maping.

#if WINDOWS
		Microsoft.Maui.Handlers.FlyoutViewHandler.Mapper.AppendToMapping(nameof(IFlyoutView.FlyoutBehavior),
			(handler, view) =>
			{
				handler.PlatformView.IsPaneToggleButtonVisible = show;
			});
#endif

[bmacombe]

This line of code needs to respect the value returned from ShouldShowToolbarButton. But I'm not familiar enough with Maui codebase at the moment to do a PR to route that value into the method.

maui/src/Core/src/Platform/Windows/MauiNavigationView.cs

Line 168 in d541b54

IsPaneToggleButtonVisible = true;

[bmacombe]

Slightly revised mapping

#if WINDOWS
		Microsoft.Maui.Handlers.FlyoutViewHandler.Mapper.AppendToMapping(nameof(IFlyoutView.FlyoutBehavior),
			(handler, view) =>
			{
				if (view is FlyoutPage page)
					handler.PlatformView.IsPaneToggleButtonVisible = page.ShouldShowToolbarButton();
			});
#endif