IndicatorView IndicatorTemplate Binding #19004
Conversation
ghost
added
the
|
Hey there @VladislavAntonyuk! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
the
area-controls-collectionview
| @@ -139,6 +141,7 @@ void AddExtraIndicatorItems() | |||
| HeightRequest = size, | |||
| CornerRadius = _indicatorView.IndicatorsShape == IndicatorShape.Circle ? (float)size / 2 : 0 | |||
| }; | |||
| indicator.BindingContext = items[i]; | |||
There was a problem hiding this comment.
Can we add the indicators as logical children to the indicatorview?
There was a problem hiding this comment.
do you mean call _indicatorView.AddLogicalChild(indicator);?
There was a problem hiding this comment.
Apologies on the late response. Looking closer I realize that suggestion isn't correct.
Out of curiosity, do you think this code could get slightly reworked to just use BindableLayout? This class feels like it's kind of just re-implementing BindableLayout.
I worry about other issues cropping up inside the IndicatorStackLayout that have already been considered by BindableLayout
There was a problem hiding this comment.
I am not familiar with BindableLayout. I will take a look if we can replace the layout.
|
@VladislavAntonyuk @PureWeen |
|
/rebase |
|
@VladislavAntonyuk could you rebase so we can get another CI build? |
VladislavAntonyuk
force-pushed
the
indicatorview-itemtemplate-binding
branch
from
f5d6ea8 to
5eab0e2
Compare
@mattleibow done |
|
Is it possible to merge this PR asap? |
|
@PureWeen Is it possible to merge this PR in SR3? |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
There are build errors:
D:\a\_work\1\s\src\Controls\src\Core\IndicatorView\IndicatorStackLayout.cs(159,38): error CS0103: The name '_indicatorViewPropertyChanged' does not exist in the current context [D:\a\_work\1\s\src\Controls\src\Core\Controls.Core.csproj::TargetFramework=net8.0-android]
|
/rebase |
github-actions
bot
force-pushed
the
indicatorview-itemtemplate-binding
branch
from
3189a45 to
05aaf1d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Failing test on core is unrelated |
Description of Change
Set BindingContext for IndicatorTemplate view
Issues Fixed
Fixes xamarin/Xamarin.Forms#9597, xamarin/Xamarin.Forms#10117