Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression/7.0.81] Strange padding problem using grid #16598

Closed
FM1973 opened this issue Aug 8, 2023 · 7 comments
Closed

[regression/7.0.81] Strange padding problem using grid #16598

FM1973 opened this issue Aug 8, 2023 · 7 comments
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter platform/android 🤖 potential-regression This issue described a possible regression on a currently supported version., verification pending t/bug Something isn't working

Comments

@FM1973
Copy link

FM1973 commented Aug 8, 2023

Description

I got a special case where the padding of an outer grid gets doubled on the right side when data changes.
I got a grid. Inside the grid is a verticalstack and inside the stack is another grid with 3 columns. The most left and most right columns have a fixed width of 50. The middle column has a width of STAR.

In the middle column there is an entry. If you change the content of the entry an it reaches the max width of the middle column, the outer grid doubles the padding on the rigtht. It´s hard to explain. Please try the repo.

By the way: it doesn´t matter if I use an entry. You can even put a label in the middle column.
I pinned the maui version to 7.0.92!!!

Steps to Reproduce

  1. Download repo
  2. Start repo
  3. Click on button 'Grid column problem' on the bottom
  4. Change the content of the entry. I.E. 100 for padding 50 or 1000000 for padding 20
  5. The padding of the outer table get´s doubled for the right side

Link to public reproduction project repository

https://github.com/FM1973/RefreshGridRepo.git

Version with bug

7.0.92

Last version that worked well

7.0.52

Affected platforms

Android

Affected platform versions

Android 11 and up

Did you find any workaround?

Not really.

Relevant log output

No response

@FM1973 FM1973 added the t/bug Something isn't working label Aug 8, 2023
@hartez
Copy link
Contributor

hartez commented Aug 8, 2023

In the middle column there is an entry.

It looks like the middle column has a HorizontalStackLayout, not an Entry. If you remove the HSL from the layout and just use the Entry, do things lay out as you expect?

@FM1973
Copy link
Author

FM1973 commented Aug 8, 2023

Doesn´t make a difference. It behaves the same. And it should work with or without a HorizontalStackLayout, shouldn´t it?
Anyway, the same code works pretty well in 7.0.52. There have been a lot of changes on how a grid get´s calculated and in my oppinion version 7.0.52 did work. Starting with 7.0.81 the grid problems started.

@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Aug 8, 2023
@rmarinho rmarinho added the i/regression This issue described a confirmed regression on a currently supported version label Aug 8, 2023
@rmarinho rmarinho added this to the .NET 8 GA milestone Aug 8, 2023
@samhouts samhouts changed the title Strange padding problem using grid [regression/7.0.81] Strange padding problem using grid Aug 8, 2023
@samhouts samhouts added potential-regression This issue described a possible regression on a currently supported version., verification pending and removed i/regression This issue described a confirmed regression on a currently supported version labels Sep 5, 2023
@samhouts samhouts modified the milestones: .NET 8 GA, .NET 7 + Servicing Sep 5, 2023
@DouglasGiovanella
Copy link

Same case here, just the right side doubles the size when using padding. Margin works fine

@PureWeen PureWeen added the s/try-latest-version Please try to reproduce the potential issue on the latest public version label Nov 22, 2023
@ghost
Copy link

ghost commented Nov 22, 2023

Hi @FM1973. We have added the "s/try-latest-version" label to this issue, which indicates that we'd like you to try and reproduce this issue on the latest available public version. This can happen because we think that this issue was fixed in a version that has just been released, or the information provided by you indicates that you might be working with an older version.

You can install the latest version by installing the latest Visual Studio (Preview) with the .NET MAUI workload installed. If the issue still persists, please let us know with any additional details and ideally a reproduction project provided through a GitHub repository.

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@PureWeen
Copy link
Member

If I'm following the repro correctly

I'm not seeing this reproduce in net8

@FM1973
Copy link
Author

FM1973 commented Nov 23, 2023

@PureWeen I can confirm the problem has been solved in 8.0.3

@ghost ghost removed the s/try-latest-version Please try to reproduce the potential issue on the latest public version label Nov 23, 2023
@MichaelShapiro
Copy link

I can confirm too - this issue doesn't exist in mau .bet 8.0.3.

@github-project-automation github-project-automation bot moved this from Todo to Done in MAUI SDK Ongoing Nov 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter platform/android 🤖 potential-regression This issue described a possible regression on a currently supported version., verification pending t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants