Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Fix numerous marshalling bugs in the dynamic registrar. #22209

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[runtime] Fix numerous marshalling bugs in the dynamic registrar. #22209

wants to merge 3 commits into from

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Feb 18, 2025 •
edited
Loading

DRAFT: no need to review yet.

Fixes #22196.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 2dfedb893018b9891d62ad20eb34a51b20e5ebcc [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 2dfedb893018b9891d62ad20eb34a51b20e5ebcc [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 2dfedb893018b9891d62ad20eb34a51b20e5ebcc [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Monterey (12) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 2dfedb893018b9891d62ad20eb34a51b20e5ebcc [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS arm64 - Mac Sequoia (15) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 2dfedb893018b9891d62ad20eb34a51b20e5ebcc [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS X64 - Mac Sonoma (14) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 2dfedb893018b9891d62ad20eb34a51b20e5ebcc [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Ventura (13) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 2dfedb893018b9891d62ad20eb34a51b20e5ebcc [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 2dfedb893018b9891d62ad20eb34a51b20e5ebcc [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 2dfedb893018b9891d62ad20eb34a51b20e5ebcc [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 36 tests failed, 76 tests passed.

Failures

❌ monotouch tests (iOS)

8 tests failed, 0 tests passed.
  • monotouch-test/iOS - simulator/Debug: Crashed
  • monotouch-test/iOS - simulator/Debug (LinkSdk): Crashed
  • monotouch-test/iOS - simulator/Debug (static registrar): Crashed
  • monotouch-test/iOS - simulator/Release (all optimizations): Crashed
  • monotouch-test/iOS - simulator/Debug (managed static registrar): Crashed
  • monotouch-test/iOS - simulator/Release (managed static registrar, all optimizations): Crashed
  • monotouch-test/iOS - simulator/Release (NativeAOT, x64): Crashed
  • monotouch-test/iOS - simulator/Debug (interpreter): Crashed

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

11 tests failed, 0 tests passed.
  • monotouch-test/Mac Catalyst/Debug: Failed (Test run crashed (exit code: 132).
    Test run crashed)
  • monotouch-test/Mac Catalyst/Debug (managed static registrar): Failed (Test run crashed (exit code: 255).
    Test run crashed)
  • monotouch-test/Mac Catalyst/Debug (static registrar): Failed (Test run crashed (exit code: 255).
    Test run crashed)
  • monotouch-test/Mac Catalyst/Release (managed static registrar): Failed (Test run crashed (exit code: 255).
    Test run crashed)
  • monotouch-test/Mac Catalyst/Release (managed static registrar, all optimizations): Failed (Test run crashed (exit code: 255).
    Test run crashed)
  • monotouch-test/Mac Catalyst/Release (NativeAOT): Failed (Test run crashed (exit code: 139).
    Test run crashed)
  • monotouch-test/Mac Catalyst/Release (NativeAOT, x64): Failed (Test run crashed (exit code: 139).
    Test run crashed)
  • monotouch-test/Mac Catalyst/Release (static registrar): Failed (Test run crashed (exit code: 255).
    Test run crashed)
  • monotouch-test/Mac Catalyst/Release (static registrar, all optimizations): Failed (Test run crashed (exit code: 255).
    Test run crashed)
  • monotouch-test/Mac Catalyst/Debug (interpreter): Failed (Test run crashed (exit code: 255).
    Test run crashed)
  • monotouch-test/Mac Catalyst/Release (interpreter): TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

9 tests failed, 0 tests passed.
  • monotouch-test/macOS/Debug: Failed (Test run crashed (exit code: 134).
    Test run crashed)
  • monotouch-test/macOS/Debug (managed static registrar): Failed (Test run crashed (exit code: 139).
    Test run crashed)
  • monotouch-test/macOS/Debug (static registrar): Failed (Test run crashed (exit code: 139).
    Test run crashed)
  • monotouch-test/macOS/Release (managed static registrar): Failed (Test run crashed (exit code: 139).
    Test run crashed)
  • monotouch-test/macOS/Release (managed static registrar, all optimizations): Failed (Test run crashed (exit code: 139).
    Test run crashed)
  • monotouch-test/macOS/Release (NativeAOT): Failed (Test run crashed (exit code: 139).
    Test run crashed)
  • monotouch-test/macOS/Release (NativeAOT, x64): Failed (Test run crashed (exit code: 139).
    Test run crashed)
  • monotouch-test/macOS/Release (static registrar): Failed (Test run crashed (exit code: 139).
    Test run crashed)
  • monotouch-test/macOS/Release (static registrar, all optimizations): Failed (Test run crashed (exit code: 139).
    Test run crashed)

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

8 tests failed, 0 tests passed.
  • monotouch-test/tvOS - simulator/Debug: Crashed
  • monotouch-test/tvOS - simulator/Debug (LinkSdk): Crashed
  • monotouch-test/tvOS - simulator/Debug (static registrar): Crashed
  • monotouch-test/tvOS - simulator/Release (all optimizations): Crashed
  • monotouch-test/tvOS - simulator/Debug (managed static registrar): Crashed
  • monotouch-test/tvOS - simulator/Release (managed static registrar, all optimizations): Crashed
  • monotouch-test/tvOS - simulator/Release (NativeAOT, x64): Crashed
  • monotouch-test/tvOS - simulator/Debug (interpreter): TimedOut

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 2dfedb893018b9891d62ad20eb34a51b20e5ebcc [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overriding MKTileOverlay.LoadTileAtPath crashes my app with SIGSEGV
2 participants
@rolfbjarne @vs-mobiletools-engineering-service2