Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness issue - Unsafe cast requires generic type to be non-null #18275

Open
2 of 7 tasks
Lanayx opened this issue Jan 27, 2025 · 0 comments
Open
2 of 7 tasks

Nullness issue - Unsafe cast requires generic type to be non-null #18275

Lanayx opened this issue Jan 27, 2025 · 0 comments
Assignees
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone

Comments

@Lanayx
Copy link
Contributor

Lanayx commented Jan 27, 2025

Issue description

Image

I suggest that unsafe cast shouldn't impose any restrictions on 'T, it can be nullable, non-nullable or any other type, it should be fully generic. There is nothing in initial code about nullables, so it's very confusing to user to see such error.

The build currently works for me in 9.0.1 SDK, but breaking change is coming according to this ticket https://youtrack.jetbrains.com/issue/RIDER-121095/Non-existing-NRT-related-errors

Choose one or more from the following categories of impact

  • Unexpected nullness warning (false positive in nullness checking, code uses --checknulls and langversion:preview).
  • Missing nullness warning in a case which can produce nulls (false negative, code uses --checknulls and langversion:preview).
  • Breaking change related to older null constructs in code not using the checknulls switch.
  • Breaking change related to generic code and explicit type constraints (null, not null).
  • Type inference issue (i.e. code worked without type annotations before, and applying the --checknulls enforces type annotations).
  • C#/F# interop issue related to nullness metadata.
  • Other (none of the categories above apply).

Operating System

Windows (Default)

What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

.NET Runtime/SDK version

.NET SDK 9.0.101

Reproducible code snippet and actual behavior

let test<'T> () =
    let t = obj()
    t :?> 'T

Possible workarounds

let test<'T> () =
    let t: obj | null = obj()
    t :?> 'T

or

let test<'T> () =
    let t = obj()
    t |> unbox<'T>
@Lanayx Lanayx added Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage labels Jan 27, 2025
@github-actions github-actions bot added this to the Backlog milestone Jan 27, 2025
@T-Gro T-Gro removed their assignment Jan 28, 2025
@0101 0101 added Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. and removed Needs-Triage labels Feb 3, 2025
@T-Gro T-Gro self-assigned this Feb 4, 2025
@T-Gro T-Gro modified the milestones: Backlog, February 2025 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
Status: New
Development

No branches or pull requests

3 participants