From 79c587765c027e1cad26a0fbd00679ad290a2c37 Mon Sep 17 00:00:00 2001 From: Omair Majid Date: Mon, 10 Jun 2024 15:02:20 -0400 Subject: [PATCH] Dispose StreamReader reading from disk in XmlDocReader We create a `StreamReader` via `File.OpenText`, but never `Dispose()` it. Wrap it in a `using` statement to automatically `Dispose()` it when `TryLoad(TextReader, ...)` is done using it. --- src/System.CommandLine.DragonFruit/XmlDocReader.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/System.CommandLine.DragonFruit/XmlDocReader.cs b/src/System.CommandLine.DragonFruit/XmlDocReader.cs index 227b30cb8c..20f16728c5 100644 --- a/src/System.CommandLine.DragonFruit/XmlDocReader.cs +++ b/src/System.CommandLine.DragonFruit/XmlDocReader.cs @@ -23,7 +23,8 @@ public static bool TryLoad(string filePath, out XmlDocReader xmlDocReader) { try { - return TryLoad(File.OpenText(filePath), out xmlDocReader); + using var fileStreamReader = File.OpenText(filePath); + return TryLoad(fileStreamReader, out xmlDocReader); } catch {