Skip to content

Commit 1f74396

Browse files
authored
Merge pull request #96 from sfoslund/RestructureCommands
Restructure commands
2 parents c5d79a6 + abca350 commit 1f74396

31 files changed

+2378
-739
lines changed

src/dotnet-core-uninstall/LocalizableStrings.Designer.cs

Lines changed: 121 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/dotnet-core-uninstall/LocalizableStrings.resx

Lines changed: 52 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -166,16 +166,16 @@
166166
<value>Remove .NET Core SDKs or Runtimes, except those specified.</value>
167167
</data>
168168
<data name="UninstallAllLowerPatchesOptionDescription" xml:space="preserve">
169-
<value>Remove .NET Core SDKs or Runtimes that have been superceded by higher patches.</value>
169+
<value>Remove .NET Core SDKs or Runtimes superseded by higher patches. Protects global.json.</value>
170170
</data>
171171
<data name="UninstallAllOptionDescription" xml:space="preserve">
172172
<value>Remove all .NET Core SDKs or Runtimes.</value>
173173
</data>
174174
<data name="UninstallAllPreviewsButLatestOptionDescription" xml:space="preserve">
175-
<value>Remove .NET Core SDKs or Runtimes that are marked as previews, except the one highest preview.</value>
175+
<value>Remove .NET Core SDKs or Runtimes marked as previews, except the one highest preview.</value>
176176
</data>
177177
<data name="UninstallAllPreviewsOptionDescription" xml:space="preserve">
178-
<value>Remove .NET Core SDKs or Runtimes that are marked as previews.</value>
178+
<value>Remove .NET Core SDKs or Runtimes marked as previews.</value>
179179
</data>
180180
<data name="UninstallationFailedExceptionMessageFormat" xml:space="preserve">
181181
<value>Timeout during uninstall: {0}.</value>
@@ -190,13 +190,13 @@
190190
<value>Remove .NET Core SDKs or Runtimes that match the specified `major.minor` version.</value>
191191
</data>
192192
<data name="UninstallNoOptionArgumentDescription" xml:space="preserve">
193-
<value>The specified version to uninstall. You may list several versions, and response files are supported.</value>
193+
<value>The specified version to uninstall. You may list several versions. Response files are supported.</value>
194194
</data>
195195
<data name="UninstallNoOptionArgumentName" xml:space="preserve">
196196
<value>VERSION</value>
197197
</data>
198-
<data name="UninstallNoOptionDescription" xml:space="preserve">
199-
<value>Remove specified .NET Core SDKs or Runtimes. This tool can only uninstall items that were installed using .NET Core SDK or Runtime installers. Read the documentation of this tool at https://aka.ms/dotnet-core-uninstall.</value>
198+
<data name="UninstallNoOptionDescriptionWindows" xml:space="preserve">
199+
<value>Remove specified .NET Core SDKs or Runtimes. This tool can only uninstall items that were installed using Visual Studio, .NET Core SDK, or Runtime installers. By default, this tool does not uninstall versions that might be needed for Visual Studio. Read the documentation for the .NET Core Uninstall Tool at https://aka.ms/dotnet-core-uninstall.</value>
200200
</data>
201201
<data name="VerbosityOptionArgumentName" xml:space="preserve">
202202
<value>LEVEL</value>
@@ -256,18 +256,18 @@
256256
<value>List .NET Core Runtime &amp; Hosting Bundles.</value>
257257
</data>
258258
<data name="ListRuntimeOptionDescription" xml:space="preserve">
259-
<value>List .NET Core Runtimes.</value>
259+
<value>List .NET Core Runtimes that can be uninstalled.</value>
260260
</data>
261261
<data name="ListSdkOptionDescription" xml:space="preserve">
262-
<value>List .NET Core SDKs.</value>
262+
<value>List .NET Core SDKs that can be uninstalled.</value>
263263
</data>
264264
<data name="ListX64OptionDescription" xml:space="preserve">
265265
<value>List x64 .NET Core SDKs or Runtimes.</value>
266266
</data>
267267
<data name="ListX86OptionDescription" xml:space="preserve">
268268
<value>List x86 .NET Core SDKs or Runtimes.</value>
269269
</data>
270-
<data name="DryRunOptionDescription" xml:space="preserve">
270+
<data name="DryRunCommandDescription" xml:space="preserve">
271271
<value>Display .NET Core SDKs and Runtimes that will be removed.</value>
272272
</data>
273273
<data name="YesOptionDescription" xml:space="preserve">
@@ -281,7 +281,7 @@ Specified versions:
281281

282282
To avoid breaking Visual Studio or other problems, read https://aka.ms/dotnet-core-uninstall.
283283

284-
Run this command as administrator, and take out the -—dry-run option to remove these items.</value>
284+
Run as administrator and use the remove command to uninstall these items.</value>
285285
</data>
286286
<data name="ConfirmationPromptOutputFormat" xml:space="preserve">
287287
<value>The following items will be removed:
@@ -294,7 +294,47 @@ Do you want to continue? [Y/n] </value>
294294
<data name="ConfirmationPromptInvalidExceptionMessage" xml:space="preserve">
295295
<value>Allowed values are "Y" and "n".</value>
296296
</data>
297-
<data name="ListIncludeRequiredOptionDescription" xml:space="preserve">
298-
<value>Include .NET Core SDKs that cannot be uninstalled.</value>
297+
<data name="RemoveCommandDescription" xml:space="preserve">
298+
<value>Remove the specified .NET Core SDKs or Runtimes.</value>
299+
</data>
300+
<data name="UninstallNotAllowedExceptionFormat" xml:space="preserve">
301+
<value>Uninstallation not allowed. This tool cannot uninstall .NET Core SDKs with version {0} or above.</value>
302+
</data>
303+
<data name="RequiredBundleConfirmationPromptOutputFormat" xml:space="preserve">
304+
<value>
305+
{0}: {1}
306+
307+
Uninstalling this item will cause Visual Studio to break.
308+
309+
Are you sure you want to continue? [Y/n] </value>
310+
</data>
311+
<data name="RequiredBundleConfirmationPromptWarningFormat" xml:space="preserve">
312+
<value>
313+
Warning: {0}: {1}
314+
Uninstalling this item will cause Visual Studio to break.
315+
</value>
316+
</data>
317+
<data name="VersionOptionDescription" xml:space="preserve">
318+
<value>Display .NET Core Uninstall Tool version information.</value>
319+
</data>
320+
<data name="UpperLimitRequirement" xml:space="preserve">
321+
<value>Cannot uninstall version {0} and above</value>
322+
</data>
323+
<data name="RequirementExplainationString" xml:space="preserve">
324+
<value>Maybe needed for Visual Studio{0}. Specify individually or use —-force to remove</value>
325+
</data>
326+
<data name="ForceOptionDescriptionWindows" xml:space="preserve">
327+
<value>Force removal of versions that might be used by Visual Studio.</value>
328+
</data>
329+
<data name="ForceOptionDescriptionMac" xml:space="preserve">
330+
<value>Force removal of versions that might be used by Visual Studio or SDK.</value>
331+
</data>
332+
<data name="ListCommandOutput" xml:space="preserve">
333+
<value>
334+
This tool can not uninstall versions of the runtime or SDK that are installed using Visual Studio 2019 Update 3 or via zip/scripts. The versions that can be uninstalled with this tool are:
335+
</value>
336+
</data>
337+
<data name="UninstallNoOptionDescriptionMac" xml:space="preserve">
338+
<value>Remove specified .NET Core SDKs or Runtimes. This tool can only uninstall items that were installed using Visual Studio, .NET Core SDK, or Runtime installers. By default, this tool does not uninstall versions that might be needed for Visual Studio or SDKs. Read the documentation for the .NET Core Uninstall Tool at https://aka.ms/dotnet-core-uninstall.</value>
299339
</data>
300340
</root>

src/dotnet-core-uninstall/MacOs/SupportedBundleTypeConfigs.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace Microsoft.DotNet.Tools.Uninstall.MacOs
1010
{
1111
internal static class SupportedBundleTypeConfigs
1212
{
13-
private static readonly Func<IDictionary<Bundle, string>, GridView> _gridViewGeneratorWithArch = bundles =>
13+
private static readonly Func<IDictionary<Bundle, string>, bool, GridView> _gridViewGeneratorWithArch = (bundles, verbose) =>
1414
{
1515
var gridView = new GridView();
1616

@@ -22,7 +22,7 @@ internal static class SupportedBundleTypeConfigs
2222
gridView.SetChild(new ContentView(string.Empty), 0, index);
2323
gridView.SetChild(new ContentView(bundle.Key.Version.ToString()), 1, index);
2424
gridView.SetChild(new ContentView($"({bundle.Key.Arch.ToString().ToLower()})"), 2, index);
25-
gridView.SetChild(new ContentView(bundle.Value), 3, index);
25+
gridView.SetChild(new ContentView(bundle.Value.Equals(string.Empty) ? string.Empty : $"[{bundle.Value}]"), 3, index);
2626
}
2727

2828
return gridView;

0 commit comments

Comments
 (0)