You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Seems the 9.1 template change to use two separate options for AspireVersion that are dynamically enabled/disabled based on the selected target framework doesn't work in C# Dev Kit:
Note that in Visual Studio, the File -> New Project dialog experience hides options dynamically as their enabled status changes based on the values selected for other options, which is why it works fine there.
There are a few places we need to address this if we fully want to implement conditional parameters. One of the issues is that in VS code, we don't have full conditional support, the current support appears to be limited to checking if a parameter is set to a value in a set (with some negation options as well), so to do full conditional support, we'd need a parser which we don't have.
I think we may be able to get by with a targetted fix for aspire instead of fully supporting the full range of conditional parameters, we could just update the Generic Parameter provider to look at the isEnabled properties which are used in the template, and pattern match to try to pull out the framework parameters in order to restrict the framework choice even further for each option. We can add full conditional support to the long term backlog.
These is what we would need to match.
"isEnabled": "Framework == net9.0"
and
"isEnabled": "(Framework == net8.0 || hostIdentifier == dotnetcli || hostIdentifier == "dotnetcli-preview")",
I think the second one can be simplified to just "isEnabled":"Framework == net8.0" as we have a separate option for the CLI now. I think the rest of that condition is obsolete now and could be removed.
Seems the 9.1 template change to use two separate options for AspireVersion that are dynamically enabled/disabled based on the selected target framework doesn't work in C# Dev Kit:
@phenning is that something you own now?
The text was updated successfully, but these errors were encountered: