Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebToolsE2E][Aspire] During the creation of Aspire projects, the option for the .NET Aspire version is doubled after installing Aspire 9.1 in VS 17.10. #7348

Open
vmykagapuz opened this issue Jan 31, 2025 · 4 comments
Assignees
Milestone

Comments

@vmykagapuz
Copy link

vmykagapuz commented Jan 31, 2025

INSTALL STEPS

  1. Clean machine: Win11 x64 23h2 ENU
  2. Install VS 17.10.11
  3. Install latest Aspire 9.1.0-preview.1.25080.7

NOTE

  1. This issue occurs for all Aspire templates except the .NET Aspire Empty App.
  2. This issue only occurs in VS 17.10, which includes only the 8.0 framework.

REPRO STEPS

  1. Open VS
  2. Select .NET Aspire Starter (or other aspire templates) and check the project creation options

ACTUAL
There are two options for the .NET Aspire version. The first option includes version 8.2, while the second one has none

Image

Image

Image

EXPECTED
There should be only one option for the .NET Aspire version during project creation.

@balachir
Copy link

@DamianEdwards @phenning is this due to the change from PR #7229 ? Is the fix on the Aspire templates or do we need a change in VS 17.10? If it's the latter, then we should try to fix this for the Feb update for VS 17.10.

@JakeRadMSFT @joperezr

@phenning
Copy link
Contributor

Feels like a template issue we should address.

@phenning
Copy link
Contributor

phenning commented Jan 31, 2025

What the issue is here is that the templates are now exposing two "AspireVersion" symbols, each with a conditional in them "isEnabled" in the template.json. Conditional enablement/disablement of symbols in Visual Studio was only added post 17.10, so in 17.10 the result is both parameters being displayed.

We have two potential options.

  1. Port the conditional logic back to 17.10 and service it.
  2. Make the 9.1 templates not support VS Versions < 17.12 - this should be able to be done via the ide.host.json, by updating the unsupportedHosts version range.

@DamianEdwards
Copy link
Member

My vote is for option 1: keep templates as is, document the issue for Aspire 9.1 for folks using <=VS 17.10, and service 17.10 ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants